chore: switch to ruff (baserow#4387)

* Switch to ruff

* Fix flaky test

* Remove frontend-lint changes

* Fix all-in-one image creation in CI

* Update saas target

* Add changelog entry

* Fix PYTHONPATH for lint-migrations

* Run check-migrations in the CI

Author: silvestrid

.github/workflows/ci.yml

@@ -200,22 +200,21 @@ jobs:
     name: Backend Lint
     runs-on: ubuntu-latest
     needs:
-      - build-backend
       - detect-changes
     if: needs.detect-changes.outputs.backend == 'true' || github.ref_name == 'develop' || github.ref_name == 'master'
-    permissions:
-      contents: read
-      packages: read
     steps:
-      - name: Log in to GitHub Container Registry
-        uses: docker/login-action@v3
+      - uses: actions/checkout@v4
+
+      - name: Install uv
+        uses: astral-sh/setup-uv@v4
         with:
-          registry: ${{ env.REGISTRY }}
-          username: ${{ github.actor }}
-          password: ${{ secrets.GITHUB_TOKEN }}
+          version: "0.5.6"
 
-      - name: Run backend lint
-        run: docker run --rm ${{ needs.build-backend.outputs.image }} lint
+      - name: Run ruff
+        working-directory: backend
+        run: |
+          uvx ruff check src/ ../premium/backend/src/ ../enterprise/backend/src/ tests/ ../premium/backend/tests/ ../enterprise/backend/tests/
+          uvx ruff format --check src/ ../premium/backend/src/ ../enterprise/backend/src/ tests/ ../premium/backend/tests/ ../enterprise/backend/tests/
 
   frontend-lint:
     name: Web-Frontend Lint
@@ -361,12 +360,22 @@ jobs:
             -e DATABASE_USER=baserow \
             -e DATABASE_PASSWORD=baserow \
             ${{ needs.build-backend.outputs.image }} ci-check-startup-oss-only
+      - name: Check backend migrations
+        run: |
+          docker run --rm --network="${{ job.services.db.network }}" \
+            -e DATABASE_HOST=db \
+            -e DATABASE_PORT=5432 \
+            -e DATABASE_NAME=baserow \
+            -e DATABASE_USER=baserow \
+            -e DATABASE_PASSWORD=baserow \
+            ${{ needs.build-backend.outputs.image }} ci-check-migrations
 
   test-backend:
     name: Backend Tests (Group ${{ matrix.group }})
     runs-on: ubuntu-latest
     needs:
       - build-backend
+      - backend-lint
       - detect-changes
     if: needs.detect-changes.outputs.backend == 'true' || github.ref_name == 'develop' || github.ref_name == 'master'
     permissions:
@@ -975,8 +984,8 @@ jobs:
           file: deploy/all-in-one/Dockerfile
           push: true
           build-args: |
-            FROM_BACKEND_IMAGE=${{ env.REGISTRY }}/${{ env.IMAGE_REPO }}/backend:ci-tested-${{ env.REAL_GITHUB_SHA }}
-            FROM_WEBFRONTEND_IMAGE=${{ env.REGISTRY }}/${{ env.IMAGE_REPO }}/web-frontend:ci-tested-${{ env.REAL_GITHUB_SHA }}
+            BACKEND_IMAGE=${{ env.REGISTRY }}/${{ env.IMAGE_REPO }}/backend:ci-tested-${{ env.REAL_GITHUB_SHA }}
+            WEBFRONTEND_IMAGE=${{ env.REGISTRY }}/${{ env.IMAGE_REPO }}/web-frontend:ci-tested-${{ env.REAL_GITHUB_SHA }}
           tags: |
             ${{ env.REGISTRY }}/${{ env.IMAGE_REPO }}/baserow:ci-tested-${{ env.REAL_GITHUB_SHA }}
           cache-from: type=gha,scope=all-in-one

.gitlab/ci_includes/jobs.yml

@@ -1,6 +1,6 @@
 # ============== "Abstract" ci stages used by real stages =======================
 
-# Builds a dev version of a specific Dockerfile (--target dev) using a previous CI
+# Builds a dev version of a specific Dockerfile (--target ci) using a previous CI
 # image or the latest develop image as a cache to speed up the build. Tags and pushes
 # the resulting dev image for later stages in the pipeline to use.
 #
@@ -149,7 +149,7 @@
         $EXTRA_BUILD_ARGS \
         $IMAGE_LABELS \
         --push \
-        --target dev \
+        --target ci \
         --tag $CI_IMAGE_PATH \
         -f $DOCKERFILE_PATH .;
 

backend/.flake8

@@ -363,6 +363,9 @@ case "$1" in
     ci-check-startup-oss-only)
         exec just ci-check-startup-oss-only
     ;;
+    ci-check-migrations)
+        exec just check-migrations
+    ;;
     celery-worker)
       if [[ -n "${BASEROW_RUN_MINIMAL}" && $BASEROW_AMOUNT_OF_WORKERS == "1" ]]; then
         export OTEL_SERVICE_NAME="celery-worker-combined"