Prevent 404 errors from being sent to Sentry (baserow#4836)

jonadeline · web-flow · commit 8237644b4468 · 2026-02-25T16:26:56.000+04:00
diff --git a/backend/uv.lock b/backend/uv.lock
diff --git a/premium/web-frontend/modules/baserow_premium/pages/admin/license.vue b/premium/web-frontend/modules/baserow_premium/pages/admin/license.vue
@@ -216,19 +216,26 @@ const router = useRouter()
 const { $client, $registry } = useNuxtApp()
 
 // Fetch license data
-const { data } = await useAsyncData(`license-${route.params.id}`, async () => {
-  try {
-    const { data: licenseData } = await LicenseService($client).fetch(
-      route.params.id
-    )
-    return licenseData
-  } catch {
-    throw createError({
-      statusCode: 404,
-      message: 'The license was not found.',
-    })
+const { data, error } = await useAsyncData(
+  `license-${route.params.id}`,
+  async () => {
+    try {
+      const { data: licenseData } = await LicenseService($client).fetch(
+        route.params.id
+      )
+      return licenseData
+    } catch {
+      throw createError({
+        statusCode: 404,
+        message: 'The license was not found.',
+      })
+    }
   }
-})
+)
+
+if (error.value) {
+  throw error.value
+}
 
 const license = computed(() => data.value)
 
diff --git a/premium/web-frontend/modules/baserow_premium/pages/admin/licenses.vue b/premium/web-frontend/modules/baserow_premium/pages/admin/licenses.vue
@@ -169,7 +169,7 @@ const { $client, $registry, $i18n } = useNuxtApp()
 useHead({ title: $i18n.t('licenses.titleLicenses') })
 
 // Fetch data using useAsyncData and return the values from the callback
-const { data } = await useAsyncData('licensesPage', async () => {
+const { data, error } = await useAsyncData('licensesPage', async () => {
   try {
     const [{ data: instanceData }, { data: licensesData }] = await Promise.all([
       SettingsService($client).getInstanceID(),
@@ -183,11 +183,16 @@ const { data } = await useAsyncData('licensesPage', async () => {
   } catch (e) {
     throw createError({
       statusCode: 400,
-      statusMessage: 'Something went wrong while fetching the licenses.',
+      message: 'Something went wrong while fetching the licenses.',
+      fatal: true,
     })
   }
 })
 
+if (error.value) {
+  throw error.value
+}
+
 const licenses = computed(() => data.value?.licenses || [])
 const instanceId = computed(() => data.value?.instanceId || '')
 
diff --git a/web-frontend/modules/automation/pages/automationWorkflow.vue b/web-frontend/modules/automation/pages/automationWorkflow.vue
@@ -108,7 +108,7 @@ const automationApplicationType = $registry.get(
   AutomationApplicationType.getType()
 )
 
-const { data: pageData } = await useAsyncData(
+const { data: pageData, error } = await useAsyncData(
   () => `automation-workflow-${automationId.value}-${workflowId.value}`,
   async () => {
     try {
@@ -151,6 +151,10 @@ const { data: pageData } = await useAsyncData(
   }
 )
 
+if (error.value) {
+  throw error.value
+}
+
 // Computed properties from async data
 const automation = computed(() => pageData.value?.automation ?? null)
 const workspace = computed(() => pageData.value?.workspace ?? null)
diff --git a/web-frontend/modules/builder/middleware/selectWorkspaceBuilderPage.js b/web-frontend/modules/builder/middleware/selectWorkspaceBuilderPage.js
@@ -25,7 +25,6 @@ export default defineNuxtRouteMiddleware(async (to, from) => {
     throw createError({
       statusCode: 404,
       message: $i18n.t('pageEditor.pageNotFound'),
-      fatal: false,
     })
   }
 })
diff --git a/web-frontend/modules/builder/pages/pageEditor.vue b/web-frontend/modules/builder/pages/pageEditor.vue
@@ -104,12 +104,7 @@ const {
 )
 
 if (pageError.value) {
-  // If we have an error we want to display it.
-  if (pageError.value.statusCode === 404) {
-    showError(pageError.value)
-  } else {
-    throw pageError.value
-  }
+  throw pageError.value
 }
 
 const workspace = computed(() => pageData.value.workspace)
diff --git a/web-frontend/modules/builder/pages/publicPage.vue b/web-frontend/modules/builder/pages/publicPage.vue
@@ -97,7 +97,7 @@ const {
       } catch (e) {
         throw createError({
           statusCode: 404,
-          statusMessage: $i18n.t('publicPage.siteNotFound'),
+          message: $i18n.t('publicPage.siteNotFound'),
         })
       }
 
@@ -173,7 +173,7 @@ const {
         if (authError) {
           throw createError({
             statusCode: authError.code,
-            statusMessage: authError.message,
+            message: authError.message,
           })
         }
       }
@@ -190,7 +190,7 @@ const {
     if (!found) {
       throw createError({
         statusCode: 404,
-        statusMessage: $i18n.t('publicPage.pageNotFound'),
+        message: $i18n.t('publicPage.pageNotFound'),
       })
     }
 
@@ -199,7 +199,7 @@ const {
     if (pageFound.shared) {
       throw createError({
         statusCode: 404,
-        statusMessage: $i18n.t('publicPage.pageNotFound'),
+        message: $i18n.t('publicPage.pageNotFound'),
       })
     }
 
@@ -288,12 +288,7 @@ const {
 )
 
 if (error.value) {
-  // If we have an error we want to display it.
-  if (error.value.statusCode === 404) {
-    showError(error.value)
-  } else {
-    throw error.value
-  }
+  throw error.value
 }
 
 const workspace = computed(() => asyncDataResult.value?.workspace)
diff --git a/web-frontend/modules/core/middleware/urlCheck.js b/web-frontend/modules/core/middleware/urlCheck.js
@@ -35,6 +35,7 @@ export default defineNuxtRouteMiddleware(() => {
           hideBackButton: true,
           message: translate('urlCheck.invalidUrlEnvVarTitle', { name }),
           content: translate('urlCheck.invalidUrlEnvVarDescription', { name }),
+          fatal: true,
         })
       }
     }
diff --git a/web-frontend/modules/core/module.js b/web-frontend/modules/core/module.js
@@ -112,6 +112,7 @@ export default defineNuxtModule({
     )
 
     addPlugin(resolve('plugins/store.js'))
+    addPlugin(resolve('plugins/errorHandler.js'))
     addPlugin(resolve('plugins/filters.js'))
     addPlugin(resolve('plugins/vuexState.js'))
     addPlugin(resolve('plugin.js'))
diff --git a/web-frontend/modules/core/pages/notificationRedirect.vue b/web-frontend/modules/core/pages/notificationRedirect.vue
@@ -15,19 +15,23 @@ const notificationId = route.params.notificationId
 const { data: notification, error: loadError } = await useAsyncData(
   () => `notification:${workspaceId}:${notificationId}`,
   async () => {
-    const { data } = await notificationService(nuxtApp.$client).markAsRead(
-      workspaceId,
-      notificationId
-    )
-    return data
+    try {
+      const { data } = await notificationService(nuxtApp.$client).markAsRead(
+        workspaceId,
+        notificationId
+      )
+      return data
+    } catch {
+      throw createError({
+        statusCode: 404,
+        message: 'Notification not found.',
+      })
+    }
   }
 )
 
 if (loadError.value || !notification.value) {
-  throw createError({
-    statusCode: 404,
-    statusMessage: 'Notification not found.',
-  })
+  throw loadError.value
 }
 
 const notificationType = nuxtApp.$registry.get(
@@ -39,7 +43,7 @@ const redirectParams = notificationType.getRoute(notification.value.data)
 if (!redirectParams) {
   throw createError({
     statusCode: 404,
-    statusMessage: 'Notification has no route.',
+    message: 'Notification has no route.',
   })
 }
 
diff --git a/web-frontend/modules/core/pages/settings.vue b/web-frontend/modules/core/pages/settings.vue
@@ -42,7 +42,7 @@ const store = nuxtApp.$store
 const { $i18n } = nuxtApp
 
 /* asyncData → useAsyncData */
-const { data: workspace } = await useAsyncData('workspace', async () => {
+const { data: workspace, error } = await useAsyncData('workspace', async () => {
   try {
     return await store.dispatch(
       'workspace/selectById',
@@ -53,6 +53,10 @@ const { data: workspace } = await useAsyncData('workspace', async () => {
   }
 })
 
+if (error.value) {
+  throw error.value
+}
+
 /* Registry access */
 const registry = nuxtApp.$registry
 
diff --git a/web-frontend/modules/core/pages/workspace.vue b/web-frontend/modules/core/pages/workspace.vue
@@ -320,7 +320,7 @@ const {
     } catch (e) {
       throw createError({
         statusCode: 404,
-        statusMessage: 'Workspace not found.',
+        message: 'Workspace not found.',
       })
     }
 
@@ -330,12 +330,17 @@ const {
     } catch {
       throw createError({
         statusCode: 400,
-        statusMessage: 'Error loading dashboard.',
+        message: 'Error loading dashboard.',
+        fatal: true,
       })
     }
   }
 )
 
+if (error.value) {
+  throw error.value
+}
+
 /**
  * Hydrate local refs from the async data.
  * Keeps your existing `selectedWorkspace` and `workspaceComponentArguments`
diff --git a/web-frontend/modules/core/plugins/errorHandler.js b/web-frontend/modules/core/plugins/errorHandler.js
@@ -0,0 +1,14 @@
+import { showError } from '#imports'
+
+export default defineNuxtPlugin((nuxtApp) => {
+  const defaultHandler = nuxtApp.vueApp.config.errorHandler
+
+  nuxtApp.vueApp.config.errorHandler = (error, instance, info) => {
+    if (error.fatal === false) {
+      showError(error)
+      return false
+    } else {
+      return defaultHandler(error, instance, info)
+    }
+  }
+})
diff --git a/web-frontend/modules/core/utils/sentryFakeTransport.js b/web-frontend/modules/core/utils/sentryFakeTransport.js
@@ -0,0 +1,5 @@
+import { createTransport } from '@sentry/core'
+
+export function makeFakeTransport(options) {
+  return createTransport(options, async () => ({ statusCode: 200 }))
+}
diff --git a/web-frontend/modules/dashboard/middleware/dashboardLoading.js b/web-frontend/modules/dashboard/middleware/dashboardLoading.js
@@ -32,7 +32,6 @@ export default defineNuxtRouteMiddleware(async (to, from) => {
       throw createError({
         statusCode: 404,
         message: 'Dashboard not found.',
-        fatal: false,
       })
     }
   }
diff --git a/web-frontend/modules/database/middleware/selectWorkspaceDatabaseTable.js b/web-frontend/modules/database/middleware/selectWorkspaceDatabaseTable.js
@@ -25,7 +25,6 @@ export default defineNuxtRouteMiddleware(async (to, from) => {
     throw createError({
       statusCode: e.response?.status || 404,
       message: normalizeError(e).message,
-      fatal: false,
     })
   }
 
diff --git a/web-frontend/modules/database/pages/form.vue b/web-frontend/modules/database/pages/form.vue
@@ -184,11 +184,7 @@ const { data, error } = await useAsyncData(
 )
 
 if (error.value) {
-  if (error.value.statusCode === 404) {
-    showError(error.value)
-  } else {
-    throw error.value
-  }
+  throw error.value
 }
 
 if (data.value?.redirect) {
diff --git a/web-frontend/modules/database/pages/publicView.vue b/web-frontend/modules/database/pages/publicView.vue
@@ -132,18 +132,15 @@ const { data, error } = await useAsyncData(
         throw createError({
           statusCode: 500,
           message: e.message || 'Error loading view.',
+          fatal: true,
         })
       }
     }
   }
 )
 
 if (error.value) {
-  if (error.value.statusCode === 404) {
-    showError(error.value)
-  } else {
-    throw error.value
-  }
+  throw error.value
 }
 
 if (data.value?.redirect) {
diff --git a/web-frontend/sentry.client.config.ts b/web-frontend/sentry.client.config.ts
@@ -1,9 +1,14 @@
 import { useRuntimeConfig, useAppConfig, useRouter } from '#imports'
+import { makeFakeTransport } from './modules/core/utils/sentryFakeTransport'
 import * as Sentry from '@sentry/nuxt'
 
 const config = useRuntimeConfig()
 const appConfig = useAppConfig()
-const dsn = config.public.sentryDsn
+const dsn =
+  config.public.sentryDsn === 'fake'
+    ? 'https://fake@localhost/1'
+    : config.public.sentryDsn
+const isDev = import.meta.dev && config.public.sentryDsn === 'fake'
 
 if (dsn && dsn !== '') {
   const defaultConfig = {
@@ -22,6 +27,17 @@ if (dsn && dsn !== '') {
     tracesSampleRate: 1.0,
     replaysSessionSampleRate: 0,
     replaysOnErrorSampleRate: 1.0,
+    ...(isDev ? { transport: makeFakeTransport } : {}),
+    beforeSend(event, hint) {
+      const err = hint?.originalException
+      if (err?.fatal === false) return null
+      if (isDev) {
+        console.error('[Sentry captured error]', `${err}`)
+        return null
+      } else {
+        return event
+      }
+    },
   }
 
   // Merge with user-provided configuration from app config
diff --git a/web-frontend/sentry.server.config.ts b/web-frontend/sentry.server.config.ts

Original file line number	Diff line number	Diff line change
`@@ -108,7 +108,7 @@ const automationApplicationType = $registry.get(`
`108`	`108`	`AutomationApplicationType.getType()`
`109`	`109`	`)`
`110`	`110`
`111`		`-const { data: pageData } = await useAsyncData(`
	`111`	`+const { data: pageData, error } = await useAsyncData(`
`112`	`112`	() => `automation-workflow-${automationId.value}-${workflowId.value}`,
`113`	`113`	`async () => {`
`114`	`114`	`try {`
`@@ -151,6 +151,10 @@ const { data: pageData } = await useAsyncData(`
`151`	`151`	`}`
`152`	`152`	`)`
`153`	`153`
	`154`	`+if (error.value) {`
	`155`	`+ throw error.value`
	`156`	`+}`
	`157`	`+`
`154`	`158`	`// Computed properties from async data`
`155`	`159`	`const automation = computed(() => pageData.value?.automation ?? null)`
`156`	`160`	`const workspace = computed(() => pageData.value?.workspace ?? null)`
Original file line number	Diff line number	Diff line change
`@@ -25,7 +25,6 @@ export default defineNuxtRouteMiddleware(async (to, from) => {`
`25`	`25`	`throw createError({`
`26`	`26`	`statusCode: 404,`
`27`	`27`	`message: $i18n.t('pageEditor.pageNotFound'),`
`28`		`- fatal: false,`
`29`	`28`	`})`
`30`	`29`	`}`
`31`	`30`	`})`
Original file line number	Diff line number	Diff line change
`@@ -104,12 +104,7 @@ const {`
`104`	`104`	`)`
`105`	`105`
`106`	`106`	`if (pageError.value) {`
`107`		`- // If we have an error we want to display it.`
`108`		`- if (pageError.value.statusCode === 404) {`
`109`		`- showError(pageError.value)`
`110`		`- } else {`
`111`		`- throw pageError.value`
`112`		`- }`
	`107`	`+ throw pageError.value`
`113`	`108`	`}`
`114`	`109`
`115`	`110`	`const workspace = computed(() => pageData.value.workspace)`
Original file line number	Diff line number	Diff line change
`@@ -35,6 +35,7 @@ export default defineNuxtRouteMiddleware(() => {`
`35`	`35`	`hideBackButton: true,`
`36`	`36`	`message: translate('urlCheck.invalidUrlEnvVarTitle', { name }),`
`37`	`37`	`content: translate('urlCheck.invalidUrlEnvVarDescription', { name }),`
	`38`	`+ fatal: true,`
`38`	`39`	`})`
`39`	`40`	`}`
`40`	`41`	`}`
Original file line number	Diff line number	Diff line change
`@@ -112,6 +112,7 @@ export default defineNuxtModule({`
`112`	`112`	`)`
`113`	`113`
`114`	`114`	`addPlugin(resolve('plugins/store.js'))`
	`115`	`+ addPlugin(resolve('plugins/errorHandler.js'))`
`115`	`116`	`addPlugin(resolve('plugins/filters.js'))`
`116`	`117`	`addPlugin(resolve('plugins/vuexState.js'))`
`117`	`118`	`addPlugin(resolve('plugin.js'))`