Skip to content

Commit 2a6ffb3

Browse files
authored
Ensure that our changelog links for github and gitlab go to the correct issue pages. The gitlab URI structure has a hyphen in it. (baserow#4869)
1 parent 348302b commit 2a6ffb3

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

changelog/src/changelog_entry.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -44,8 +44,10 @@ def get_markdown_string(
4444
string = f"* {message}"
4545

4646
if issue_number is not None:
47-
url_prefix = GITLAB_URL if issue_origin == "gitlab" else GITHUB_URL
48-
string += f" [#{issue_number}]({url_prefix}/-/issues/{issue_number})"
47+
if issue_origin == "github":
48+
string += f" [#{issue_number}]({GITHUB_URL}/issues/{issue_number})"
49+
elif issue_origin == "gitlab":
50+
string += f" [#{issue_number}]({GITLAB_URL}/-/issues/{issue_number})"
4951

5052
return string
5153

0 commit comments

Comments
 (0)