fix(api-service,dashboard): resolve step id undefined crash and variable editor range error (novuhq#10344)

Co-authored-by: Cursor Agent <cursoragent@cursor.com>
Co-authored-by: Dima Grossman <dima@grossman.io>

Author: 3 people

apps/api/src/app/environments-v1/usecases/construct-framework-workflow/construct-framework-workflow.usecase.ts

@@ -205,9 +205,9 @@ export class ConstructFrameworkWorkflow {
     }
 
     const stepType = stepTemplate.type;
-    const { stepId } = staticStep;
+    const stepId = staticStep.stepId || staticStep._templateId;
     if (!stepId) {
-      throw new InternalServerErrorException(`Step id not found for step ${staticStep.stepId}`);
+      throw new InternalServerErrorException(`Step id not found for step ${staticStep._id}`);
     }
     const stepControls = stepTemplate.controls;
 

apps/dashboard/src/hooks/use-variables.ts

@@ -36,25 +36,27 @@ export function useVariables(viewRef: React.RefObject<EditorView | null>, onChan
         isUpdatingRef.current = true;
         const { from, to } = selectedVariable;
         const view = viewRef.current;
+        const docLength = view.state.doc.length;
+
+        if (from > docLength) return;
+
         const parsedVariable = parseVariable(newValue);
         let newVariableText = parsedVariable?.liquidVariable ?? '';
 
         if (!parsedVariable?.name) {
-          // if the value is empty, remove the variable
           newVariableText = '';
         }
 
-        // Calculate the actual end position including closing brackets
         const currentContent = view.state.doc.toString();
         const contentAfterFrom = currentContent.slice(from);
 
-        // If there are no next opening brackets, or they come after our closing brackets
         const closingBracketsPos = contentAfterFrom.indexOf('}}');
         const actualEnd = closingBracketsPos > -1 ? from + closingBracketsPos + 2 : to;
+        const clampedEnd = Math.min(actualEnd, docLength);
 
         const changes = {
           from,
-          to: actualEnd,
+          to: clampedEnd,
           insert: newVariableText,
         };
 
@@ -65,8 +67,7 @@ export function useVariables(viewRef: React.RefObject<EditorView | null>, onChan
 
         onChangeRef.current(view.state.doc.toString());
 
-        // Update the selected variable with new bounds
-        setSelectedVariable({ value: newValue, from, to: actualEnd });
+        setSelectedVariable({ value: newValue, from, to: clampedEnd });
       } finally {
         isUpdatingRef.current = false;
       }