refactor: wip

Author: BioPhoton

packages/utils/mocks/omit-trace-json.ts

@@ -30,21 +30,6 @@ const parseJsonl = (input: string): TraceEvent[] =>
     .filter(Boolean)
     .map(line => JSON.parse(line) as TraceEvent);
 
-/**
- * Normalizes encoded events and preserves encoded format.
- * Similar to normalizeEncoded but works directly on encoded events from JSONL.
- */
-const normalizeEncodedJsonl = (
-  events: TraceEvent[],
-  options?: { baseTimestampUs: number },
-): TraceEvent[] => {
-  // Decode temporarily to normalize (normalizeAndFormatEvents needs decoded format)
-  const decodedEvents = events.map(decodeEvent);
-  const normalizedDecoded = normalizeAndFormatEvents(decodedEvents, options);
-  // Re-encode to preserve serialized format
-  return normalizedDecoded.map(encodeEvent);
-};
-
 /**
  * Loads and normalizes trace events from a JSONL file.
  * Parses the file, decodes all events, normalizes them for deterministic testing,

packages/utils/src/lib/process-id.ts

@@ -105,6 +105,7 @@ export function getUniqueInstanceIdAndUpdate(
   getCount: () => number,
   setCount: (value: number) => void,
 ): string {
+  // eslint-disable-next-line functional/no-let
   let value = getCount();
   const counter: Counter = {
     next() {

packages/utils/src/lib/profiler/profiler-node.int.test.ts

@@ -185,7 +185,7 @@ describe('NodeJS Profiler Integration', () => {
     performance.clearMeasures();
     vi.stubEnv(PROFILER_ENABLED_ENV_VAR, undefined!);
     vi.stubEnv(PROFILER_DEBUG_ENV_VAR, undefined!);
-    // eslint-disable-next-line functional/immutable-data
+    // eslint-disable-next-line functional/immutable-data, @typescript-eslint/no-dynamic-delete
     delete process.env[PROFILER_SHARDER_ID_ENV_VAR];
   });
 
@@ -199,7 +199,7 @@ describe('NodeJS Profiler Integration', () => {
 
     vi.stubEnv(PROFILER_ENABLED_ENV_VAR, undefined!);
     vi.stubEnv(PROFILER_DEBUG_ENV_VAR, undefined!);
-    // eslint-disable-next-line functional/immutable-data
+    // eslint-disable-next-line functional/immutable-data, @typescript-eslint/no-dynamic-delete
     delete process.env[PROFILER_SHARDER_ID_ENV_VAR];
   });
 

packages/utils/src/lib/profiler/profiler-node.ts

@@ -7,9 +7,7 @@ import {
 import { objectToEntries } from '../transform.js';
 import { errorToMarkerPayload } from '../user-timing-extensibility-api-utils.js';
 import type {
-  ActionColorPayload,
   ActionTrackEntryPayload,
-  DevToolsActionColor,
   MarkerPayload,
 } from '../user-timing-extensibility-api.type.js';
 import { ShardedWal } from '../wal-sharded.js';

packages/utils/src/lib/profiler/profiler-node.unit.test.ts

@@ -1,4 +1,3 @@
-import path from 'node:path';
 import { performance } from 'node:perf_hooks';
 import { beforeEach, describe, expect, it, vi } from 'vitest';
 import { awaitObserverCallbackAndFlush } from '@code-pushup/test-utils';
@@ -40,7 +39,7 @@ const resetEnv = () => {
   delete process.env.DEBUG;
   // eslint-disable-next-line functional/immutable-data
   delete process.env.CP_PROFILING;
-  // eslint-disable-next-line functional/immutable-data
+  // eslint-disable-next-line functional/immutable-data, @typescript-eslint/no-dynamic-delete
   delete process.env[PROFILER_SHARDER_ID_ENV_VAR];
 };
 
@@ -197,6 +196,7 @@ describe('NodejsProfiler', () => {
       expect(profiler.stats.isSubscribed).toBe(true);
     });
 
+    // eslint-disable-next-line vitest/expect-expect
     it('should initialize with sink closed when enabled is false', () => {
       const profiler = createProfiler({
         measureName: 'init-disabled',
@@ -300,6 +300,7 @@ describe('NodejsProfiler', () => {
       expect(profiler.state).toBe('closed');
     });
 
+    // eslint-disable-next-line vitest/expect-expect
     it('should maintain state invariant: running ⇒ sink open + observer subscribed', () => {
       const profiler = createProfiler({
         measureName: 'state-invariant',
@@ -584,6 +585,7 @@ describe('NodejsProfiler', () => {
       expect(debugProfiler.debug).toBe(true);
     });
 
+    // eslint-disable-next-line vitest/expect-expect
     it('should create transition marker when debug is enabled and transitioning to running', () => {
       // eslint-disable-next-line functional/immutable-data
       process.env.DEBUG = 'true';
@@ -598,19 +600,7 @@ describe('NodejsProfiler', () => {
       expectTransitionMarker('debug:idle->running');
     });
 
-    it('should not create transition marker when transitioning from running to idle (profiler disabled)', () => {
-      // eslint-disable-next-line functional/immutable-data
-      process.env.DEBUG = 'true';
-      const profiler = createProfiler({
-        measureName: 'debug-no-transition-marker',
-      });
-
-      performance.clearMarks();
-      profiler.setEnabled(false);
-
-      expectNoTransitionMarker('running->idle');
-    });
-
+    // eslint-disable-next-line vitest/expect-expect
     it('does not emit transition markers unless debug is enabled', () => {
       const profiler = createProfiler('no-transition-markers');
 

packages/utils/src/lib/profiler/profiler.int.test.ts

@@ -1,5 +1,4 @@
 import type { ActionTrackConfigs } from '../user-timing-extensibility-api-utils.js';
-import { PROFILER_ENABLED_ENV_VAR } from './constants.js';
 import { Profiler, type ProfilerOptions } from './profiler.js';
 
 describe('Profiler Integration', () => {
@@ -34,9 +33,6 @@ describe('Profiler Integration', () => {
         ),
       ),
     ).toBe(499_500);
-
-    const marks = performance.getEntriesByType('mark');
-    const measures = performance.getEntriesByType('measure');
   });
 
   it('should create complete performance timeline for async operation', async () => {

packages/utils/src/lib/profiler/profiler.ts

@@ -13,7 +13,6 @@ import {
 } from '../user-timing-extensibility-api-utils.js';
 import type {
   ActionTrackEntryPayload,
-  DevToolsActionColor,
   DevToolsColor,
   EntryMeta,
 } from '../user-timing-extensibility-api.type.js';

packages/utils/src/lib/profiler/trace-file-utils.ts

@@ -130,7 +130,7 @@ export const getInstantEventTracingStartedInBrowser = (
           },
         ],
         persistentIds: true,
-      } as Record<string, unknown>,
+      } satisfies Record<string, unknown>,
     },
   };
 };

packages/utils/src/lib/wal-sharded.int.test.ts

@@ -3,7 +3,7 @@ import path from 'node:path';
 import { afterEach, beforeEach, describe, expect, it } from 'vitest';
 import { PROFILER_SHARDER_ID_ENV_VAR } from './profiler/constants.js';
 import { ShardedWal } from './wal-sharded.js';
-import { createTolerantCodec, stringCodec } from './wal.js';
+import { createTolerantCodec } from './wal.js';
 
 describe('ShardedWal Integration', () => {
   const testDir = path.join(

packages/utils/src/lib/wal-sharded.ts

@@ -5,7 +5,6 @@ import { threadId } from 'node:worker_threads';
 import {
   type Counter,
   getUniqueInstanceId,
-  getUniqueProcessThreadId,
   getUniqueTimeId,
 } from './process-id.js';
 import {
@@ -131,6 +130,7 @@ export class ShardedWal<T extends object = object> {
       opt;
 
     // Determine groupId: use provided, then env var, or generate
+    // eslint-disable-next-line functional/no-let
     let resolvedGroupId: string;
     if (groupId) {
       // User explicitly provided groupId - use it