refactor: wip

Author: BioPhoton

packages/utils/mocks/omit-trace-json.unit.test.ts

@@ -78,7 +78,7 @@ describe('normalizeAndFormatEvents', () => {
         ph: 'i',
         name: 'plugin-eslint:run-eslint:start',
         pid: 10_001,
-        tid: 1,
+        tid: 0,
         ts: 1_700_000_005_000_000,
         args: {
           data: {
@@ -119,7 +119,7 @@ describe('normalizeAndFormatEvents', () => {
         ph: 'b',
         name: 'plugin-eslint:run-eslint',
         pid: 10_001,
-        tid: 1,
+        tid: 0,
         ts: 1_700_000_005_000_000,
         id2: { local: '0x1' },
         args: {
@@ -167,16 +167,16 @@ describe('normalizeAndFormatEvents', () => {
         ph: 'i',
         name: 'TracingStartedInBrowser',
         pid: 10_001,
-        tid: 1,
+        tid: 0,
         ts: 1_700_000_005_000_000,
         args: {
           data: {
-            frameTreeNodeId: 1_000_101, // 10001 + '0' + 1
+            frameTreeNodeId: 805_700,
             frames: [
               {
-                frame: 'FRAME0P10001T1',
+                frame: 'FRAME0P8057T0',
                 isInPrimaryMainFrame: true,
-                processId: 10_001,
+                processId: 8057,
                 url: 'trace.json',
               },
             ],
@@ -270,7 +270,7 @@ describe('normalizeAndFormatEvents', () => {
         ph: 'i',
         name: 'test',
         pid: 10_001,
-        tid: 1,
+        tid: 0,
         ts: 1_700_000_005_000_000,
         args: {
           detail: { type: 'mark' },
@@ -309,13 +309,13 @@ describe('loadAndOmitTraceJsonl', () => {
     await expect(loadAndOmitTraceJsonl('trace.jsonl')).resolves.toStrictEqual([
       {
         pid: 10_001,
-        tid: 1,
+        tid: 0,
         ts: 1_700_000_005_000_000,
         args: { data: { detail: { devtools: { dataType: 'track-entry' } } } },
       },
       {
         pid: 10_001,
-        tid: 1,
+        tid: 0,
         ts: 1_700_000_005_000_100,
         args: { detail: { devtools: { dataType: 'track-entry' } } },
       },
@@ -353,7 +353,7 @@ describe('loadAndOmitTraceJson', () => {
 
     await expect(loadAndOmitTraceJson('trace.json')).resolves.toStrictEqual({
       traceEvents: [
-        { pid: 10_001, tid: 1, ts: 1_700_000_005_000_000, name: 'test' },
+        { pid: 10_001, tid: 0, ts: 1_700_000_005_000_000, name: 'test' },
       ],
     });
   });

packages/utils/src/lib/performance-observer.unit.test.ts

@@ -69,6 +69,7 @@ describe('PerformanceObserverSink', () => {
       sink,
       encodePerfEntry,
       flushThreshold: 1,
+      debug: false,
     };
 
     performance.clearMarks();
@@ -86,6 +87,7 @@ describe('PerformanceObserverSink', () => {
         new PerformanceObserverSink({
           sink,
           encodePerfEntry,
+          debug: false,
         }),
     ).not.toThrow();
     expect(MockPerformanceObserver.instances).toHaveLength(0);
@@ -98,6 +100,7 @@ describe('PerformanceObserverSink', () => {
           ...options,
           captureBufferedEntries: true,
           flushThreshold: 10,
+          debug: false,
         }),
     ).not.toThrow();
     expect(MockPerformanceObserver.instances).toHaveLength(0);
@@ -272,6 +275,7 @@ describe('PerformanceObserverSink', () => {
     const observer = new PerformanceObserverSink({
       sink,
       encodePerfEntry,
+      debug: false,
     });
 
     expect(() => observer.flush()).not.toThrow();
@@ -284,6 +288,7 @@ describe('PerformanceObserverSink', () => {
       sink,
       encodePerfEntry,
       flushThreshold: 10,
+      debug: false,
     });
     sink.open();
     observer.subscribe();
@@ -324,6 +329,7 @@ describe('PerformanceObserverSink', () => {
       sink,
       encodePerfEntry: failingEncode,
       flushThreshold: 10,
+      debug: false,
     });
 
     observer.subscribe();
@@ -337,35 +343,8 @@ describe('PerformanceObserverSink', () => {
     expect(stats.queued).toBe(0);
   });
 
-  describe('debug mode with env var', () => {
-    const originalEnv = process.env.CP_PROFILER_DEBUG;
-
-    beforeEach(() => {
-      // Restore original env before each test
-      if (originalEnv === undefined) {
-        // eslint-disable-next-line functional/immutable-data
-        delete process.env.DEBUG;
-      } else {
-        // eslint-disable-next-line functional/immutable-data
-        process.env.DEBUG = originalEnv;
-      }
-    });
-
-    afterEach(() => {
-      // Restore original env after each test
-      if (originalEnv === undefined) {
-        // eslint-disable-next-line functional/immutable-data
-        delete process.env.DEBUG;
-      } else {
-        // eslint-disable-next-line functional/immutable-data
-        process.env.DEBUG = originalEnv;
-      }
-    });
-
-    it('creates performance mark when encode fails and debug mode is enabled via env var', () => {
-      // eslint-disable-next-line functional/immutable-data
-      process.env.DEBUG = 'true';
-
+  describe('debug mode', () => {
+    it('creates performance mark when encode fails and debug mode is enabled', () => {
       const failingEncode = vi.fn(() => {
         throw new Error('EncodeError');
       });
@@ -374,6 +353,7 @@ describe('PerformanceObserverSink', () => {
         sink,
         encodePerfEntry: failingEncode,
         flushThreshold: 10,
+        debug: true,
       });
 
       observer.subscribe();
@@ -394,9 +374,6 @@ describe('PerformanceObserverSink', () => {
     });
 
     it('does not create performance mark when encode fails and debug mode is disabled', () => {
-      // eslint-disable-next-line functional/immutable-data
-      delete process.env.DEBUG;
-
       const failingEncode = vi.fn(() => {
         throw new Error('EncodeError');
       });
@@ -405,6 +382,7 @@ describe('PerformanceObserverSink', () => {
         sink,
         encodePerfEntry: failingEncode,
         flushThreshold: 10,
+        debug: false,
       });
 
       performance.clearMarks();
@@ -425,9 +403,6 @@ describe('PerformanceObserverSink', () => {
     });
 
     it('handles encode errors for unnamed entries correctly', () => {
-      // eslint-disable-next-line functional/immutable-data
-      process.env.DEBUG = 'true';
-
       const failingEncode = vi.fn(() => {
         throw new Error('EncodeError');
       });
@@ -436,6 +411,7 @@ describe('PerformanceObserverSink', () => {
         sink,
         encodePerfEntry: failingEncode,
         flushThreshold: 10,
+        debug: true,
       });
 
       observer.subscribe();
@@ -453,9 +429,6 @@ describe('PerformanceObserverSink', () => {
     });
 
     it('handles non-Error objects thrown from encode function', () => {
-      // eslint-disable-next-line functional/immutable-data
-      process.env.DEBUG = 'true';
-
       const failingEncode = vi.fn(() => {
         throw 'String error';
       });
@@ -464,6 +437,7 @@ describe('PerformanceObserverSink', () => {
         sink,
         encodePerfEntry: failingEncode,
         flushThreshold: 10,
+        debug: true,
       });
 
       observer.subscribe();
@@ -498,6 +472,7 @@ describe('PerformanceObserverSink', () => {
       sink,
       encodePerfEntry: failingEncode,
       flushThreshold: 10,
+      debug: false,
     });
 
     observer.subscribe();
@@ -527,6 +502,7 @@ describe('PerformanceObserverSink', () => {
       sink: failingSink as any,
       encodePerfEntry,
       flushThreshold: 10,
+      debug: false,
     });
 
     observer.subscribe();
@@ -553,6 +529,7 @@ describe('PerformanceObserverSink', () => {
       encodePerfEntry,
       maxQueueSize: 20,
       flushThreshold: 10,
+      debug: false,
     });
 
     expect(observer.getStats()).toStrictEqual(
@@ -568,6 +545,7 @@ describe('PerformanceObserverSink', () => {
       sink,
       encodePerfEntry,
       flushThreshold: 10,
+      debug: false,
     });
 
     observer.subscribe();
@@ -589,6 +567,7 @@ describe('PerformanceObserverSink', () => {
       encodePerfEntry,
       maxQueueSize: smallQueueSize,
       flushThreshold: smallQueueSize,
+      debug: false,
     });
 
     const flushSpy = vi.spyOn(observer, 'flush').mockImplementation(() => {});
@@ -617,6 +596,7 @@ describe('PerformanceObserverSink', () => {
       sink,
       encodePerfEntry,
       flushThreshold: 2,
+      debug: false,
     });
 
     observer.subscribe();
@@ -653,6 +633,7 @@ describe('PerformanceObserverSink', () => {
       encodePerfEntry: (entry: PerformanceEntry) => [
         `${entry.name}:${entry.duration}`,
       ],
+      debug: false,
     });
 
     observer.subscribe();
@@ -671,6 +652,7 @@ describe('PerformanceObserverSink', () => {
       sink,
       encodePerfEntry,
       flushThreshold: 10,
+      debug: false,
     });
 
     expect(observer.getStats().addedSinceLastFlush).toBe(0);
@@ -706,52 +688,29 @@ describe('PerformanceObserverSink', () => {
   });
 
   describe('debug getter', () => {
-    const originalEnv = process.env.CP_PROFILER_DEBUG;
-
-    beforeEach(() => {
-      // eslint-disable-next-line functional/immutable-data
-      delete process.env.DEBUG;
-    });
-
-    afterEach(() => {
-      if (originalEnv === undefined) {
-        // eslint-disable-next-line functional/immutable-data
-        delete process.env.DEBUG;
-      } else {
-        // eslint-disable-next-line functional/immutable-data
-        process.env.DEBUG = originalEnv;
-      }
-    });
-
-    it('returns false when debug env var is not set', () => {
-      const observer = new PerformanceObserverSink(options);
+    it('returns false when debug is disabled', () => {
+      const observer = new PerformanceObserverSink({
+        ...options,
+        debug: false,
+      });
 
       expect(observer.debug).toBeFalse();
     });
 
-    it('returns true when debug env var is set to "true"', () => {
-      // eslint-disable-next-line functional/immutable-data
-      process.env.DEBUG = 'true';
-
-      const observer = new PerformanceObserverSink(options);
+    it('returns true when debug is enabled', () => {
+      const observer = new PerformanceObserverSink({
+        ...options,
+        debug: true,
+      });
 
       expect(observer.debug).toBeTrue();
     });
 
-    it('returns false when debug env var is set to a value other than "true"', () => {
-      // eslint-disable-next-line functional/immutable-data
-      process.env.DEBUG = 'false';
-
-      const observer = new PerformanceObserverSink(options);
-
-      expect(observer.debug).toBeFalse();
-    });
-
-    it('returns false when debug env var is set to empty string', () => {
-      // eslint-disable-next-line functional/immutable-data
-      process.env.DEBUG = '';
-
-      const observer = new PerformanceObserverSink(options);
+    it('returns false when debug is disabled via options', () => {
+      const observer = new PerformanceObserverSink({
+        ...options,
+        debug: false,
+      });
 
       expect(observer.debug).toBeFalse();
     });

packages/utils/src/lib/profiler/__snapshots__/debugMode-test.json

@@ -1 +1 @@
-{"traceEvents":[{"cat":"devtools.timeline","ph":"i","name":"TracingStartedInBrowser","pid":10001,"tid":1,"ts":1700000005000000,"args":{"data":{"frameTreeNodeId":1000101,"frames":[{"frame":"FRAME0P10001T1","isInPrimaryMainFrame":true,"isOutermostMainFrame":true,"name":"","processId":10001,"url":"generated-trace"}],"persistentIds":true}}},{"cat":"devtools.timeline","pid":10001,"tid":1,"ts":1700000005000000,"ph":"X","name":"[trace padding start]","dur":20000,"args":{}},{"cat":"blink.user_timing","pid":10001,"tid":1,"ts":1700000005000100,"name":"debug:transition","ph":"I","args":{"data":{"detail":"{\"devtools\":{\"dataType\":\"marker\",\"color\":\"warning\",\"tooltipText\":\"Profiler transition: idle -> running\",\"properties\":[[\"From\",\"idle\"],[\"To\",\"running\"],[\"Reason\",\"enable\"],[\"prefix\",\"\"],[\"enabled\",true],[\"debug\",true],[\"tracks\",null],[\"trackDefaults\",{\"track\":\"int-test-track\",\"dataType\":\"track-entry\"}],[\"profilerState\",\"idle\"],[\"sharderState\",\"active\"],[\"groupId\",\"debugMode-test\"],[\"shardCount\",0],[\"isFinalized\",false],[\"isCleaned\",false],[\"finalFilePath\",\"/Users/michael_hladky/WebstormProjects/cli/tmp/int/utils/debugMode-test/trace.debugMode-test.json\"],[\"shardFileCount\",0],[\"shardFiles\",[]],[\"isCoordinator\",true],[\"shardOpen\",false],[\"shardPath\",\"/Users/michael_hladky/WebstormProjects/cli/tmp/int/utils/debugMode-test/trace.20260201-160235-016.99588.1.7.jsonl\"],[\"isSubscribed\",false],[\"queued\",0],[\"dropped\",0],[\"written\",0],[\"maxQueueSize\",10000],[\"flushThreshold\",20],[\"addedSinceLastFlush\",0],[\"buffered\",true]]}}"}}},{"cat":"blink.user_timing","pid":10001,"tid":1,"ts":1700000005000200,"name":"PID:99588: Enable profiler","ph":"I","args":{"data":{"detail":"{\"devtools\":{\"dataType\":\"marker\",\"tooltipText\":\"set enable to true\"}}"}}},{"cat":"devtools.timeline","pid":10001,"tid":1,"ts":1700000005000300,"ph":"X","name":"[trace padding end]","dur":20000,"args":{}}],"metadata":{"source":"DevTools","startTime":"2026-01-28T14:29:27.995Z","hardwareConcurrency":1,"dataOrigin":"TraceEvents"}}
+{"traceEvents":[{"cat":"devtools.timeline","ph":"i","name":"TracingStartedInBrowser","pid":10001,"tid":1,"ts":1700000005000000,"args":{"data":{"frameTreeNodeId":1000101,"frames":[{"frame":"FRAME0P10001T1","isInPrimaryMainFrame":true,"isOutermostMainFrame":true,"name":"","processId":10001,"url":"generated-trace"}],"persistentIds":true}}},{"cat":"devtools.timeline","pid":10001,"tid":1,"ts":1700000005000000,"ph":"X","name":"[trace padding start]","dur":20000,"args":{}},{"cat":"blink.user_timing","pid":10001,"tid":1,"ts":1700000005000100,"name":"Enable profiler","ph":"I","args":{"data":{"detail":"{\"devtools\":{\"dataType\":\"marker\",\"tooltipText\":\"set enable to true\"}}"}}},{"cat":"devtools.timeline","pid":10001,"tid":1,"ts":1700000005000200,"ph":"X","name":"[trace padding end]","dur":20000,"args":{}}],"metadata":{"source":"DevTools","startTime":"2026-01-28T14:29:27.995Z","hardwareConcurrency":1,"dataOrigin":"TraceEvents"}}

packages/utils/src/lib/profiler/__snapshots__/entries-write-to-shard.json

@@ -1 +1 @@
-{"traceEvents":[{"cat":"devtools.timeline","ph":"i","name":"TracingStartedInBrowser","pid":10001,"tid":1,"ts":1700000005000000,"args":{"data":{"frameTreeNodeId":1000101,"frames":[{"frame":"FRAME0P10001T1","isInPrimaryMainFrame":true,"isOutermostMainFrame":true,"name":"","processId":10001,"url":"generated-trace"}],"persistentIds":true}}},{"cat":"devtools.timeline","pid":10001,"tid":1,"ts":1700000005000000,"ph":"X","name":"[trace padding start]","dur":20000,"args":{}},{"cat":"blink.user_timing","pid":10001,"tid":1,"ts":1700000005000100,"name":"PID:99588: Enable profiler","ph":"I","args":{"data":{"detail":"{\"devtools\":{\"dataType\":\"marker\",\"tooltipText\":\"set enable to true\"}}"}}},{"cat":"blink.user_timing","pid":10001,"tid":1,"ts":1700000005000200,"name":"write-j-jl:PID:99588 sync-measure:start","ph":"I","args":{"data":{"detail":"{\"devtools\":{\"track\":\"int-test-track\",\"dataType\":\"track-entry\"}}"}}},{"cat":"blink.user_timing","pid":10001,"tid":1,"ts":1700000005000300,"name":"write-j-jl:PID:99588 sync-measure","ph":"b","id2":{"local":"0x1"},"args":{"detail":"{\"devtools\":{\"track\":\"int-test-track\",\"dataType\":\"track-entry\"}}"}},{"cat":"blink.user_timing","pid":10001,"tid":1,"ts":1700000005000400,"name":"write-j-jl:PID:99588 sync-measure","ph":"e","id2":{"local":"0x1"},"args":{"detail":"{\"devtools\":{\"track\":\"int-test-track\",\"dataType\":\"track-entry\"}}"}},{"cat":"blink.user_timing","pid":10001,"tid":1,"ts":1700000005000500,"name":"write-j-jl:PID:99588 sync-measure:end","ph":"I","args":{"data":{"detail":"{\"devtools\":{\"track\":\"int-test-track\",\"dataType\":\"track-entry\"}}"}}},{"cat":"blink.user_timing","pid":10001,"tid":1,"ts":1700000005000600,"name":"write-j-jl:PID:99588 async-measure:start","ph":"I","args":{"data":{"detail":"{\"devtools\":{\"track\":\"int-test-track\",\"dataType\":\"track-entry\"}}"}}},{"cat":"blink.user_timing","pid":10001,"tid":1,"ts":1700000005000700,"name":"write-j-jl:PID:99588 async-measure","ph":"b","id2":{"local":"0x2"},"args":{"detail":"{\"devtools\":{\"track\":\"int-test-track\",\"dataType\":\"track-entry\"}}"}},{"cat":"blink.user_timing","pid":10001,"tid":1,"ts":1700000005000800,"name":"write-j-jl:PID:99588 async-measure","ph":"e","id2":{"local":"0x2"},"args":{"detail":"{\"devtools\":{\"track\":\"int-test-track\",\"dataType\":\"track-entry\"}}"}},{"cat":"blink.user_timing","pid":10001,"tid":1,"ts":1700000005000900,"name":"write-j-jl:PID:99588 async-measure:end","ph":"I","args":{"data":{"detail":"{\"devtools\":{\"track\":\"int-test-track\",\"dataType\":\"track-entry\"}}"}}},{"cat":"blink.user_timing","pid":10001,"tid":1,"ts":1700000005001000,"name":"PID:99588: Disable profiler","ph":"I","args":{"data":{"detail":"{\"devtools\":{\"dataType\":\"marker\",\"tooltipText\":\"set enable to false\"}}"}}},{"cat":"devtools.timeline","pid":10001,"tid":1,"ts":1700000005001100,"ph":"X","name":"[trace padding end]","dur":20000,"args":{}}],"metadata":{"source":"DevTools","startTime":"2026-01-28T14:29:27.995Z","hardwareConcurrency":1,"dataOrigin":"TraceEvents"}}
+{"traceEvents":[{"cat":"devtools.timeline","ph":"i","name":"TracingStartedInBrowser","pid":10001,"tid":1,"ts":1700000005000000,"args":{"data":{"frameTreeNodeId":1000101,"frames":[{"frame":"FRAME0P10001T1","isInPrimaryMainFrame":true,"isOutermostMainFrame":true,"name":"","processId":10001,"url":"generated-trace"}],"persistentIds":true}}},{"cat":"devtools.timeline","pid":10001,"tid":1,"ts":1700000005000000,"ph":"X","name":"[trace padding start]","dur":20000,"args":{}},{"cat":"blink.user_timing","pid":10001,"tid":1,"ts":1700000005000100,"name":"Enable profiler","ph":"I","args":{"data":{"detail":"{\"devtools\":{\"dataType\":\"marker\",\"tooltipText\":\"set enable to true\"}}"}}},{"cat":"blink.user_timing","pid":10001,"tid":1,"ts":1700000005000200,"name":"write-j-jl:sync-measure:start","ph":"I","args":{"data":{"detail":"{\"devtools\":{\"track\":\"int-test-track\",\"dataType\":\"track-entry\"}}"}}},{"cat":"blink.user_timing","pid":10001,"tid":1,"ts":1700000005000300,"name":"write-j-jl:sync-measure","ph":"b","id2":{"local":"0x1"},"args":{"detail":"{\"devtools\":{\"track\":\"int-test-track\",\"dataType\":\"track-entry\"}}"}},{"cat":"blink.user_timing","pid":10001,"tid":1,"ts":1700000005000400,"name":"write-j-jl:sync-measure","ph":"e","id2":{"local":"0x1"},"args":{"detail":"{\"devtools\":{\"track\":\"int-test-track\",\"dataType\":\"track-entry\"}}"}},{"cat":"blink.user_timing","pid":10001,"tid":1,"ts":1700000005000500,"name":"write-j-jl:sync-measure:end","ph":"I","args":{"data":{"detail":"{\"devtools\":{\"track\":\"int-test-track\",\"dataType\":\"track-entry\"}}"}}},{"cat":"blink.user_timing","pid":10001,"tid":1,"ts":1700000005000600,"name":"write-j-jl:async-measure:start","ph":"I","args":{"data":{"detail":"{\"devtools\":{\"track\":\"int-test-track\",\"dataType\":\"track-entry\"}}"}}},{"cat":"blink.user_timing","pid":10001,"tid":1,"ts":1700000005000700,"name":"write-j-jl:async-measure","ph":"b","id2":{"local":"0x2"},"args":{"detail":"{\"devtools\":{\"track\":\"int-test-track\",\"dataType\":\"track-entry\"}}"}},{"cat":"blink.user_timing","pid":10001,"tid":1,"ts":1700000005000800,"name":"write-j-jl:async-measure","ph":"e","id2":{"local":"0x2"},"args":{"detail":"{\"devtools\":{\"track\":\"int-test-track\",\"dataType\":\"track-entry\"}}"}},{"cat":"blink.user_timing","pid":10001,"tid":1,"ts":1700000005000900,"name":"write-j-jl:async-measure:end","ph":"I","args":{"data":{"detail":"{\"devtools\":{\"track\":\"int-test-track\",\"dataType\":\"track-entry\"}}"}}},{"cat":"blink.user_timing","pid":10001,"tid":1,"ts":1700000005001000,"name":"Disable profiler","ph":"I","args":{"data":{"detail":"{\"devtools\":{\"dataType\":\"marker\",\"tooltipText\":\"set enable to false\"}}"}}},{"cat":"devtools.timeline","pid":10001,"tid":1,"ts":1700000005001100,"ph":"X","name":"[trace padding end]","dur":20000,"args":{}}],"metadata":{"source":"DevTools","startTime":"2026-01-28T14:29:27.995Z","hardwareConcurrency":1,"dataOrigin":"TraceEvents"}}