Skip to content

Commit 5757de4

Browse files
committed
Updated "View the project on GitHub" text and added string resources for license information about the icon
1 parent 6d5e772 commit 5757de4

4 files changed

Lines changed: 12 additions & 6 deletions

File tree

app/src/main/java/com/codea1/worktrack/ui/settings/SettingsScreen.kt

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -303,7 +303,7 @@ fun SettingsScreenContent(
303303
.padding(start = 16.dp, end = 16.dp, top = 32.dp)
304304
)
305305
Text(
306-
text = "Privacy Policy",
306+
text = stringResource(R.string.privacy_policy),
307307
style = MaterialTheme.typography.bodySmall,
308308
color = MaterialTheme.colorScheme.primary,
309309
modifier = Modifier
@@ -315,14 +315,14 @@ fun SettingsScreenContent(
315315
Row {
316316
Text(
317317
buildAnnotatedString {
318-
append("The icon of the app is provided under the ")
318+
append(stringResource(R.string.the_icon_of_the_app_is_provided_under_the) + " ")
319319
withLink(
320320
LinkAnnotation.Url(
321321
"https://www.apache.org/licenses/LICENSE-2.0.txt",
322322
TextLinkStyles(SpanStyle(color = MaterialTheme.colorScheme.primary))
323323
)
324324
) {
325-
append("Apache License Version 2.0")
325+
append(stringResource(R.string.apache_license_version_2_0))
326326
}
327327
},
328328
textAlign = TextAlign.Center,

app/src/main/res/values-en/strings.xml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@
6363
<string name="crashlytics_option_title">Send crash reports</string>
6464
<string name="general_settings_section">General settings</string>
6565
<string name="view_the_project_on_github_title">View the project on GitHub</string>
66-
<string name="view_the_project_on_github_description">View the project\'s source code and, if you like, leave a star to support us!</string>
66+
<string name="view_the_project_on_github_description">View the project\'s source code and, if you like, leave a star to support us!\nIf you have found a problem in the app, you can open an Issue or a Pull Request directly on GitHub</string>
6767
<string name="default_work_title">Default work</string>
6868
<string name="default_work_description">Select the default work to be used when creating new recordings</string>
6969
<string name="other_settings_section">Other</string>
@@ -77,4 +77,6 @@
7777
<string name="privacy_policy">Privacy Policy</string>
7878
<string name="crash_reports_onboarding">Data from crash reports is collected by default to help us improve the app. You can change this in the app\'s settings.</string>
7979
<string name="get_started">Get Started</string>
80+
<string name="the_icon_of_the_app_is_provided_under_the">The icon of the app is provided under the</string>
81+
<string name="apache_license_version_2_0">Apache License Version 2.0</string>
8082
</resources>

app/src/main/res/values-it/strings.xml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@
6464
<string name="crashlytics_option_title">Invia rapporti sugli arresti anomali</string>
6565
<string name="general_settings_section">Impostazioni generali</string>
6666
<string name="view_the_project_on_github_title">Visualizza il progetto su GitHub</string>
67-
<string name="view_the_project_on_github_description">Visualizza il codice sorgente del progetto e, se ti va, lascia una stella per supportarci!</string>
67+
<string name="view_the_project_on_github_description">Visualizza il codice sorgente del progetto e, se ti va, lascia una stella per supportarci!\nSe hai trovato un problema nell\'app puoi aprire un Issue o una Pull Request direttamente su GitHub</string>
6868
<string name="default_work_title">Lavoro predefinito</string>
6969
<string name="default_work_description">Seleziona il lavoro predefinito da utilizzare quando vengono create nuove registrazioni</string>
7070
<string name="other_settings_section">Altro</string>
@@ -78,4 +78,6 @@
7878
<string name="privacy_policy">Politica sulla Privacy</string>
7979
<string name="crash_reports_onboarding">I dati dei crash report sono raccolti per impostazione predefinita per aiutarci a migliorare l\'app. È possibile modificare questa opzione nelle impostazioni dell\'app.</string>
8080
<string name="get_started">Inizia</string>
81+
<string name="the_icon_of_the_app_is_provided_under_the">L\'icona dell\'app è fornita sotto la</string>
82+
<string name="apache_license_version_2_0">Licenza Apache Versione 2.0</string>
8183
</resources>

app/src/main/res/values/strings.xml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@
6464
<string name="crashlytics_option_title">Send crash reports</string>
6565
<string name="general_settings_section">General settings</string>
6666
<string name="view_the_project_on_github_title">View the project on GitHub</string>
67-
<string name="view_the_project_on_github_description">View the project\'s source code and, if you like, leave a star to support us!</string>
67+
<string name="view_the_project_on_github_description">View the project\'s source code and, if you like, leave a star to support us!\nIf you have found a problem in the app, you can open an Issue or a Pull Request directly on GitHub</string>
6868
<string name="default_work_title">Default work</string>
6969
<string name="default_work_description">Select the default work to be used when creating new recordings</string>
7070
<string name="other_settings_section">Other</string>
@@ -80,4 +80,6 @@
8080
<string name="privacy_policy">Privacy Policy</string>
8181
<string name="crash_reports_onboarding">Crash reports\' data is collected by default to help us improve the app: you can change it in the app\'s settings.</string>
8282
<string name="get_started">Get Started</string>
83+
<string name="the_icon_of_the_app_is_provided_under_the">The icon of the app is provided under the</string>
84+
<string name="apache_license_version_2_0">Apache License Version 2.0</string>
8385
</resources>

0 commit comments

Comments
 (0)