From 75cc47747681765d2706565488bbd04b30d04e5a Mon Sep 17 00:00:00 2001 From: Ryan Kuo Date: Mon, 1 Jun 2026 15:38:47 -0400 Subject: [PATCH] Remove broken Slack notification workflows These two workflow files had YAML parsing issues that caused them to trigger on push events instead of pull_request events. The working workflow is docs-slack.yml. Co-Authored-By: roachdev-claude --- .github/workflows/docs-pr-review-notify.yml | 31 --------------------- .github/workflows/docs-prs-review-slack.yml | 26 ----------------- 2 files changed, 57 deletions(-) delete mode 100644 .github/workflows/docs-pr-review-notify.yml delete mode 100644 .github/workflows/docs-prs-review-slack.yml diff --git a/.github/workflows/docs-pr-review-notify.yml b/.github/workflows/docs-pr-review-notify.yml deleted file mode 100644 index 67c12fd3531..00000000000 --- a/.github/workflows/docs-pr-review-notify.yml +++ /dev/null @@ -1,31 +0,0 @@ -name: Docs PR Review Notify - -on: - pull_request: - types: [review_requested] - -jobs: - notify: - runs-on: ubuntu-latest - steps: - - name: Send Slack notification - if: github.event.requested_team.slug == 'docs-prs' - env: - SLACK_WEBHOOK: ${{ secrets.SLACK_DOC_REVIEW_WEBHOOK_URL }} - PR_TITLE: ${{ github.event.pull_request.title }} - PR_URL: ${{ github.event.pull_request.html_url }} - PR_AUTHOR: ${{ github.event.pull_request.user.login }} - PR_NUMBER: ${{ github.event.pull_request.number }} - PR_LINES: ${{ github.event.pull_request.additions + github.event.pull_request.deletions }} - run: | - jq -n \ - --arg title "$PR_TITLE" \ - --arg url "$PR_URL" \ - --arg author "$PR_AUTHOR" \ - --arg number "$PR_NUMBER" \ - --arg lines "$PR_LINES" \ - '{pr_title: $title, pr_url: $url, pr_author: $author, pr_number: $number, lines_changed: $lines}' \ - | curl -X POST "$SLACK_WEBHOOK" \ - -H 'Content-Type: application/json' \ - --fail-with-body \ - -d @- diff --git a/.github/workflows/docs-prs-review-slack.yml b/.github/workflows/docs-prs-review-slack.yml deleted file mode 100644 index b8fe257ef82..00000000000 --- a/.github/workflows/docs-prs-review-slack.yml +++ /dev/null @@ -1,26 +0,0 @@ -name: Doc Review Slack Notifier - -on: - pull_request: - types: [review_requested] - -jobs: - notify: - runs-on: ubuntu-latest - steps: - - name: Send notification if docs-prs requested - run: | - TEAM="${{ github.event.requested_team.slug }}" - if [ "$TEAM" = "docs-prs" ]; then - jq -n \ - --arg title "${{ github.event.pull_request.title }}" \ - --arg url "${{ github.event.pull_request.html_url }}" \ - --arg author "${{ github.event.pull_request.user.login }}" \ - --arg number "${{ github.event.pull_request.number }}" \ - --arg lines "${{ github.event.pull_request.additions + github.event.pull_request.deletions }}" \ - '{pr_title: $title, pr_url: $url, pr_author: $author, pr_number: $number, lines_changed: $lines}' \ - | curl -X POST "${{ secrets.SLACK_DOC_REVIEW_WEBHOOK_URL }}" \ - -H 'Content-Type: application/json' \ - --fail-with-body \ - -d @- - fi