Refactor Get method in subResourceClient to improve error handling and simplify logic

Author: SoWieMarkus

pkg/multicluster/client.go

@@ -501,20 +501,10 @@ func (c *subResourceClient) Get(ctx context.Context, obj, subResource client.Obj
 	if err != nil {
 		return err
 	}
-	var lastErr error
+
 	found := false
 	for _, cl := range clusters {
-		if !found {
-			err := cl.GetClient().SubResource(c.subResource).Get(ctx, obj, subResource, opts...)
-			if err == nil {
-				found = true
-				continue
-			}
-			if !apierrors.IsNotFound(err) {
-				return err
-			}
-			lastErr = err
-		} else {
+		if found {
 			candidateObj := obj.DeepCopyObject().(client.Object)
 			candidateSub := subResource.DeepCopyObject().(client.Object)
 			err := cl.GetClient().SubResource(c.subResource).Get(ctx, candidateObj, candidateSub, opts...)
@@ -524,10 +514,20 @@ func (c *subResourceClient) Get(ctx context.Context, obj, subResource client.Obj
 			if !apierrors.IsNotFound(err) {
 				return err
 			}
+			continue
+		}
+
+		err := cl.GetClient().SubResource(c.subResource).Get(ctx, obj, subResource, opts...)
+		if err == nil {
+			found = true
+			continue
+		}
+		if !apierrors.IsNotFound(err) {
+			return err
 		}
 	}
 	if !found {
-		return lastErr
+		return apierrors.NewNotFound(schema.GroupResource{Group: gvk.Group, Resource: gvk.Kind}, obj.GetName())
 	}
 	return nil
 }