Increase default sync interval for OpenStack datasource from 60s to 600s (#660)

We encountered a bug in the openstack datasource controller in which
initial reconciles are pushed back in the priority queue due to the
controller enqueueing new reconciles with higher priority. This can lead
to some of the datasources never reconciling. By setting the sync
interval to a higher value this decreases the chance of the requeued
reconcile to push back initial reconciles indefinitely.

Author: SoWieMarkus

api/v1alpha1/datasource_types.go

@@ -167,7 +167,7 @@ type OpenStackDatasource struct {
 	Cinder CinderDatasource `json:"cinder"`
 
 	// How often to sync the datasource.
-	// +kubebuilder:default="60s"
+	// +kubebuilder:default="600s"
 	SyncInterval metav1.Duration `json:"syncInterval"`
 
 	// Keystone credentials secret ref for authenticating with openstack.

helm/bundles/cortex-nova/templates/datasources.yaml

@@ -87,6 +87,7 @@ spec:
   {{- end }}
   type: openstack
   openstack:
+    syncInterval: 600s
     secretRef:
       name: cortex-nova-openstack-keystone
       namespace: {{ .Release.Namespace }}
@@ -110,6 +111,7 @@ spec:
   {{- end }}
   type: openstack
   openstack:
+    syncInterval: 600s
     secretRef:
       name: cortex-nova-openstack-keystone
       namespace: {{ .Release.Namespace }}
@@ -133,6 +135,7 @@ spec:
   {{- end }}
   type: openstack
   openstack:
+    syncInterval: 600s
     secretRef:
       name: cortex-nova-openstack-keystone
       namespace: {{ .Release.Namespace }}
@@ -156,6 +159,7 @@ spec:
   {{- end }}
   type: openstack
   openstack:
+    syncInterval: 600s
     secretRef:
       name: cortex-nova-openstack-keystone
       namespace: {{ .Release.Namespace }}
@@ -179,6 +183,7 @@ spec:
   {{- end }}
   type: openstack
   openstack:
+    syncInterval: 600s
     secretRef:
       name: cortex-nova-openstack-keystone
       namespace: {{ .Release.Namespace }}
@@ -202,6 +207,7 @@ spec:
   {{- end }}
   type: openstack
   openstack:
+    syncInterval: 600s
     secretRef:
       name: cortex-nova-openstack-keystone
       namespace: {{ .Release.Namespace }}
@@ -225,6 +231,7 @@ spec:
   {{- end }}
   type: openstack
   openstack:
+    syncInterval: 600s
     secretRef:
       name: cortex-nova-openstack-keystone
       namespace: {{ .Release.Namespace }}
@@ -248,6 +255,7 @@ spec:
   {{- end }}
   type: openstack
   openstack:
+    syncInterval: 600s
     secretRef:
       name: cortex-nova-openstack-keystone
       namespace: {{ .Release.Namespace }}
@@ -271,6 +279,7 @@ spec:
   {{- end }}
   type: openstack
   openstack:
+    syncInterval: 600s
     secretRef:
       name: cortex-nova-openstack-keystone
       namespace: {{ .Release.Namespace }}
@@ -294,6 +303,7 @@ spec:
   {{- end }}
   type: openstack
   openstack:
+    syncInterval: 600s
     secretRef:
       name: cortex-nova-openstack-keystone
       namespace: {{ .Release.Namespace }}
@@ -317,6 +327,7 @@ spec:
   {{- end }}
   type: openstack
   openstack:
+    syncInterval: 600s
     secretRef:
       name: cortex-nova-openstack-keystone
       namespace: {{ .Release.Namespace }}
@@ -340,6 +351,7 @@ spec:
   {{- end }}
   type: openstack
   openstack:
+    syncInterval: 600s
     secretRef:
       name: cortex-nova-openstack-keystone
       namespace: {{ .Release.Namespace }}

helm/library/cortex/files/crds/cortex.cloud_datasources.yaml

@@ -180,7 +180,7 @@ spec:
                     type: object
                     x-kubernetes-map-type: atomic
                   syncInterval:
-                    default: 60s
+                    default: 600s
                     description: How often to sync the datasource.
                     type: string
                   type: