Skip to content

Commit 7fbd144

Browse files
committed
incorporated review comments
1 parent 9cfe718 commit 7fbd144

2 files changed

Lines changed: 7 additions & 7 deletions

File tree

cdap-e2e-tests/src/e2e-test/features/systemadmin/SysAdminRunTime.feature

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ Feature: Sysadmin - Validate system admin page Run time scenarios
2929
Then Verify the namespace created success message displayed on confirmation window
3030
Then Verify the created namespace: "namespaceName" is displayed in Namespace tab
3131

32-
@Required
32+
@SysAdminRequired
3333
Scenario:To verify User should be able to add a secure key from Make HTTP calls successfully with PUT calls
3434
Given Open Datafusion Project to configure pipeline
3535
Then Open "System Admin" menu
@@ -41,7 +41,7 @@ Feature: Sysadmin - Validate system admin page Run time scenarios
4141
Then Click on send button
4242
Then Verify the status code for success response
4343

44-
@Required
44+
@SysAdminRequired
4545
Scenario:To verify User should be able to fetch secure key from Make HTTP calls successfully with GET calls
4646
Given Open Datafusion Project to configure pipeline
4747
Then Open "System Admin" menu
@@ -52,7 +52,7 @@ Feature: Sysadmin - Validate system admin page Run time scenarios
5252
Then Click on send button
5353
Then Verify the status code for success response
5454

55-
@Required
55+
@SysAdminRequired
5656
Scenario:To verify User should be able to delete secure key from Make HTTP calls successfully with DELETE calls
5757
Given Open Datafusion Project to configure pipeline
5858
Then Open "System Admin" menu
@@ -63,7 +63,7 @@ Feature: Sysadmin - Validate system admin page Run time scenarios
6363
Then Click on send button
6464
Then Verify the status code for success response
6565

66-
@BQ_SOURCE_TEST @BQ_SINK_TEST @Required
66+
@BQ_SOURCE_TEST @BQ_SINK_TEST @SysAdminRequired
6767
Scenario:To verify user should be able to run a pipeline successfully using the System preferences created
6868
Given Open Datafusion Project to configure pipeline
6969
Then Open "System Admin" menu
@@ -101,7 +101,7 @@ Feature: Sysadmin - Validate system admin page Run time scenarios
101101
Then Open and capture logs
102102
Then Verify the pipeline status is "Succeeded"
103103

104-
@BQ_SOURCE_TEST @BQ_SINK_TEST @Required
104+
@BQ_SOURCE_TEST @BQ_SINK_TEST @SysAdminRequired
105105
Scenario:To verify user should be able to run a pipeline successfully using the Namespace preferences created
106106
Given Open Datafusion Project to configure pipeline
107107
Then Open "System Admin" menu

cdap-e2e-tests/src/e2e-test/java/io/cdap/cdap/common/common/TestRunnerRequired.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,13 +20,13 @@
2020
import org.junit.runner.RunWith;
2121

2222
/**
23-
* Test Runner to execute required test cases. Add @Required tag on the scenario.
23+
* Test Runner to execute required test cases. Add @SysAdminRequired tag on the scenario.
2424
*/
2525
@RunWith(Cucumber.class)
2626
@CucumberOptions(
2727
features = {"src/e2e-test/features"},
2828
glue = {"stepsdesign", "io.cdap.cdap.common.stepsdesign"},
29-
tags = {"@Required"},
29+
tags = {"@SysAdminRequired"},
3030
plugin = {"pretty", "html:target/cucumber-html-report/required",
3131
"json:target/cucumber-reports/cucumber-required.json",
3232
"junit:target/cucumber-reports/cucumber-required.xml"},

0 commit comments

Comments
 (0)