Addressed review coments

Author: rahuldash171

src/main/java/io/cdap/e2e/pages/actions/CdfNameSpaceAdminActions.java

@@ -45,7 +45,7 @@ public static void clickOnNameSpaceAdminTabs(String tabName, String nameSpaceNam
         CdfNameSpaceAdminLocators.nameSpaceModules(tabName, nameSpaceName));
   }
 
-  public static void clickOnNameSpaceAdminTab() {
+  public static void openNamespaceAdminPage() {
     ElementHelper.clickOnElement(CdfNameSpaceAdminLocators.namespaceAdminMenu);
   }
 
@@ -57,19 +57,19 @@ public static void clickOnEditPreference() {
     ElementHelper.clickOnElement(CdfNameSpaceAdminLocators.editPreferencesButton);
   }
 
-  public static void switchOnNameSpace(String nameSpaceName) {
+  public static void switchToNameSpace(String nameSpaceName) {
     ElementHelper.clickOnElement(CdfNameSpaceAdminLocators.switchNameSpace(nameSpaceName));
   }
 
-  public static void createProfileforNameSpace(String nameSpaceName) {
+  public static void createProfileForNamespace(String nameSpaceName) {
     ElementHelper.clickOnElement(CdfNameSpaceAdminLocators.createProfile(nameSpaceName));
   }
 
-  public static void openNameSpacedropdown() {
+  public static void openNamespaceDropdown() {
     ElementHelper.clickOnElement(CdfNameSpaceAdminLocators.namespaceDropdown);
   }
 
-  public static void addNameSpacefromHamnugerMenu() {
+  public static void addNamespaceFromHamburgerMenu() {
     ElementHelper.clickOnElement(CdfNameSpaceAdminLocators.addNamespace);
   }
 
@@ -162,7 +162,7 @@ public static void clickOnResetPreference() {
   }
 
   /**
-   * Verify if the added Preferences reset is validated successfully
+   * Verify if the added Preferences reset is successful
    */
   public static void verifyIfResetValidatedSuccessfully() {
     WaitHelper.waitForElementToBeDisplayed(CdfNameSpaceAdminLocators.resetSuccessMsg);
@@ -251,4 +251,23 @@ public static void verifySwitchToNewNamespace(String value) {
   public static void verifyElementIsDisplayed() {
     ElementHelper.isElementDisplayed(CdfNameSpaceAdminLocators.pageHeaderNameSpaceAdmin);
   }
+
+  /**
+   * Check whether Create Profile Properties Page is loaded
+   */
+  public static void verifyCreateProfilePageLoaded() {
+    WaitHelper.waitForElementToBeOptionallyDisplayed(CdfNameSpaceAdminLocators.profilePropertiesPage(),
+        ConstantsUtil.DEFAULT_TIMEOUT_SECONDS);
+  }
+
+  /**
+   * Check whether Profile created is present in System Compute Profile tab
+   *
+   * @param profileTitle any specific title created
+   */
+  public static void verifyProvisionerPresentComputeProfile(String profileTitle) {
+    WaitHelper.waitForElementToBeOptionallyDisplayed(CdfNameSpaceAdminLocators.
+            locateProfileTitle(PluginPropertyUtils.pluginProp(profileTitle)),
+        ConstantsUtil.DEFAULT_TIMEOUT_SECONDS);
+  }
 }

src/main/java/io/cdap/e2e/pages/locators/CdfNameSpaceAdminLocators.java

@@ -113,6 +113,14 @@ public static WebElement locateButtonType(String buttonType) {
         .findElement(By.xpath("//button[@data-cy='" + buttonType + "']"));
   }
 
+  public static By profilePropertiesPage() {
+    return By.xpath("//h5[contains(text(), 'Create a profile')]");
+  }
+
+  public static By locateProfileTitle(String profileName) {
+    return By.xpath("//div[@title='" + profileName + "']");
+  }
+
   @FindBy(how = How.XPATH, using = "//a[contains(text(),\"Switch to\")]")
   public static WebElement switchToCreatedNamespace;
 

src/main/java/stepsdesign/NameSpaceadminSteps.java

@@ -36,12 +36,12 @@ public static void clickOnTheHamburgerIcon() {
 
   @Then("Click on NameSpace Admin link from the menu")
   public void openNameSpaceAdminPage() {
-    CdfNameSpaceAdminActions.clickOnNameSpaceAdminTab();
+    CdfNameSpaceAdminActions.openNamespaceAdminPage();
   }
 
   @Then("Click on create profile button for {string} Namespace")
   public void createProfileinsideNamespaceAdmin(String nameSpace) {
-    CdfNameSpaceAdminActions.createProfileforNameSpace(nameSpace);
+    CdfNameSpaceAdminActions.createProfileForNamespace(nameSpace);
   }
 
   @Then("Click {string} tab from Configuration page for {string} Namespace")
@@ -56,20 +56,20 @@ public void clickOnEditNameSpacePreferences() {
 
   @Then("Click on Namespace dropdown button")
   public void openNameSpaceDropdown() {
-    CdfNameSpaceAdminActions.openNameSpacedropdown();
+    CdfNameSpaceAdminActions.openNamespaceDropdown();
   }
 
   @Then("Click on the Add Namespace tab")
   public void addNamespaceFromHamburgerMenu() {
-    CdfNameSpaceAdminActions.addNameSpacefromHamnugerMenu();
+    CdfNameSpaceAdminActions.addNamespaceFromHamburgerMenu();
   }
 
   @Then("Select navigation item: {string} from the Hamburger menu list")
   public void selectNavigationItemFromMenu(String tabName) {
     CdfNameSpaceAdminActions.selectHamburgerMenuList(tabName);
   }
 
-  @Then("Set nameSpace preferences with key: {string} and value: {string}")
+  @Then("Set namespace preferences with key: {string} and value: {string}")
   public void setSystemPreferencesWithKeyAndValue(String pluginProperty, String keyValuePairs) {
     CdfNameSpaceAdminActions.enterKeyValuePreferences(pluginProperty, keyValuePairs);
   }
@@ -134,7 +134,7 @@ public void switchToNewNameSpace() {
     CdfNameSpaceAdminActions.switchToNewNameSpace();
   }
 
-  @Then("Verify if the switch is successful by checking the current {string} value")
+  @Then("Verify the namespace is switched to {string} successfully")
   public void verifyNameSpaceSwitch(String newNameSpaceName) {
     CdfNameSpaceAdminActions.verifySwitchToNewNamespace(newNameSpaceName);
   }
@@ -146,8 +146,18 @@ public void addConnectionInNameSpaceAdmin(String connectionType, String connecti
     CdfPluginPropertiesActions.replaceValueInInputProperty("projectId", "projectId");
   }
 
-  @Then("Verify that the user is navigated to nameSpace admin page successfully")
-  public void verifyThatHubPageIsSuccessfullyOpened() {
+  @Then("Verify if user successfully navigated to namespace admin page")
+  public void verifyThatNamespacePageIsSuccessfullyOpened() {
     CdfNameSpaceAdminActions.verifyElementIsDisplayed();
   }
+
+  @Then("Verify the Create a Profile page is loaded for selected provisioner")
+  public void verifyTheCreateAProfilePageIsLoaded() {
+    CdfNameSpaceAdminActions.verifyCreateProfilePageLoaded();
+  }
+
+  @Then("Verify the created compute profile: {string} is displayed in system compute profile list")
+  public void verifyTheCreatedComputeProfile(String profile) {
+    CdfNameSpaceAdminActions.verifyProvisionerPresentComputeProfile(profile);
+  }
 }