From 8fdd7dd6de3af14f1832c778fba8b2ac4b0465f7 Mon Sep 17 00:00:00 2001 From: Uday Date: Wed, 6 May 2026 11:04:37 +0530 Subject: [PATCH 1/4] Add pre-commit action (cherry picked from commit 218ff6ed334a4e9035b814e7f8c85c8d20108a37) --- .github/workflows/pre-commit.yml | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) create mode 100644 .github/workflows/pre-commit.yml diff --git a/.github/workflows/pre-commit.yml b/.github/workflows/pre-commit.yml new file mode 100644 index 000000000..d1ef0bb7a --- /dev/null +++ b/.github/workflows/pre-commit.yml @@ -0,0 +1,16 @@ +name: pre-commit + +on: + pull_request: + push: + branches: [main] + +jobs: + pre-commit: + runs-on: ubuntu-latest + steps: + - uses: actions/checkout@v6 + - uses: actions/setup-python@v6 + with: + python-version-file: .python-version + - uses: pre-commit/action@v3.0.1 From bff385e85cfc830bbb184c4032c9c41ca22ace51 Mon Sep 17 00:00:00 2001 From: Uday Date: Thu, 7 May 2026 11:31:16 +0530 Subject: [PATCH 2/4] Switched from the deprecated mirrors-autopep8 to the official repo --- .pre-commit-config.yaml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml index f3372a8ca..1612e3b8b 100644 --- a/.pre-commit-config.yaml +++ b/.pre-commit-config.yaml @@ -24,8 +24,8 @@ repos: - launchable/*.py - tests/*.py - - repo: https://github.com/pre-commit/mirrors-autopep8 - rev: v1.7.0 + - repo: https://github.com/hhatto/autopep8 + rev: v2.3.2 hooks: - id: autopep8 args: From 8ffc27af39b2606bad0c0a66ca2a96250f250846 Mon Sep 17 00:00:00 2001 From: Uday Date: Thu, 7 May 2026 11:31:43 +0530 Subject: [PATCH 3/4] Run pre-commit for all files --- build-java.sh | 1 - launchable/commands/verify.py | 2 +- launchable/test_runners/file.py | 1 - launchable/utils/http_client.py | 2 +- tests/data/jasmine/README.md | 1 - tests/data/karma/subset_payload.json | 2 +- tests/data/playwright/playwright.config.ts | 1 - tests/test_runners/test_playwright.py | 1 - 8 files changed, 3 insertions(+), 8 deletions(-) diff --git a/build-java.sh b/build-java.sh index 01b82321f..f7fde55c3 100755 --- a/build-java.sh +++ b/build-java.sh @@ -2,4 +2,3 @@ bazel build //src/main/java/com/launchableinc/ingest/commits:exe_deploy.jar bazel test //... cp bazel-bin/src/main/java/com/launchableinc/ingest/commits/exe_deploy.jar launchable/jar/exe_deploy.jar - diff --git a/launchable/commands/verify.py b/launchable/commands/verify.py index a7d47eb7b..9c8a831c1 100644 --- a/launchable/commands/verify.py +++ b/launchable/commands/verify.py @@ -11,7 +11,7 @@ from launchable.utils.env_keys import TOKEN_KEY from launchable.utils.tracking import Tracking, TrackingClient -from ..utils.authentication import get_org_workspace, ensure_org_workspace +from ..utils.authentication import ensure_org_workspace, get_org_workspace from ..utils.click import emoji from ..utils.commands import Command from ..utils.http_client import DEFAULT_BASE_URL diff --git a/launchable/test_runners/file.py b/launchable/test_runners/file.py index daf725b4d..ce07205cb 100644 --- a/launchable/test_runners/file.py +++ b/launchable/test_runners/file.py @@ -4,7 +4,6 @@ from . import launchable - subset = launchable.CommonSubsetImpls(__name__).scan_stdin() record_tests = launchable.CommonRecordTestImpls(__name__).file_profile_report_files() diff --git a/launchable/utils/http_client.py b/launchable/utils/http_client.py index 3cd865d25..e7b51277c 100644 --- a/launchable/utils/http_client.py +++ b/launchable/utils/http_client.py @@ -16,7 +16,7 @@ from .authentication import authentication_headers from .env_keys import BASE_URL_KEY, SKIP_TIMEOUT_RETRY from .gzipgen import compress as gzipgen_compress -from .logger import AUDIT_LOG_FORMAT, Logger +from .logger import Logger DEFAULT_BASE_URL = "https://api.mercury.launchableinc.com" diff --git a/tests/data/jasmine/README.md b/tests/data/jasmine/README.md index a7e67a966..61167d49f 100644 --- a/tests/data/jasmine/README.md +++ b/tests/data/jasmine/README.md @@ -38,4 +38,3 @@ Request subset cat test_list.txt | launchable subset --target 25% jasmine > subset.txt npx jasmine $(cat subset.txt) ``` - diff --git a/tests/data/karma/subset_payload.json b/tests/data/karma/subset_payload.json index 3d10b6085..a86d62829 100644 --- a/tests/data/karma/subset_payload.json +++ b/tests/data/karma/subset_payload.json @@ -13,4 +13,4 @@ "session": { "id": "16" }, "getTestsFromGuess": false, "getTestsFromPreviousSessions": false -} \ No newline at end of file +} diff --git a/tests/data/playwright/playwright.config.ts b/tests/data/playwright/playwright.config.ts index 8b1378917..e69de29bb 100644 --- a/tests/data/playwright/playwright.config.ts +++ b/tests/data/playwright/playwright.config.ts @@ -1 +0,0 @@ - diff --git a/tests/test_runners/test_playwright.py b/tests/test_runners/test_playwright.py index cff26d296..cda4a751b 100644 --- a/tests/test_runners/test_playwright.py +++ b/tests/test_runners/test_playwright.py @@ -3,7 +3,6 @@ import os import sys import unittest -from pathlib import Path from unittest import mock import responses # type: ignore From e4804ab76b728882ba910ff0fd0a8b4cda6f1c9a Mon Sep 17 00:00:00 2001 From: Uday Date: Thu, 7 May 2026 11:43:52 +0530 Subject: [PATCH 4/4] Use Python 3.12 for pre-commit workflow .python-version targets 3.6 for test compatibility, but pre-commit hooks (flake8 7.0, autopep8 2.x) require Python >=3.8. Use an explicit Python version for the linting workflow instead of reading .python-version. --- .github/workflows/pre-commit.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/pre-commit.yml b/.github/workflows/pre-commit.yml index d1ef0bb7a..24429c165 100644 --- a/.github/workflows/pre-commit.yml +++ b/.github/workflows/pre-commit.yml @@ -7,10 +7,10 @@ on: jobs: pre-commit: - runs-on: ubuntu-latest + runs-on: ubuntu-22.04 steps: - uses: actions/checkout@v6 - uses: actions/setup-python@v6 with: - python-version-file: .python-version + python-version: "3.12" - uses: pre-commit/action@v3.0.1