Skip to content

osmorphing: dismount OS on failure #438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
claudiubelu wants to merge 1 commit into
base: master
Choose a base branch
from
Open

osmorphing: dismount OS on failure #438

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 28 additions & 13 deletions coriolis/osmorphing/manager.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,6 +155,34 @@ def morph_image(origin_provider, destination_provider, connection_info,

osmorphing_info['os_root_dir'] = os_root_dir
osmorphing_info['os_root_dev'] = os_root_dev
try:
_morph_image(
origin_provider, destination_provider, connection_info,
osmorphing_info, user_script, event_handler, os_mount_tools,
)
finally:
event_manager.progress_update("Dismounting OS partitions")
try:
os_mount_tools.dismount_os(os_root_dir)
except Exception as err:
raise exception.CoriolisException(
"Failed to dismount the OS undergoing OSMorphing. This could "
"have been caused by minor FS corruption during the last disk "
"sync. Please ensure that any source-side FS integrity "
"mechanisms (e.g. filesystem quiescing, crash-consistent "
"backups, etc.) are enabled and available for the source "
"machine. If none are available, please try "
"migrating/replicating the source machine while it is powered "
"off. Error was: %s" % str(err)) from err


def _morph_image(origin_provider, destination_provider, connection_info,
osmorphing_info, user_script, event_handler, os_mount_tools):
event_manager = events.EventManager(event_handler)

os_type = osmorphing_info.get('os_type')
os_root_dir = osmorphing_info['os_root_dir']
os_root_dev = osmorphing_info['os_root_dev']
conn = os_mount_tools.get_connection()

environment = os_mount_tools.get_environment()
Expand Down Expand Up @@ -261,16 +289,3 @@ def morph_image(origin_provider, destination_provider, connection_info,

LOG.info("Post packages install")
import_os_morphing_tools.post_packages_install(packages_add)

event_manager.progress_update("Dismounting OS partitions")
try:
os_mount_tools.dismount_os(os_root_dir)
except Exception as err:
raise exception.CoriolisException(
"Failed to dismount the OS undergoing OSMorphing. This could have "
"been caused by minor FS corruption during the last disk sync. "
"Please ensure that any source-side FS integrity mechanisms (e.g. "
"filesystem quiescing, crash-consistent backups, etc.) are "
"enabled and available for the source machine. If none are "
"available, please try migrating/replicating the source machine "
"while it is powered off. Error was: %s" % str(err)) from err
2 changes: 1 addition & 1 deletion coriolis/tests/osmorphing/test_manager.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -230,7 +230,7 @@ def test_morph_image(

mock_get_os_mount_tools.assert_called_once_with(
'linux', mock.sentinel.connection_info, self.event_manager, [], 60)
mock_EventManager.assert_called_once_with(self.event_handler)
mock_EventManager.assert_called_with(self.event_handler)

self.os_mount_tools.dismount_os.assert_called_once()

Expand Down
Loading