Inject container in migration files (as Doctrine)

[lrocheWB]

Hi,

I would inject the service container in the migration files, as Doctrine have done:
http://symfony.com/doc/current/bundles/DoctrineMigrationsBundle/index.html#container-aware-migrations

If I am not mistaken, feature is not yet available.
In my project, we use version 1.0.2 (claroline/MigrationBundle), can I propose a pull request on this branch ?

This is my branch: lrocheWB@a1a381c

cc @Netmisa

Thx

[ngodfraind]

Hello,

I have a few questions:

• Why do you use 1.0.2 (can you upgrade ?)
• Why do you need to inject the container ?

Otherwise I think I'm ok with your changes altough they're not usefull for our project.

[lrocheWB]

Thanks for your reply @ngodfraind

1. Unfortunately, we can't upgrade because our server configuration is not optimize. It is a constraint directly related to our project. I tried but I failed :/
2. We need to inject the container to get specific parameter (in parameters.yml file), different on each platform.

Do not hesitate if you have any other questions.

[ngodfraind]

I think you should point directly in your project from your fork in that case. If you really need it I can make a 1.0.2.x branch for you but it doesn't really make a lot of sense to upgrade/maintain it from our pov.

[lrocheWB]

I understand your position but I think It is unfortunate to loose functionality provided by Doctrine (DoctrineMigrationsBundle).

As said in documentation:

In some cases you might need access to the container to ensure the proper update of your data structure. This could be necessary to update relations with some specific logic or to create new entities.

Therefore you can just implement the ContainerAwareInterface with its needed methods to get full access to the container.

In our case, that's a great technical value.

If you are not still interested, we will create a link with our fork.

Thx

[ngodfraind]

Well, I'll speak with other ppl in our project. If they're ok I'll add your changes in both the master and a 1.0.2.x branch for you.