fixes

Author: ckdake

tests/providers/test_ridewithgps.py

@@ -105,7 +105,7 @@ def test_update_activity_multiple_fields():
 
 
 def test_update_activity_api_failure():
-    """Test handling of API failure during update."""
+    """Test that API failure during update raises the exception."""
     provider = RideWithGPSProvider()
 
     # Mock API failure
@@ -114,18 +114,16 @@ def test_update_activity_api_failure():
     # Test data
     activity_data = {"ridewithgps_id": "12345", "name": "Updated Name"}
 
-    # Call update_activity and expect it to handle the exception
-    result = provider.update_activity(activity_data)
-
-    # Verify the result is False due to the exception
-    assert result is False
+    # update_activity should raise so callers get the real error message
+    with pytest.raises(Exception, match="API Error"):
+        provider.update_activity(activity_data)
 
     # Verify the API was called
     provider.client.patch.assert_called_once()
 
 
 def test_update_activity_api_error_response():
-    """Test handling of API error response during update."""
+    """Test that an API error response during update raises a RuntimeError."""
     provider = RideWithGPSProvider()
 
     # Mock API response with error
@@ -135,11 +133,9 @@ def test_update_activity_api_error_response():
     # Test data
     activity_data = {"ridewithgps_id": "12345", "name": "Updated Name"}
 
-    # Call update_activity
-    result = provider.update_activity(activity_data)
-
-    # Verify the result is False due to the error response
-    assert result is False
+    # update_activity should raise so callers get the real error message
+    with pytest.raises(RuntimeError, match="Some API error"):
+        provider.update_activity(activity_data)
 
 
 def test_update_activity_removes_provider_id():

tests/providers/test_strava.py

@@ -75,7 +75,7 @@ def test_update_activity_multiple_fields(self):
         )
 
     def test_update_activity_api_failure(self):
-        """Test handling of API failure during update."""
+        """Test that API failure during update raises the exception."""
         # Mock the stravalib client to raise an exception
         mock_client = Mock()
         mock_client.update_activity = Mock(side_effect=Exception("API Error"))
@@ -87,11 +87,9 @@ def test_update_activity_api_failure(self):
         # Test data
         activity_data = {"strava_id": "12345", "name": "Updated Name"}
 
-        # Call update_activity and expect it to handle the exception
-        result = provider.update_activity(activity_data)
-
-        # Verify the result is False due to the exception
-        assert result is False
+        # update_activity should raise so callers get the real error message
+        with pytest.raises(Exception, match="API Error"):
+            provider.update_activity(activity_data)
 
         # Verify the API was called
         mock_client.update_activity.assert_called_once()

tracekit/providers/ridewithgps/ridewithgps_provider.py

@@ -143,14 +143,13 @@ def update_activity(self, activity_data: dict) -> bool:
 
             # Check if there's an error in the response
             if hasattr(response, "error"):
-                print(f"API returned error: {response.error}")
-                return False
+                raise RuntimeError(f"RideWithGPS API error: {response.error}")
 
             return True
 
         except Exception as e:
             print(f"Error updating RideWithGPS trip {provider_id}: {e}")
-            return False
+            raise
 
     def get_all_gear(self) -> dict[str, str]:
         """Get gear from RideWithGPS user info."""

tracekit/providers/strava/strava_provider.py

@@ -283,7 +283,7 @@ def update_activity(self, activity_data: dict[str, Any]) -> bool:
 
         except Exception as e:
             print(f"Error updating Strava activity {provider_id}: {e}")
-            return False
+            raise
 
     def get_all_gear(self) -> dict[str, str]:
         """Get all gear from Strava athlete profile."""

tracekit/worker.py

@@ -195,13 +195,14 @@ def apply_sync_change(self, change_dict: dict, year_month: str):
                 create_notification(f"Sync change failed: {msg}", category="error")
             except Exception:
                 pass
-            raise RuntimeError(msg)
+            return {"success": False, "message": msg}
 
     except Exception as exc:
+        msg = str(exc)
         try:
             from tracekit.notification import create_notification
 
-            create_notification(f"Sync change error for {year_month}: {exc}", category="error")
+            create_notification(f"Sync change error for {year_month}: {msg}", category="error")
         except Exception:
             pass
         raise