Modify markdown and id retrieval tests

Author: chrisqm-dev

.github/workflows/develop.yaml

@@ -335,9 +335,10 @@ jobs:
         id: create-markdown-cs
         uses: aws-actions/aws-cloudformation-github-deploy@v2.0.0-beta
         with:
+          mode: "create-only"
           name: test-markdown-${{ github.run_number }}
-          template: markdown-test-template.yaml
-          parameter-overrides: "Environment=gamma"  # Change parameter to trigger update
+          template: markdown-test-template-updated.yaml
+          parameter-overrides: "Environment=test"
 
       - name: Verify markdown output format
         run: |
@@ -462,27 +463,36 @@ jobs:
           role-to-assume: ${{ secrets.AWS_ROLE_TO_ASSUME }}
           aws-region: us-east-1
 
-      - name: Test stack creation with ID retrieval
-        id: create-stack
+      - name: Test stack creation that fails to retrieve stack ID
+        id: create-failing-stack
         uses: aws-actions/aws-cloudformation-github-deploy@v2.0.0-beta
         with:
-          name: test-stack-id-${{ github.run_number }}
-          template: stack.yaml
-          parameter-overrides: "Environment=beta"
+          name: test-failing-stack-id-${{ github.run_number }}
+          template: failing-stack.yaml
+          parameter-overrides: "Environment=test"
+        continue-on-error: true
 
-      - name: Verify stack ID format
+      - name: Verify stack ID retrieval on failure
         run: |
-          STACK_ID="${{ steps.create-stack.outputs.stack-id }}"
+          STACK_ID="${{ steps.create-failing-stack.outputs.stack-id }}"
           echo "Stack ID: $STACK_ID"
+          echo "Deployment outcome: ${{ steps.create-failing-stack.outcome }}"
           
-          if [[ $STACK_ID == arn:aws:cloudformation:* ]]; then
-            echo "✅ Stack ID is in correct ARN format"
+          # For failed deployments, we should get a stack ID (ARN) for debugging
+          if [[ "${{ steps.create-failing-stack.outcome }}" == "failure" ]]; then
+            if [[ $STACK_ID == arn:aws:cloudformation:* ]]; then
+              echo "✅ Stack ID retrieved successfully for failed deployment"
+              # Verify we can access the failed stack for debugging
+              aws cloudformation describe-stacks --stack-name "$STACK_ID"
+              echo "✅ Failed stack is accessible for debugging"
+            else
+              echo "❌ Expected stack ARN for failed deployment, got: $STACK_ID"
+              exit 1
+            fi
           else
-            echo "❌ Stack ID format is incorrect: $STACK_ID"
+            echo "❌ Expected deployment to fail for this test"
             exit 1
           fi
-          
-          aws cloudformation describe-stacks --stack-name "$STACK_ID"
 
   test-execute-only-with-events:
     runs-on: ubuntu-latest

failing-stack.yaml

@@ -0,0 +1,40 @@
+AWSTemplateFormatVersion: '2010-09-09'
+Description: 'Template designed to fail during deployment for stack ID testing'
+
+Parameters:
+  Environment:
+    Type: String
+    Default: test
+
+Resources:
+  # This will fail because we're trying to create a bucket with an invalid name
+  FailingBucket:
+    Type: AWS::S3::Bucket
+    Properties:
+      BucketName: "INVALID_BUCKET_NAME_WITH_UPPERCASE_AND_UNDERSCORES"
+      
+  # This Lambda will fail because the code doesn't exist
+  FailingLambda:
+    Type: AWS::Lambda::Function
+    Properties:
+      FunctionName: !Sub "failing-lambda-${Environment}"
+      Runtime: python3.9
+      Handler: index.handler
+      Code:
+        ZipFile: |
+          # This will cause a runtime error
+          import nonexistent_module
+          def handler(event, context):
+              return nonexistent_module.do_something()
+      Role: !GetAtt FailingRole.Arn
+
+  FailingRole:
+    Type: AWS::IAM::Role
+    Properties:
+      AssumeRolePolicyDocument:
+        Version: '2012-10-17'
+        Statement:
+          - Effect: Allow
+            Principal:
+              Service: lambda.amazonaws.com
+            Action: sts:AssumeRole

markdown-test-template-updated.yaml

@@ -0,0 +1,51 @@
+AWSTemplateFormatVersion: '2010-09-09'
+Description: 'Updated template for testing markdown output generation'
+
+Parameters:
+  Environment:
+    Type: String
+    Default: test
+
+Resources:
+  MarkdownTestBucket:
+    Type: AWS::S3::Bucket
+    Properties:
+      BucketName: !Sub "markdown-test-${Environment}-${AWS::StackName}"
+      PublicAccessBlockConfiguration:
+        BlockPublicAcls: true
+        BlockPublicPolicy: true
+        IgnorePublicAcls: true
+        RestrictPublicBuckets: true
+      # Added versioning to trigger a change
+      VersioningConfiguration:
+        Status: Enabled
+
+  MarkdownTestParameter:
+    Type: AWS::SSM::Parameter
+    Properties:
+      Name: !Sub "/${Environment}/markdown-test/${AWS::StackName}"
+      Type: String
+      Value: "updated-markdown-test-value"  # Changed value
+      Description: "Updated parameter for markdown output testing"
+
+  # Added new resource
+  MarkdownTestRole:
+    Type: AWS::IAM::Role
+    Properties:
+      AssumeRolePolicyDocument:
+        Version: '2012-10-17'
+        Statement:
+          - Effect: Allow
+            Principal:
+              Service: lambda.amazonaws.com
+            Action: sts:AssumeRole
+      ManagedPolicyArns:
+        - arn:aws:iam::aws:policy/service-role/AWSLambdaBasicExecutionRole
+
+Outputs:
+  BucketArn:
+    Value: !GetAtt MarkdownTestBucket.Arn
+  ParameterArn:
+    Value: !Sub "arn:aws:ssm:${AWS::Region}:${AWS::AccountId}:parameter${MarkdownTestParameter}"
+  RoleArn:
+    Value: !GetAtt MarkdownTestRole.Arn