Currently, when we build the runtime for nightly correctness testing, we set OPTIMIZE=1. This explicitly sets -DNDEBUG for the runtime, which disables asserts. This means that bugs like #28289 will slip in, because all tests are not run with asserts enabled.
I am not proposing we stop setting OPTIMIZE=1 for nightly testing (otherwise testing will take forever), but we should definitely have asserts enabled for the majority of nightly testing.
Currently, we have ASSERTS=0 for most nightly tests. I think we should expand that. Furthermore, ASSERTS is not threaded into the runtime to control asserts (even though https://chapel-lang.org/docs/main/usingchapel/building.html#makefile-options claims that it is)
Currently, when we build the runtime for nightly correctness testing, we set
OPTIMIZE=1. This explicitly sets-DNDEBUGfor the runtime, which disables asserts. This means that bugs like #28289 will slip in, because all tests are not run with asserts enabled.I am not proposing we stop setting
OPTIMIZE=1for nightly testing (otherwise testing will take forever), but we should definitely have asserts enabled for the majority of nightly testing.Currently, we have
ASSERTS=0for most nightly tests. I think we should expand that. Furthermore,ASSERTSis not threaded into the runtime to control asserts (even though https://chapel-lang.org/docs/main/usingchapel/building.html#makefile-options claims that it is)