From d85826807c7a6adfa24661477d5b0b4812b007b6 Mon Sep 17 00:00:00 2001 From: Lars Erik Wik Date: Tue, 25 Aug 2026 11:02:05 +0200 Subject: [PATCH] Fixed dubious argument order in RecordPkgOperationInChroot Each call to RecordPkgOperationInChroot passed version followed by architecture in the arguments. However, the function signature had this the other way around. To avoid any change in behavior, I changed the parameter names to match the arguments of the call sites. Signed-off-by: Lars Erik Wik --- libpromises/changes_chroot.c | 2 +- libpromises/changes_chroot.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/libpromises/changes_chroot.c b/libpromises/changes_chroot.c index 062b387027b..82fd1ff30bc 100644 --- a/libpromises/changes_chroot.c +++ b/libpromises/changes_chroot.c @@ -265,7 +265,7 @@ bool RecordFileEvaluatedInChroot(const char *path) return ret; } -bool RecordPkgOperationInChroot(const char *op, const char *name, const char *arch, const char *version) +bool RecordPkgOperationInChroot(const char *op, const char *name, const char *version, const char *arch) { assert(op != NULL); assert(name != NULL); diff --git a/libpromises/changes_chroot.h b/libpromises/changes_chroot.h index e17b25763a3..a325aaed31c 100644 --- a/libpromises/changes_chroot.h +++ b/libpromises/changes_chroot.h @@ -34,6 +34,6 @@ void PrepareChangesChroot(const char *path); bool RecordFileChangedInChroot(const char *path); bool RecordFileRenamedInChroot(const char *old_name, const char *new_name); bool RecordFileEvaluatedInChroot(const char *path); -bool RecordPkgOperationInChroot(const char *op, const char *name, const char *arch, const char *version); +bool RecordPkgOperationInChroot(const char *op, const char *name, const char *version, const char *arch); #endif /* CFENGINE_CHANGES_CHROOT_H */