From 034f407de78e073dece91bad898b376f8a706a31 Mon Sep 17 00:00:00 2001 From: Craig Comstock Date: Tue, 10 Feb 2026 10:11:09 -0600 Subject: [PATCH 1/3] Added safeguard to static-check runner in case of 1 proc host Ticket: ENT-13730 Changelog: none --- tests/static-check/run_checks.sh | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tests/static-check/run_checks.sh b/tests/static-check/run_checks.sh index f5bc3319a3..b7e7c39325 100755 --- a/tests/static-check/run_checks.sh +++ b/tests/static-check/run_checks.sh @@ -4,6 +4,9 @@ set -x n_procs="$(getconf _NPROCESSORS_ONLN)" use_procs=$((n_procs/2)) +if [ "$use_procs" -lt "0" ]; then + use_procs=1 +fi function check_with_gcc() { # previous runs may have cached configuration based on a different CC From c78bb82f85bc2e7a29725c3e50b7e10cb0fe3d1a Mon Sep 17 00:00:00 2001 From: Craig Comstock Date: Tue, 10 Feb 2026 10:13:35 -0600 Subject: [PATCH 2/3] debug-deleteme: Added code version check in static-check test Ticket: ENT-13730 Changelog: none --- tests/static-check/run_checks.sh | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tests/static-check/run_checks.sh b/tests/static-check/run_checks.sh index b7e7c39325..809583ed64 100755 --- a/tests/static-check/run_checks.sh +++ b/tests/static-check/run_checks.sh @@ -63,6 +63,9 @@ if [ ! -f configure ]; then NO_CONFIGURE=1 ./autogen.sh --enable-debug fi +echo "confirm version of codebase with git log -1" +git log -1 + check_with_gcc || { failures="${failures}FAIL: GCC check failed\n"; failure=1; } check_with_clang || { failures="${failures}FAIL: Clang check failed\n"; failure=1; } check_with_cppcheck || { failures="${failures}FAIL: cppcheck failed\n"; failure=1; } From 1b28698f91691c47efc95ae1e31de2d02b2c3336 Mon Sep 17 00:00:00 2001 From: Craig Comstock Date: Tue, 10 Feb 2026 10:24:51 -0600 Subject: [PATCH 3/3] Revert "Fixed NULL pointer dereference in AddSimpleUidItem() and AddSimpleGidItem()" This reverts commit d8f6a15ab8d133da0cea4ae03c15c2060a3a5fca. This is to test that our static-check runner works generally. This commit fixes something that was broken but was only being reported in some runners. --- libpromises/conversion.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libpromises/conversion.c b/libpromises/conversion.c index 71c5f87312..bf9be81bf3 100644 --- a/libpromises/conversion.c +++ b/libpromises/conversion.c @@ -957,7 +957,7 @@ static void AddSimpleUidItem(UidList ** uidlist, uid_t uid, char *uidname) ulp->uid = uid; - if (uid == CF_UNKNOWN_OWNER && uidname != NULL) /* unknown user */ + if (uid == CF_UNKNOWN_OWNER) /* unknown user */ { ulp->uidname = xstrdup(uidname); } @@ -1019,7 +1019,7 @@ static void AddSimpleGidItem(GidList ** gidlist, gid_t gid, char *gidname) glp->gid = gid; - if (gid == CF_UNKNOWN_GROUP && gidname != NULL) /* unknown group */ + if (gid == CF_UNKNOWN_GROUP) /* unknown group */ { glp->gidname = xstrdup(gidname); }