Skip to content

Commit f70dcea

Browse files
authored
Merge pull request #282 from jakub-nt/python-3.5-pyright
Fix Python 3.5 test failures related to Pyright
2 parents a7f8bbc + b64e26c commit f70dcea

2 files changed

Lines changed: 9 additions & 3 deletions

File tree

.github/actions/set-up-legacy-python/action.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,6 @@ runs:
2222
command: pip install -U pip
2323
- name: Install dependencies
2424
run: |
25-
python -m pip install flake8 pyright pytest setuptools wheel
25+
python -m pip install flake8 pytest setuptools wheel
2626
if [ -f requirements.txt ]; then pip install -r requirements.txt; fi
2727
shell: bash

.github/workflows/python-tests.yml

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ jobs:
3737
flake8 . --ignore=E203,W503,E722,E731 --max-complexity=100 --max-line-length=160
3838
- name: Lint with pyright (type checking)
3939
run: |
40-
pyright cfbs
40+
pyright cfbs --pythonversion ${{ matrix.python-version }}
4141
- name: Test with pytest
4242
run: |
4343
pytest
@@ -64,6 +64,12 @@ jobs:
6464
- uses: actions/checkout@v4
6565
with:
6666
fetch-depth: 0
67+
- uses: actions/setup-node@v5
68+
with:
69+
node-version: 24
70+
- name: Install Pyright
71+
run: |
72+
npm install -g pyright
6773
- name: Set up legacy Python ${{ matrix.python-version }}
6874
uses: ./.github/actions/set-up-legacy-python
6975
with:
@@ -73,7 +79,7 @@ jobs:
7379
python -m flake8 . --ignore=E203,W503,E722,E731 --max-complexity=100 --max-line-length=160
7480
- name: Lint with pyright (type checking)
7581
run: |
76-
python -m pyright cfbs
82+
pyright cfbs --pythonversion ${{ matrix.python-version }}
7783
- name: Test with pytest
7884
run: |
7985
python -m pytest

0 commit comments

Comments
 (0)