Fixed mistake with modules lacking name inside dict

Signed-off-by: Ole Herman Schumacher Elgesem <ole.elgesem@northern.tech>

Author: olehermanse

cfbs/build.py

@@ -290,14 +290,14 @@ def _perform_build_step(module, i, step, max_length):
         assert len(args) == 4
         print("%s replace '%s'" % (prefix, "' '".join(args)))
         # New build step so let's be a bit strict about validating it:
-        validate_build_step(module, i, operation, args, strict=True)
+        validate_build_step(name, module, i, operation, args, strict=True)
         n, a, b, file = args
         file = os.path.join(destination, file)
         _perform_replace_step(n, a, b, file)
     elif operation == "replace_version":
         assert len(args) == 3
         # New build step so let's be a bit strict about validating it:
-        validate_build_step(module, i, operation, args, strict=True)
+        validate_build_step(name, module, i, operation, args, strict=True)
         print("%s replace_version '%s'" % (prefix, "' '".join(args)))
         n = args[0]
         to_replace = args[1]

cfbs/validate.py

@@ -190,8 +190,10 @@ def validate_config(config, empty_build_list_ok=False):
         return 1
 
 
-def validate_build_step(module, i, operation, args, strict=False):
-    name = module["name"]
+def validate_build_step(name, module, i, operation, args, strict=False):
+    assert type(name) is str
+    assert type(module) is not str
+    assert type(i) is int
     if not operation in AVAILABLE_BUILD_STEPS:
         raise CFBSValidationError(
             name,
@@ -402,7 +404,7 @@ def validate_steps(name, module):
                     name, '"steps" must be a list of non-empty / non-whitespace strings'
                 )
             operation, args = split_build_step(step)
-            validate_build_step(module, i, operation, args)
+            validate_build_step(name, module, i, operation, args)
 
     def validate_url_field(name, module, field):
         assert field in module