Skip to content

Commit 2fbbd6b

Browse files
jnthntatumcopybara-github
authored andcommitted
Re-enable conformance test for missing overload at runtime.
This was fixed previously, but conformance test wasn't re-enabled. PiperOrigin-RevId: 956129371
1 parent 08cc263 commit 2fbbd6b

1 file changed

Lines changed: 6 additions & 16 deletions

File tree

conformance/BUILD

Lines changed: 6 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -169,10 +169,6 @@ _TESTS_TO_SKIP = [
169169
"timestamps/duration_converters/get_milliseconds",
170170

171171
# Broken test cases which should be supported.
172-
# TODO(issues/112): Unbound functions result in empty eval response.
173-
"basic/functions/unbound",
174-
"basic/functions/unbound_is_runtime_error",
175-
176172
# TODO(issues/97): Parse-only qualified variable lookup "x.y" with binding "x.y" or "y" within container "x" fails
177173
"fields/qualified_identifier_resolution/qualified_ident,map_field_select,ident_with_longest_prefix_check,qualified_identifier_resolution_unchecked",
178174
"namespace/qualified/self_eval_qualified_lookup",
@@ -231,12 +227,6 @@ _TESTS_TO_SKIP_LEGACY = _TESTS_TO_SKIP + [
231227
"block_ext/basic/optional_message",
232228
]
233229

234-
_TESTS_TO_SKIP_CHECKED = [
235-
# block is a post-check optimization that inserts internal variables. The C++ type checker
236-
# needs support for a proper optimizer for this to work.
237-
# "block_ext",
238-
]
239-
240230
_TESTS_TO_SKIP_LEGACY_DASHBOARD = [
241231
# Future features for CEL 1.0
242232
# TODO(issues/119): Strong typing support for enums, specified but not implemented.
@@ -268,15 +258,15 @@ gen_conformance_tests(
268258
checked = True,
269259
data = _ALL_TESTS,
270260
modern = True,
271-
skip_tests = _TESTS_TO_SKIP_MODERN + _TESTS_TO_SKIP_CHECKED,
261+
skip_tests = _TESTS_TO_SKIP_MODERN,
272262
)
273263

274264
gen_conformance_tests(
275265
name = "conformance_legacy_checked",
276266
checked = True,
277267
data = _ALL_TESTS,
278268
modern = False,
279-
skip_tests = _TESTS_TO_SKIP_LEGACY + _TESTS_TO_SKIP_CHECKED,
269+
skip_tests = _TESTS_TO_SKIP_LEGACY,
280270
)
281271

282272
# select optimization is only supported for checked expressions.
@@ -286,7 +276,7 @@ gen_conformance_tests(
286276
data = _ALL_TESTS,
287277
modern = False,
288278
select_opt = True,
289-
skip_tests = _TESTS_TO_SKIP_LEGACY + _TESTS_TO_SKIP_CHECKED,
279+
skip_tests = _TESTS_TO_SKIP_LEGACY,
290280
)
291281

292282
gen_conformance_tests(
@@ -295,7 +285,7 @@ gen_conformance_tests(
295285
data = _ALL_TESTS,
296286
modern = True,
297287
select_opt = True,
298-
skip_tests = _TESTS_TO_SKIP_MODERN + _TESTS_TO_SKIP_CHECKED,
288+
skip_tests = _TESTS_TO_SKIP_MODERN,
299289
)
300290

301291
gen_conformance_tests(
@@ -304,7 +294,7 @@ gen_conformance_tests(
304294
data = _ALL_TESTS,
305295
enable_variadic_logical_operators = True,
306296
modern = True,
307-
skip_tests = _TESTS_TO_SKIP_MODERN + _TESTS_TO_SKIP_CHECKED,
297+
skip_tests = _TESTS_TO_SKIP_MODERN,
308298
)
309299

310300
gen_conformance_tests(
@@ -313,7 +303,7 @@ gen_conformance_tests(
313303
data = _ALL_TESTS,
314304
enable_variadic_logical_operators = True,
315305
modern = False,
316-
skip_tests = _TESTS_TO_SKIP_LEGACY + _TESTS_TO_SKIP_CHECKED,
306+
skip_tests = _TESTS_TO_SKIP_LEGACY,
317307
)
318308

319309
# Generates a bunch of `cc_test` whose names follow the pattern

0 commit comments

Comments
 (0)