Skip to content

Commit c76d3a2

Browse files
committed
Rename the ITransformer.close() method to dispose()
1 parent 6a96e40 commit c76d3a2

6 files changed

Lines changed: 21 additions & 21 deletions

File tree

src/FastTransformer.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -37,14 +37,14 @@ export class FastTransformer implements ITransformer {
3737
* @returns Resolves when this object is finally disposed.
3838
*/
3939
[Symbol.asyncDispose](): Promise<void> {
40-
return this.close();
40+
return this.dispose();
4141
}
4242

4343
/**
44-
* Closes this transformer.
45-
* @returns Resolves when the transformer has been closed.
44+
* Releases any resources associated with this object.
45+
* @returns Resolves when this object has been disposed.
4646
*/
47-
close(): Promise<void> {
47+
dispose(): Promise<void> {
4848
this.#process?.kill();
4949
this.#process = null;
5050
return Promise.resolve();

src/GulpPlugin.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,8 +34,8 @@ export class GulpPlugin extends Transform {
3434
this.#quiet = options.quiet ?? false;
3535
this.#transformer = (options.mode ?? TransformMode.Safe) == TransformMode.Fast ? new FastTransformer(binary) : new SafeTransformer(binary);
3636

37-
const close = async (): Promise<void> => { await this.#transformer.close(); };
38-
this.on("end", close).on("error", close); // eslint-disable-line @typescript-eslint/no-misused-promises
37+
const dispose = async (): Promise<void> => { await this.#transformer.dispose(); };
38+
this.on("end", dispose).on("error", dispose); // eslint-disable-line @typescript-eslint/no-misused-promises
3939
}
4040

4141
/**

src/ITransformer.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,10 +4,10 @@
44
export interface ITransformer extends AsyncDisposable {
55

66
/**
7-
* Closes this transformer.
8-
* @returns Resolves when the transformer has been closed.
7+
* Releases any resources associated with this object.
8+
* @returns Resolves when this object has been disposed.
99
*/
10-
close: () => Promise<void>;
10+
dispose: () => Promise<void>;
1111

1212
/**
1313
* Processes a PHP script.

src/SafeTransformer.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -31,14 +31,14 @@ export class SafeTransformer implements ITransformer {
3131
* @returns Resolves when this object is finally disposed.
3232
*/
3333
[Symbol.asyncDispose](): Promise<void> {
34-
return this.close();
34+
return this.dispose();
3535
}
3636

3737
/**
38-
* Closes this transformer.
39-
* @returns Resolves when the transformer has been closed.
38+
* Releases any resources associated with this object.
39+
* @returns Resolves when this object has been disposed.
4040
*/
41-
close(): Promise<void> {
41+
dispose(): Promise<void> {
4242
return Promise.resolve();
4343
}
4444

test/FastTransformer.Tests.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -6,12 +6,12 @@ import {after, describe, it} from "node:test";
66
* Tests the features of the {@link FastTransformer} class.
77
*/
88
describe("FastTransformer", () => {
9-
describe("close()", () => {
9+
describe("dispose()", () => {
1010
it("should not reject, even if called several times", async () => {
1111
const transformer = new FastTransformer;
1212
await doesNotReject(transformer.listen());
13-
await doesNotReject(transformer.close());
14-
await doesNotReject(transformer.close());
13+
await doesNotReject(transformer.dispose());
14+
await doesNotReject(transformer.dispose());
1515
});
1616
});
1717

@@ -32,7 +32,7 @@ describe("FastTransformer", () => {
3232
]);
3333

3434
const transformer = new FastTransformer;
35-
after(() => transformer.close());
35+
after(() => transformer.dispose());
3636

3737
for (const [key, value] of map) it(key, async () => {
3838
const output = await transformer.transform("res/Sample.php");

test/SafeTransformer.Tests.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -6,11 +6,11 @@ import {after, describe, it} from "node:test";
66
* Tests the features of the {@link SafeTransformer} class.
77
*/
88
describe("SafeTransformer", () => {
9-
describe("close()", () => {
9+
describe("dispose()", () => {
1010
it("should not reject, even if called several times", async () => {
1111
const transformer = new SafeTransformer;
12-
await doesNotReject(transformer.close());
13-
await doesNotReject(transformer.close());
12+
await doesNotReject(transformer.dispose());
13+
await doesNotReject(transformer.dispose());
1414
});
1515
});
1616

@@ -23,7 +23,7 @@ describe("SafeTransformer", () => {
2323
]);
2424

2525
const transformer = new SafeTransformer;
26-
after(() => transformer.close());
26+
after(() => transformer.dispose());
2727

2828
for (const [key, value] of map) it(key, async () => {
2929
const output = await transformer.transform("res/Sample.php");

0 commit comments

Comments
 (0)