Skip to content

Commit 18ea080

Browse files
committed
Fix regressions
1 parent 2d75fc5 commit 18ea080

5 files changed

Lines changed: 10 additions & 8 deletions

File tree

etc/ESLint.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@ export default defineConfig(
5656
"no-div-regex": "error",
5757
"no-duplicate-imports": "error",
5858
"no-else-return": "error",
59-
"no-empty-function": "error",
59+
"no-empty-function": "off",
6060
"no-eq-null": "off",
6161
"no-eval": "error",
6262
"no-extend-native": "error",

src/GulpPlugin.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,8 +34,8 @@ export class GulpPlugin extends Transform {
3434
this.#quiet = options.quiet ?? false;
3535
this.#transformer = (options.mode ?? TransformMode.Safe) == TransformMode.Fast ? new FastTransformer(binary) : new SafeTransformer(binary);
3636

37-
const dispose = async (): Promise<void> => { await this.#transformer.dispose(); };
38-
this.on("end", dispose).on("error", dispose); // eslint-disable-line @typescript-eslint/no-misused-promises
37+
const dispose = (): void => this.#transformer.dispose();
38+
this.on("end", dispose).on("error", dispose);
3939
}
4040

4141
/**

src/SafeTransformer.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,9 @@ export class SafeTransformer implements ITransformer {
3636
/**
3737
* Releases any resources associated with this object.
3838
*/
39-
dispose(): void {}
39+
dispose(): void {
40+
// Noop.
41+
}
4042

4143
/**
4244
* Processes a PHP script.

test/FastTransformer.Tests.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ import {after, describe, it} from "node:test";
77
*/
88
describe("FastTransformer", () => {
99
describe("dispose()", () => {
10-
it("should not reject, even if called several times", async () => {
10+
it("should not trigger any errors, even if called several times", async () => {
1111
const transformer = new FastTransformer;
1212
await doesNotReject(transformer.listen());
1313
transformer.dispose();
@@ -16,7 +16,7 @@ describe("FastTransformer", () => {
1616
});
1717

1818
describe("listen()", () => {
19-
it("should not reject, even if called several times", async () => {
19+
it("should not trigger any errors, even if called several times", async () => {
2020
using transformer = new FastTransformer;
2121
await doesNotReject(transformer.listen());
2222
await doesNotReject(transformer.listen());

test/SafeTransformer.Tests.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,13 @@
11
import {SafeTransformer} from "@cedx/php-minifier";
2-
import {doesNotReject, ok} from "node:assert/strict";
2+
import {ok} from "node:assert/strict";
33
import {after, describe, it} from "node:test";
44

55
/**
66
* Tests the features of the {@link SafeTransformer} class.
77
*/
88
describe("SafeTransformer", () => {
99
describe("dispose()", () => {
10-
it("should not reject, even if called several times", async () => {
10+
it("should not trigger any errors, even if called several times", () => {
1111
const transformer = new SafeTransformer;
1212
transformer.dispose();
1313
transformer.dispose();

0 commit comments

Comments
 (0)