Reduce noisy disabled analytics cache metrics

Author: ccf

src/primer/server/services/analytics_cache_service.py

@@ -74,11 +74,6 @@ def _disable_cache_client() -> None:
 def get_cached_json(namespace: str, params: dict[str, Any]) -> Any | None:
     client = _get_redis_client()
     if client is None:
-        record_counter(
-            "primer.analytics_cache.requests",
-            1,
-            {"namespace": namespace, "result": "disabled"},
-        )
         return None
     try:
         payload = client.get(_build_cache_key(namespace, params))
@@ -123,11 +118,6 @@ def set_cached_json(
 ) -> None:
     client = _get_redis_client()
     if client is None:
-        record_counter(
-            "primer.analytics_cache.writes",
-            1,
-            {"namespace": namespace, "result": "disabled"},
-        )
         return
     try:
         client.setex(

tests/test_analytics_cache_service.py

@@ -2,21 +2,37 @@
 
 
 def test_get_cached_json_returns_none_without_redis_url(monkeypatch):
+    counters: list[tuple[str, int | float, dict[str, str]]] = []
+
     monkeypatch.setattr(analytics_cache_service.settings, "analytics_cache_enabled", True)
     monkeypatch.setattr(analytics_cache_service.settings, "redis_url", "")
+    monkeypatch.setattr(
+        analytics_cache_service,
+        "record_counter",
+        lambda name, value, attributes=None: counters.append((name, value, attributes or {})),
+    )
     analytics_cache_service._redis_client = None
     analytics_cache_service._redis_disabled_until = None
 
     assert analytics_cache_service.get_cached_json("overview", {"team_id": None}) is None
+    assert counters == []
 
 
 def test_set_cached_json_noops_without_redis_url(monkeypatch):
+    counters: list[tuple[str, int | float, dict[str, str]]] = []
+
     monkeypatch.setattr(analytics_cache_service.settings, "analytics_cache_enabled", True)
     monkeypatch.setattr(analytics_cache_service.settings, "redis_url", "")
+    monkeypatch.setattr(
+        analytics_cache_service,
+        "record_counter",
+        lambda name, value, attributes=None: counters.append((name, value, attributes or {})),
+    )
     analytics_cache_service._redis_client = None
     analytics_cache_service._redis_disabled_until = None
 
     analytics_cache_service.set_cached_json("overview", {"team_id": None}, {"total_sessions": 1})
+    assert counters == []
 
 
 def test_get_cached_json_backs_off_after_redis_error(monkeypatch):