fix(java-dsl): Now triggers can throw AssertionErrors if they wish to fail the test, regardless of whether an Exception is expected from the trigger or not

Author: TimothyJones

packages/dsl-java/src/main/java/io/contract_testing/contractcase/internal/BoundaryTriggerMapper.java

@@ -27,6 +27,8 @@ public static <T> ITriggerFunction map(
       T ret;
       try {
         ret = trigger.call(interactionSetup);
+      } catch (AssertionError error) {
+        return ConnectorExceptionMapper.mapAsTriggerFailure(error);
       } catch (Exception e) {
         return ConnectorExceptionMapper.mapAsTriggerFailure(e);
       }
@@ -58,6 +60,8 @@ public static <T> ITriggerFunction map(Trigger<T> trigger,
             new RuntimeException(
                 "Expected the trigger to throw an exception, but it returned successfully. Result toString() was: "
                     + unexpectedResult.toString()));
+      } catch (AssertionError error) {
+        return ConnectorExceptionMapper.mapAsTriggerFailure(error);
       } catch (Exception triggerException) {
         try {
           testErrorResponseFunction.call(triggerException, interactionSetup);

packages/dsl-java/src/main/java/io/contract_testing/contractcase/internal/edge/ConnectorExceptionMapper.java

@@ -55,6 +55,16 @@ public static ConnectorFailure mapAsTriggerFailure(Exception e) {
     );
   }
 
+  public static ConnectorFailure mapAsTriggerFailure(Error e) {
+    return new ConnectorFailure(
+        ConnectorFailureKindConstants.CASE_TRIGGER_ERROR,
+        e.getMessage(),
+        "",
+        "UNDOCUMENTED",
+        stackTraceToString(e)
+    );
+  }
+
   public static ConnectorFailure mapAsVerifyFailure(Exception e) {
     return new ConnectorFailure(
         ConnectorFailureKindConstants.CASE_VERIFY_RETURN_ERROR,

packages/dsl-java/src/test/java/io/contract_testing/contractcase/test/FailingExampleTest.java

@@ -51,7 +51,7 @@ public class FailingExampleTest {
 
   @Test
   public void failingTrigger() {
-    // failure in runInteraction trigger should return configuration error
+    // exception in runInteraction trigger should return configuration error
     assertThatThrownBy(() -> {
       contract.runInteraction(
           new InteractionDefinition<>(
@@ -83,8 +83,8 @@ public void failingTrigger() {
         }
     );
     ;
-    // Failure in throwing interaction trigger should fail with verify error, as the
-    // trigger's failure is passed to it
+    // exception in throwing interaction trigger should fail with verify error, as the
+    // trigger's failure is passed to the verify method, which should fail the assertion.
     assertThatThrownBy(() -> {
       contract.runThrowingInteraction(
           new InteractionDefinition<>(
@@ -115,6 +115,39 @@ public void failingTrigger() {
             }
         );
 
+    // Assertion error in failure trigger should fail the test with configuration error
+    assertThatThrownBy(() -> {
+      contract.runThrowingInteraction(
+          new InteractionDefinition<>(
+              List.of(new InState("Server is broken")),
+              new WillSendHttpRequest(HttpExample.builder()
+
+                  .request(new NamedMatch(
+                      "Get health",
+                      new HttpRequest(HttpRequestExample.builder()
+                          .path("/health")
+                          .method("GET")
+                          .build())
+                  ))
+                  .response(new HttpResponse(HttpResponseExample.builder().status(503).build()))
+                  .build())
+          ),
+          IndividualFailedTestConfigBuilder.<String>builder()
+              .withProviderName("Java Example HTTP Server")
+              .withTrigger((interactionSetup) -> {
+                throw new AssertionError("This is meant to fail");
+              })
+              .withTestErrorResponse((exception, setupInfo) -> {
+                assertThat(exception.getMessage()).isEqualTo("The server is not ready");
+              })
+      );
+    }).isInstanceOf(ContractCaseConfigurationError.class)
+        .satisfies((e) -> {
+              assertThat(((HasUserFacingStackTrace) e).userFacingStackTrace())
+                  .contains("FailingExampleTest.java");
+            }
+        );
+
     assertThatThrownBy(() -> {
       contract.runInteraction(
           new InteractionDefinition<>(
@@ -148,6 +181,43 @@ public void failingTrigger() {
             }
         );
 
+    // Assertion error in success trigger should fail with configuration error
+    assertThatThrownBy(() -> {
+      contract.runInteraction(
+          new InteractionDefinition<>(
+              List.of(new InState("Server is up")),
+              new WillSendHttpRequest(HttpExample.builder()
+
+                  .request(new NamedMatch(
+                      "Get health",
+                      new HttpRequest(HttpRequestExample.builder()
+                          .path("/health")
+                          .method("GET")
+                          .build())
+                  ))
+                  .response(new HttpResponse(HttpResponseExample.builder()
+                      .status(200)
+                      .body(Map.ofEntries(Map.entry("status", "up")))
+                      .build()))
+                  .build())
+          ),
+          IndividualSuccessTestConfigBuilder.<String>builder()
+              .withProviderName("Java Example HTTP Server")
+              .withTrigger((interactionSetup) -> {
+                throw new AssertionError("This is meant to fail");
+              })
+              .withTestResponse((data, setupInfo) -> {
+                assertThat(data).isEqualTo("It doesn't equal this");
+              })
+      );
+    }).isInstanceOf(ContractCaseConfigurationError.class)
+        .satisfies((e) -> {
+              assertThat(((HasUserFacingStackTrace) e).userFacingStackTrace())
+                  .contains("FailingExampleTest.java");
+            }
+        );
+
+
     // Recording contract should throw an error
     assertThatThrownBy(contract::endRecord).