Skip to content

Commit 3dd94e9

Browse files
authored
Align workflows and reduce permissions (#30)
Packages read is not required for XFlights builds
1 parent aa650c6 commit 3dd94e9

4 files changed

Lines changed: 8 additions & 15 deletions

File tree

.github/workflows/cf.yaml

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@ on:
1414
permissions:
1515
contents: read
1616
deployments: write
17-
packages: read
1817

1918
concurrency:
2019
group: cf-${{ github.workflow }}-${{ github.head_ref || github.run_id }}
@@ -45,8 +44,6 @@ jobs:
4544
username: ${{ vars.CF_USERNAME }}
4645
password: ${{ secrets.CF_PASSWORD }}
4746
- run: npm install
48-
env:
49-
NODE_AUTH_TOKEN: ${{secrets.GITHUB_TOKEN}}
5047

5148
- run: npx cds up
5249

.github/workflows/maven-publish-snapshot.yml

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -7,14 +7,13 @@ on:
77
push:
88
branches: [ "main" ]
99

10+
permissions:
11+
contents: read
12+
packages: write
13+
1014
jobs:
1115
build:
12-
1316
runs-on: ubuntu-latest
14-
permissions:
15-
contents: read
16-
packages: write
17-
1817
steps:
1918
- uses: actions/checkout@v6
2019
- name: Set up JDK
@@ -32,4 +31,4 @@ jobs:
3231
working-directory: apis/data-service
3332
run: mvn deploy -s $GITHUB_WORKSPACE/settings.xml
3433
env:
35-
GITHUB_TOKEN: ${{ github.token }}
34+
GITHUB_TOKEN: ${{secrets.GITHUB_TOKEN}}

.github/workflows/maven.yml

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -3,19 +3,17 @@
33

44
name: Java CI with Maven
55

6-
permissions:
7-
contents: read
8-
96
on:
107
workflow_call:
118
pull_request:
129
branches: [ "main" ]
1310

11+
permissions:
12+
contents: read
13+
1414
jobs:
1515
build:
16-
1716
runs-on: ubuntu-latest
18-
1917
steps:
2018
- uses: actions/checkout@v6
2119
- name: Set up JDK

.github/workflows/release.yaml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@ on:
88
permissions:
99
contents: read
1010
deployments: write
11-
packages: read
1211

1312
jobs:
1413
tests:

0 commit comments

Comments
 (0)