fix: install properly packages and pass environment variables

Author: szymonrybczak

.github/actions/find-artifact/action.yml

@@ -1,8 +1,8 @@
-name: 'Find Artifact'
-description: 'Find the latest artifact'
+name: "Find Artifact"
+description: "Find the latest artifact"
 inputs:
   name:
-    description: 'Artifact name'
+    description: "Artifact name"
     required: false
   re-sign:
     description: Re-sign the app bundle with new JS bundle
@@ -19,17 +19,27 @@ inputs:
     default: ${{ github.repository }}
 outputs:
   artifact-id:
-    description: 'The ID of the artifact'
+    description: "The ID of the artifact"
+    value: ${{ steps.find-artifact.outputs.artifact-id }}
   artifact-url:
-    description: 'The URL of the artifact'
+    description: "The URL of the artifact"
+    value: ${{ steps.find-artifact.outputs.artifact-url }}
   artifact-ids:
-    description: 'All IDs of the artifacts matching the name'
+    description: "All IDs of the artifacts matching the name"
+    value: ${{ steps.find-artifact.outputs.artifact-ids }}
 runs:
-  using: 'composite'
+  using: "composite"
   steps:
     - name: Install dependencies
       run: npm install
       shell: bash
-    - name: Run find artifact
-      run: node index.js
+      working-directory: ${{ github.action_path }}
+    - name: Find artifact
+      id: find-artifact
+      env:
+        INPUT_NAME: ${{ inputs.name }}
+        INPUT_RE_SIGN: ${{ inputs.re-sign }}
+        INPUT_GITHUB_TOKEN: ${{ inputs.github-token }}
+        INPUT_REPOSITORY: ${{ inputs.repository }}
+      run: node ${{ github.action_path }}/index.mjs
       shell: bash

.github/actions/find-artifact/index.js .github/actions/find-artifact/index.mjs.github/actions/find-artifact/index.js renamed to .github/actions/find-artifact/index.mjs

@@ -1,5 +1,5 @@
-const core = require('@actions/core');
-const github = require('@actions/github');
+import * as core from "@actions/core";
+import * as github from "@actions/github";
 
 const perPage = 100; // Maximum allowed by GitHub API
 
@@ -9,8 +9,8 @@ async function fetchArtifacts(octokit, repository, name) {
 
   while (true) {
     const response = await octokit.rest.actions.listArtifactsForRepo({
-      owner: repository.split('/')[0],
-      repo: repository.split('/')[1],
+      owner: repository.split("/")[0],
+      repo: repository.split("/")[1],
       name,
       per_page: perPage,
       page,
@@ -31,18 +31,31 @@ async function fetchArtifacts(octokit, repository, name) {
 }
 
 function getPrNumber() {
-  if (github.context.eventName === 'pull_request') {
+  if (github.context.eventName === "pull_request") {
     return github.context.payload.pull_request.number;
   }
   return undefined;
 }
 
 async function run() {
   try {
-    const token = core.getInput('github-token');
-    const repository = core.getInput('repository');
-    const name = core.getInput('name');
-    const reSign = core.getInput('re-sign');
+    const token = core.getInput("github_token") || process.env.GITHUB_TOKEN;
+
+    if (!token) {
+      throw new Error("GitHub token is required");
+    }
+
+    const repository = core.getInput("repository");
+    if (!repository) {
+      throw new Error("Repository is required");
+    }
+
+    const name = core.getInput("name");
+    if (!name) {
+      throw new Error("Artifact name is required");
+    }
+
+    const reSign = core.getInput("re_sign");
     const prNumber = getPrNumber();
 
     const octokit = github.getOctokit(token);
@@ -61,20 +74,20 @@ async function run() {
     for (const artifact of artifacts) {
       console.log(
         `- ID: ${artifact.id}, Name: ${artifact.name}, Size: ${formatSize(
-          artifact.size_in_bytes,
-        )}, Expires at: ${artifact.expires_at}`,
+          artifact.size_in_bytes
+        )}, Expires at: ${artifact.expires_at}`
       );
     }
 
-    const firstArtifact = artifacts.find(artifact => !artifact.expired);
+    const firstArtifact = artifacts.find((artifact) => !artifact.expired);
     console.log(`First artifact: ${JSON.stringify(firstArtifact, null, 2)}`);
 
     const url = formatDownloadUrl(
       repository,
       firstArtifact.workflow_run.id,
-      firstArtifact.id,
+      firstArtifact.id
     );
-    console.log('Stable download URL:', url);
+    console.log("Stable download URL:", url);
 
     let artifactName = name;
     // There are artifacts from PR but the base artifact is gone, recreate with the original name
@@ -84,12 +97,12 @@ async function run() {
     } else if (prNumber && reSign) {
       artifactName = `${name}-${prNumber}`;
     }
-    core.setOutput('artifact-name', artifactName);
-    core.setOutput('artifact-id', firstArtifact.id);
-    core.setOutput('artifact-url', url);
+    core.setOutput("artifact-name", artifactName);
+    core.setOutput("artifact-id", firstArtifact.id);
+    core.setOutput("artifact-url", url);
     core.setOutput(
-      'artifact-ids',
-      artifactsByPrNumber.map(artifact => artifact.id).join(' '),
+      "artifact-ids",
+      artifactsByPrNumber.map((artifact) => artifact.id).join(" ")
     );
   } catch (error) {
     core.setFailed(`Action failed with error: ${error.message}`);

.github/actions/rnef-native-fingerprint/action.yml

@@ -11,12 +11,18 @@ inputs:
 outputs:
   hash:
     description: 'The fingerprint hash'
+    value: ${{ steps.fingerprint.outputs.hash }}
 runs:
-  using: 'composite'
+  using: "composite"
   steps:
     - name: Install dependencies
       run: npm install
       shell: bash
+      working-directory: ${{ github.action_path }}
     - name: Run fingerprint
-      run: node index.mjs
+      id: fingerprint
+      env:
+        INPUT_PLATFORM: ${{ inputs.platform }}
+        INPUT_WORKING_DIRECTORY: ${{ inputs.working-directory }}
+      run: node ${{ github.action_path }}/index.mjs
       shell: bash

.github/actions/rnef-native-fingerprint/package.json

@@ -4,6 +4,7 @@
   "description": "Generate native fingerprint for RNEF builds",
   "main": "index.mjs",
   "dependencies": {
+    "@rnef/config": "^0.4.1",
     "@actions/core": "^1.11.1"
   }
 } 

.github/actions/rnef-post-build/action.yml

@@ -13,11 +13,17 @@ inputs:
     required: false
     default: ${{ github.token }}
 runs:
-  using: 'composite'
+  using: "composite"
   steps:
     - name: Install dependencies
       run: npm install
       shell: bash
-    - name: Run post build
-      run: node index.js
+      working-directory: ${{ github.action_path }}
+    - name: Post build
+      id: post-build
+      env:
+        INPUT_ARTIFACT_URL: ${{ inputs.artifact-url }}
+        INPUT_TITLE: ${{ inputs.title }}
+        INPUT_GITHUB_TOKEN: ${{ inputs.github-token }}
+      run: node ${{ github.action_path }}/index.mjs
       shell: bash

.github/actions/rnef-post-build/index.js .github/actions/rnef-post-build/index.mjs.github/actions/rnef-post-build/index.js renamed to .github/actions/rnef-post-build/index.mjs

@@ -1,10 +1,21 @@
-const core = require('@actions/core');
-const github = require('@actions/github');
+import * as core from '@actions/core';
+import * as github from '@actions/github';
 
 async function run() {
-  const token = core.getInput('github-token');
-  const titleInput = core.getInput('title');
-  const artifactUrl = core.getInput('artifact-url');
+  const token = core.getInput("github_token") || process.env.GITHUB_TOKEN;
+  if (!token) {
+    throw new Error("GitHub token is required");
+  }
+
+  const titleInput = core.getInput("title");
+  if (!titleInput) {
+    throw new Error("Title is required");
+  }
+
+  const artifactUrl = core.getInput("artifact_url");
+  if (!artifactUrl) {
+    throw new Error("Artifact URL is required");
+  }
 
   const title = `## ${titleInput}`;
   const body = `🔗 [Download link](${artifactUrl}).\n\n

action.yml

@@ -102,7 +102,7 @@ runs:
 
     - name: Native Fingerprint
       id: fingerprint
-      uses: callstackincubator/ios/.github/actions/rnef-native-fingerprint@v1
+      uses: callstackincubator/ios/.github/actions/rnef-native-fingerprint@fix/composite
       with:
         platform: ios
         working-directory: ${{ inputs.working-directory }}
@@ -114,10 +114,11 @@ runs:
 
     - name: Find artifact URL
       id: find-artifact
-      uses: callstackincubator/ios/.github/actions/find-artifact@v1
+      uses: callstackincubator/ios/.github/actions/find-artifact@fix/composite
       with:
         name: ${{ env.ARTIFACT_NAME }}
         re-sign: ${{ inputs.re-sign }}
+        github-token: ${{ inputs.github-token }}
 
     - name: Set Provisioning Profile Path
       run: |
@@ -256,7 +257,8 @@ runs:
 
     - name: Post Build
       if: ${{ github.event_name == 'pull_request' && inputs.comment-bot == 'true' }}
-      uses: callstackincubator/ios/.github/actions/rnef-post-build@v1
+      uses: callstackincubator/ios/.github/actions/rnef-post-build@fix/composite
       with:
         title: iOS ${{ inputs.configuration }} ${{ inputs.destination == 'simulator' && 'APP for simulators' || 'IPA for physical devices' }}
         artifact-url: ${{ steps.upload-artifact.outputs.artifact-url || steps.find-artifact.outputs.artifact-url }}
+        github-token: ${{ inputs.github-token }}

package.json

@@ -1,7 +1,7 @@
 {
   "name": "action-ios",
   "version": "1.0.0",
-  "description": "GitHub Action for building iOS applications using RNEF (React Native EAS Fastlane)",
+  "description": "GitHub Action for building iOS applications using RNEF (React Native Enterprise Framework)",
   "main": "index.js",
   "author": "",
   "license": "MIT",