diff --git a/.changeset/frank-chairs-grin.md b/.changeset/frank-chairs-grin.md new file mode 100644 index 00000000..dc408ffc --- /dev/null +++ b/.changeset/frank-chairs-grin.md @@ -0,0 +1,7 @@ +--- +'brownfield': minor +'@callstack/brownfield-cli': minor +'@callstack/react-native-brownfield': minor +--- + +feat: strip SO files by default, deprecate experimental option in favor of useStrippedSoFiles diff --git a/gradle-plugins/react/brownfield/src/main/kotlin/com/callstack/react/brownfield/processors/JNILibsProcessor.kt b/gradle-plugins/react/brownfield/src/main/kotlin/com/callstack/react/brownfield/processors/JNILibsProcessor.kt index a38e1a43..36bf47d0 100644 --- a/gradle-plugins/react/brownfield/src/main/kotlin/com/callstack/react/brownfield/processors/JNILibsProcessor.kt +++ b/gradle-plugins/react/brownfield/src/main/kotlin/com/callstack/react/brownfield/processors/JNILibsProcessor.kt @@ -53,7 +53,7 @@ class JNILibsProcessor : BaseProject() { for (archiveLibrary in aarLibraries) { val jniDir = archiveLibrary.getJniDir() processNestedLibs(jniDir.listFiles(), existingJNILibs) - if (projectExt.experimentalUseStrippedSoFiles) { + if (projectExt.useStrippedSoFiles) { copyStrippedSoLibs(variant, existingJNILibs) } else { if (jniDir.exists()) { diff --git a/gradle-plugins/react/brownfield/src/main/kotlin/com/callstack/react/brownfield/utils/Extension.kt b/gradle-plugins/react/brownfield/src/main/kotlin/com/callstack/react/brownfield/utils/Extension.kt index 12c2686b..909d6578 100644 --- a/gradle-plugins/react/brownfield/src/main/kotlin/com/callstack/react/brownfield/utils/Extension.kt +++ b/gradle-plugins/react/brownfield/src/main/kotlin/com/callstack/react/brownfield/utils/Extension.kt @@ -34,7 +34,7 @@ open class Extension { * List of dynamic libs (.so) files that you wish to bundle with * the aar. * - * By default only `libappmodules.so` and `libreact_codegen_*.so` are + * By default, only `libappmodules.so` and `libreact_codegen_*.so` are * bundled. */ var dynamicLibs = listOf() @@ -42,7 +42,20 @@ open class Extension { /** * Whether to use stripped .so files. * - * Default value is `false` + * Default is `true`. */ - var experimentalUseStrippedSoFiles = false + var useStrippedSoFiles = true + + @Deprecated( + message = + "This property is deprecated and will be removed in a future release." + + "The successor is useStrippedSoFiles, which is by default true.", + replaceWith = ReplaceWith("useStrippedSoFiles"), + level = DeprecationLevel.WARNING, + ) + var experimentalUseStrippedSoFiles + get() = useStrippedSoFiles + set(value) { + useStrippedSoFiles = value + } } diff --git a/gradle-plugins/react/example-android-library/build.gradle.kts b/gradle-plugins/react/example-android-library/build.gradle.kts index 6f74cb3f..1b0390d2 100644 --- a/gradle-plugins/react/example-android-library/build.gradle.kts +++ b/gradle-plugins/react/example-android-library/build.gradle.kts @@ -1,4 +1,3 @@ - plugins { id("com.android.library") id("org.jetbrains.kotlin.android")