Compatibility with FreeCam mods

[Zergatul]

I am developer of one of FreeCam mods. We know that typical FreeCam mod creates fake player entity in spectator gamemode. And baritone ComeCommand works fine with it by using BaritonePlayerContext.viewerPos method, which returns fake entity position in this case.

However my FreeCam mod uses 3rd person view, and moves ingame Camera object without creating any fake entities. This is why current baritone approach doesn't work with my FreeCam. Can we make improvement to support both cases?

The simplest way to achieve this would be to use Camera position, not entity position. Such change will affect ComeCommand and SelCommand. If player is in first person, camera position is one block above old method. This is not good if baritone users get used to old behavior. I am in doubts. I can definitely make mixin into baritone from my mods, but maybe you have smarter ideas.

[TheSenor]

I'm experiencing the same issue with the latest game version. Baritone doesn't work properly with Freecam when I try to set selection positions while flying around in Freecam mode, it sets them based on the player entity's location instead of the camera position.

Not sure if this is a Freecam mod issue or a Baritone limitation, but it makes the #sel pos1 / #sel pos2 commands unusable when scouting areas in Freecam.

Steps to reproduce:

• Enable Freecam and fly away from your player
• Run #sel pos1 at the camera location
• Position gets set at the player entity instead of where the camera is
• Would appreciate any guidance on whether this can be fixed on Baritone's side or if it requires changes to how Freecam mods work. Thanks!

[ZacSharp]

Doing a mixin from your mod is certainly a solution, if you can do that (ProGuard might get in your way).

When in FreeCam, what does Camera.isDetached return? If it's false we might be able to do something like cam.isDetached() ? ctx.playerFeet() : BlockPos.containing(cam.position().add(0, -playerEyeHeight, 0)), but honestly, the camera position is also interpolated when pressing shift and moves around for other reasons. Trying to reconstruct the player position from it seems fragile, so maybe just add a hook to allow FreeCam mods to override the position, similar to logger, notifier and toaster?