Remove stale golangci-lint exclusions (#4409)

Author: pkwarren

.golangci.yml

@@ -51,7 +51,7 @@ linters:
       forbid:
         # Use private/pkg/thread.Parallelize
         - pattern: ^errgroup\.
-        # Use private/pkg/standard/xos/xexec
+        # Use buf.build/go/standard/xos/xexec
         - pattern: ^exec\.Cmd$
         - pattern: ^exec\.Command$
         - pattern: ^exec\.CommandContext$
@@ -132,11 +132,6 @@ linters:
         # This is a legacy usage of os.Getwd we're not bothering to port yet.
         path: cmd/buf/internal/command/alpha/protoc/protoc_test.go
         text: os.Getwd
-      - linters:
-          - dogsled
-        # One function call doesn't care about most of the returned destructured values. The
-        # dogsled linter complains about it. (Value of this linter is unclear...)
-        path: cmd/buf/internal/command/curl/curl.go
       - linters:
           - forbidigo
         # This is a legacy usage of os.Getwd we're not bothering to port yet.
@@ -153,11 +148,6 @@ linters:
         # trip this off.
         path: private/buf/bufcli/env.go
         text: "G101:"
-      - linters:
-          - gosec
-        # G404 checks for use of the ordinary non-CPRNG.
-        path: private/buf/buflsp/progress.go
-        text: "G404:"
       - linters:
           - gosec
         # G115 checks for use of truncating conversions.
@@ -173,11 +163,6 @@ linters:
         # G115 checks for use of truncating conversions.
         path: private/buf/buflsp/image.go
         text: "G115:"
-      - linters:
-          - gosec
-        # G115 checks for use of truncating conversions.
-        path: private/buf/buflsp/report.go
-        text: "G115:"
       - linters:
           - gosec
         # G115 checks for use of truncating conversions.
@@ -262,43 +247,16 @@ linters:
           - containedctx
         # we actually want to embed a context here
         path: private/bufpkg/bufmodule/module_set_builder.go
-      - linters:
-          - containedctx
-        # we actually want to embed a context here
-        path: private/pkg/standard/xos/xexec/process.go
       - linters:
           - gochecknoinits
         # we actually want to use init here
         path: private/bufpkg/bufmodule/paths.go
-      - linters:
-          - forbidigo
-        # we want to use errgroup here
-        path: private/bufpkg/bufremoteplugin/bufremoteplugindocker/docker.go
-        text: use of `errgroup
-      - linters:
-          - forbidigo
-        # this is one of two files we want to allow exec.Cmd functions in
-        path: private/pkg/standard/xos/xexec/xexec.go
-      - linters:
-          - forbidigo
-        # this is one of two files we want to allow exec.Cmd functions in
-        path: private/pkg/standard/xos/xexec/process.go
-      - linters:
-          - gosec
-        # G204 checks that exec.Command is not called with non-constants.
-        path: private/pkg/standard/xos/xexec/xexec.go
-        text: "G204:"
       - linters:
           - gosec
         # We should be able to use net/http/cgi in a unit test, in addition the CVE mentions
         # only versions of go < 1.6.3 are affected.
         path: private/pkg/git/git_test.go
         text: "G504:"
-      - linters:
-          - wastedassign
-        # netrc/internal is a library largely copied in from an external repository with attribution.
-        # We try to make minimal edits.
-        path: private/pkg/netrc/internal/internal.go
       - linters:
           - forbidigo
         # We cache os.Getwd in osext, osext is the entrypoint.
@@ -309,23 +267,11 @@ linters:
         # We cache os.Getwd in osext, osext has a Chdir that clears the cache.
         path: private/pkg/osext/osext.go
         text: os.Chdir
-      - linters:
-          - forbidigo
-        # We're going to move xfilepath out.
-        path: private/pkg/standard/xpath/xfilepath/xfilepath.go
-        text: os.Getwd
       - linters:
           - gochecknoinits
         # protoencoding calls detrand.Disable via go:linkname and and init function. See the comments
         # in the file for more details.
         path: private/pkg/protoencoding/detrand.go
-      - linters:
-          - errcheck
-        # headers.go has casts with values from contexts that should fail if there
-        # is no error, but it would be very unidiomatic to return an error from
-        # the functions that do these casts, and we completely control the
-        # context values within this file
-        path: private/pkg/rpc/headers.go
       - linters:
           - forbidigo
         # we use os.Rename here to rename files in the same directory
@@ -337,37 +283,18 @@ linters:
         # connCtx is cancelled when the connection is done; the context lifetime is
         # tied to the struct, not passed per-call.
         path: private/buf/buflsp/buflsp.go
-      - linters:
-          - containedctx
-        # we actually want to embed a context here
-        path: private/pkg/transport/grpc/grpcclient/client_conn_provider.go
       - linters:
           - forbidigo
         # we actually want to use errgroup when starting an HTTP server
         path: private/pkg/transport/http/httpserver/httpserver.go
       - linters:
           - staticcheck
         text: "ST1005:"
-      - linters:
-          - gochecknoinits
-        # we actually want to use this init
-        path: private/usage/usage.go
-      - linters:
-          - staticcheck
-        # We deprecated all the definitions in plugin.proto but we still implement them.
-        text: buf/alpha/registry/v1alpha1/plugin.proto is marked as deprecated
-      - linters:
-          - staticcheck
-        # We deprecated all the definitions in generate.proto but we still implement them.
-        text: buf/alpha/registry/v1alpha1/generate.proto is marked as deprecated
       - linters:
           - staticcheck
         # This greatly simplifies creation of descriptors, and it's safe enough since
         # it's just test code.
         text: GetDeprecatedLegacyJsonFieldConflicts is deprecated
-      - linters:
-          - forcetypeassert
-        path: private/bufpkg/bufimage/source_retention_options_test\.go
       - linters:
           - paralleltest
         # The LsModules tests call chdir and cannot be parallelized.
@@ -476,12 +403,6 @@ linters:
         # to set the source path for the location, this operation should be safe.
         path: private/bufpkg/bufcheck/bufcheckserver/internal/buflintvalidate/predefined_rules.go
         text: "G115:"
-      - linters:
-          - govet
-        # We print command.Short to markdown, which is controlled and set by each command
-        # and should be considered safe.
-        path: private/bufpkg/bufcobra/markdown.go
-        text: "printf: non-constant format string in call to p"
       - linters:
           - gosec
         # This converts slice indexes in a FileDescriptorProto to int32,