Skip to content

Commit c4ac1fd

Browse files
paddymulclaude
andcommitted
perf: upgrade AG Grid v34 → v35
Add suppressNoRowsOverlay to infinite row model grid options (v35 adds default overlays that flash during data loading). ESM bundle: 1,773 KB → 1,827 KB (+3%) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
1 parent 3f765da commit c4ac1fd

3 files changed

Lines changed: 18 additions & 17 deletions

File tree

packages/buckaroo-js-core/package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,8 +30,8 @@
3030
"/dist"
3131
],
3232
"dependencies": {
33-
"ag-grid-community": "^34.3.1",
34-
"ag-grid-react": "^34.3.1",
33+
"ag-grid-community": "^35.1.0",
34+
"ag-grid-react": "^35.1.0",
3535
"hyparquet": "^1.8.2",
3636
"lodash-es": "^4.17.21",
3737
"recharts": "^2.13.1"

packages/buckaroo-js-core/src/components/DFViewerParts/DFViewerInfinite.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -420,6 +420,7 @@ const getDsGridOptions = (origGridOptions: GridOptions, maxRowsWithoutScrolling:
420420
const dsGridOptions: GridOptions = {
421421
...origGridOptions,
422422
animateRows:false,
423+
suppressNoRowsOverlay: true,
423424
onSortChanged: (event: SortChangedEvent) => {
424425
const api: GridApi = event.api;
425426
//@ts-ignore

packages/pnpm-lock.yaml

Lines changed: 15 additions & 15 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)