Skip to content

Commit 564e20d

Browse files
paddymulclaude
andcommitted
perf: upgrade AG Grid v32 → v33
Consolidate 6 @ag-grid-community/* packages into 2 unified packages (ag-grid-community + ag-grid-react). v33 improves internal tree-shaking. - Rewrite all imports across 16 source files - Rename CSS variables: --ag-grid-size → --ag-spacing, --ag-alpine-active-color → --ag-accent-color, --ag-range-selection-background-color-3 → --ag-range-selection-background-color - ESM bundle: 2,277 KB → 1,722 KB (-24.4%) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
1 parent d38c79b commit 564e20d

18 files changed

Lines changed: 64 additions & 114 deletions

packages/buckaroo-js-core/package.json

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -30,12 +30,8 @@
3030
"/dist"
3131
],
3232
"dependencies": {
33-
"@ag-grid-community/client-side-row-model": "^32.3.9",
34-
"@ag-grid-community/core": "^32.3.9",
35-
"@ag-grid-community/infinite-row-model": "^32.3.9",
36-
"@ag-grid-community/react": "^32.3.9",
37-
"@ag-grid-community/styles": "^32.3.9",
38-
"@ag-grid-community/theming": "^32.3.9",
33+
"ag-grid-community": "^33.3.2",
34+
"ag-grid-react": "^33.3.2",
3935
"hyparquet": "^1.8.2",
4036
"lodash-es": "^4.17.21",
4137
"recharts": "^2.13.1"

packages/buckaroo-js-core/src/components/BuckarooWidgetInfinite.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ import {
1515
IDisplayArgs
1616
} from "./DFViewerParts/gridUtils";
1717
import { DatasourceOrRaw, DFViewerInfinite } from "./DFViewerParts/DFViewerInfinite";
18-
import { IDatasource } from "@ag-grid-community/core";
18+
import { IDatasource } from "ag-grid-community";
1919
import { KeyAwareSmartRowCache, PayloadArgs, PayloadResponse, RequestFN } from "./DFViewerParts/SmartRowCache";
2020
import { parquetRead, parquetMetadata } from 'hyparquet'
2121
import { MessageBox } from "./MessageBox";

packages/buckaroo-js-core/src/components/DFViewerParts/DFViewerDataHelper.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import { IDatasource, IGetRowsParams } from "@ag-grid-community/core";
1+
import { IDatasource, IGetRowsParams } from "ag-grid-community";
22
import { keys, times, reduce } from "lodash-es";
33

44
export type RawDataWrapper = {

packages/buckaroo-js-core/src/components/DFViewerParts/DFViewerInfinite.tsx

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ import { DFData, DFDataRow, DFViewerConfig, SDFT } from "./DFWhole";
88

99
import { getCellRendererSelector, dfToAgrid, extractPinnedRows, extractSDFT } from "./gridUtils";
1010

11-
import { AgGridReact } from "@ag-grid-community/react"; // the AG Grid React Component
11+
import { AgGridReact } from "ag-grid-react"; // the AG Grid React Component
1212
import {
1313
GetRowIdParams,
1414
GridApi,
@@ -18,10 +18,9 @@ import {
1818
SortChangedEvent,
1919
CellClassParams,
2020
RefreshCellsParams,
21-
//ColDef,
22-
} from "@ag-grid-community/core";
23-
import { ClientSideRowModelModule } from "@ag-grid-community/client-side-row-model";
24-
import { InfiniteRowModelModule } from "@ag-grid-community/infinite-row-model";
21+
ClientSideRowModelModule,
22+
InfiniteRowModelModule,
23+
} from "ag-grid-community";
2524

2625
import {
2726
getAutoSize,

packages/buckaroo-js-core/src/components/DFViewerParts/DFWhole.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
// I'm not sure about adding underlying types too
22

3-
import { ColDef, ColGroupDef, GridOptions } from "@ag-grid-community/core";
3+
import { ColDef, ColGroupDef, GridOptions } from "ag-grid-community";
44

55
type AGGrid_ColDef = ColDef;
66
export type ColDefOrGroup = ColDef|ColGroupDef

packages/buckaroo-js-core/src/components/DFViewerParts/Displayer.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import { ValueFormatterFunc, ValueFormatterParams } from "@ag-grid-community/core";
1+
import { ValueFormatterFunc, ValueFormatterParams } from "ag-grid-community";
22
import {
33
DisplayerArgs,
44
cellRendererDisplayers,

packages/buckaroo-js-core/src/components/DFViewerParts/HistogramCell.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ import { createPortal } from "react-dom";
44

55
import { Bar, BarChart, Tooltip } from "recharts";
66
import { getChartColors } from "./ChartCell";
7-
import { ColDef, Column, Context, GridApi } from "@ag-grid-community/core";
7+
import { ColDef, Column, Context, GridApi } from "ag-grid-community";
88
import { useColorScheme } from "../useColorScheme";
99

1010
export interface HistogramNode {

packages/buckaroo-js-core/src/components/DFViewerParts/OtherRenderers.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import { ValueFormatterFunc } from "@ag-grid-community/core";
1+
import { ValueFormatterFunc } from "ag-grid-community";
22

33
export const getTextCellRenderer = (formatter: ValueFormatterFunc<any>) => {
44
const TextCellRenderer = (props: any) => {

packages/buckaroo-js-core/src/components/DFViewerParts/SeriesSummaryTooltip.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import { DFViewer } from "./DFViewerInfinite";
22
import { DFWhole, TooltipConfig } from "./DFWhole";
3-
import { ITooltipParams } from "@ag-grid-community/core";
3+
import { ITooltipParams } from "ag-grid-community";
44

55
export function getBakedDFViewer(seriesDf: DFWhole) {
66
const retFunc = (_props: ITooltipParams) => {

packages/buckaroo-js-core/src/components/DFViewerParts/Styler.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import {
22
CellClassParams,
3-
} from "@ag-grid-community/core";
3+
} from "ag-grid-community";
44

55
import { BLUE_TO_YELLOW, DIVERGING_RED_WHITE_BLUE } from "../../baked_data/colorMap";
66
import {

0 commit comments

Comments
 (0)