Use TaskKey object to simplify api cognitive load

Author: brthor

TaskScheduler.cs

@@ -69,7 +69,7 @@ public async Task Tick(bool forceRunPromotion=false)
 
         public async Task<ScheduledTask> AddScheduledTask(Expression<Action> action, TimeSpan offsetFromNow)
         {
-            var scheduledTask = new ScheduledTask(action.ToTaskInfo(), offsetFromNow, UniqueTaskKey());
+            var scheduledTask = new ScheduledTask(action.ToTaskInfo(), offsetFromNow, TaskKey.CreateUnique());
 
             await EnqueueScheduledTask(scheduledTask);
 
@@ -78,7 +78,7 @@ public async Task<ScheduledTask> AddScheduledTask(Expression<Action> action, Tim
 
         public async Task<ScheduledTask> AddScheduledTask(Expression<Action> action, DateTimeOffset scheduledTime)
         {
-            var scheduledTask = new ScheduledTask(action.ToTaskInfo(), scheduledTime, UniqueTaskKey());
+            var scheduledTask = new ScheduledTask(action.ToTaskInfo(), scheduledTime, TaskKey.CreateUnique());
 
             await EnqueueScheduledTask(scheduledTask);
 
@@ -87,7 +87,7 @@ public async Task<ScheduledTask> AddScheduledTask(Expression<Action> action, Dat
 
         public async Task<ScheduledTask> AddScheduledTask(Expression<Action> action, DateTime scheduledTime)
         {
-            var scheduledTask = new ScheduledTask(action.ToTaskInfo(), scheduledTime, UniqueTaskKey());
+            var scheduledTask = new ScheduledTask(action.ToTaskInfo(), scheduledTime, TaskKey.CreateUnique());
 
             await EnqueueScheduledTask(scheduledTask);
 
@@ -96,7 +96,8 @@ public async Task<ScheduledTask> AddScheduledTask(Expression<Action> action, Dat
 
         public async Task<RecurringTask> AddRecurringTask(Expression<Action> action, TimeSpan interval, string taskName)
         {
-            var recurringTask = new RecurringTask(action.ToTaskInfo(), interval, RecurringTaskKey(taskName));
+            var recurringTask = new RecurringTask(action.ToTaskInfo(), interval, 
+                TaskKey.CreateRecurring(taskName));
 
             if (await RecurringTaskDoesNotExistOrNeedsChange(recurringTask)) 
             {
@@ -109,7 +110,8 @@ public async Task<RecurringTask> AddRecurringTask(Expression<Action> action, Tim
 
         public async Task<RecurringTask> AddRecurringTask(Expression<Action> action, string crontab, string taskName)
         {
-            var recurringTask = new RecurringTask(action.ToTaskInfo(), crontab, RecurringTaskKey(taskName));
+            var recurringTask = new RecurringTask(action.ToTaskInfo(), crontab, 
+                TaskKey.CreateRecurring(taskName));
 
             if (await RecurringTaskDoesNotExistOrNeedsChange(recurringTask)) 
             {
@@ -126,7 +128,7 @@ public async Task<bool> CancelRecurringTask(RecurringTask recurringTask)
 
         public async Task<bool> CancelRecurringTask(string taskName) 
         {
-            return await CancelTask(RecurringTaskKey(taskName));
+            return await CancelTask(TaskKey.CreateRecurring(taskName));
         }
 
         public async Task<bool> CancelScheduledTask(ScheduledTask scheduledTask) 
@@ -380,15 +382,5 @@ private string LuaScriptToCancelTask()
                 return false
                 ";
         }
-
-        private TaskKey UniqueTaskKey()
-        {
-            return new TaskKey($"{DateTimeOffset.UtcNow.ToUnixTimeMilliseconds()}::{Guid.NewGuid().ToString()}");
-        }
-
-        private TaskKey RecurringTaskKey(string taskName)
-        {
-            return new TaskKey($"{nameof(RecurringTaskKey)}::{taskName}");
-        }
     }
 }