Skip to content

Commit 0336251

Browse files
committed
Set and respect PTHREAD_FLAG even for non-WASM builds
1 parent 2781d73 commit 0336251

2 files changed

Lines changed: 4 additions & 3 deletions

File tree

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
77

88

99
## [Unreleased]
10+
- Set and respect `PTHREAD_FLAG` even for non-WASM builds
1011
- Disable the undocumented `mmap()` codepath. It is now used for loading models from binary byte arrays.
1112
- Preload model to Item vector before creating scorers
1213

CMakeLists.txt

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -151,6 +151,7 @@ endif()
151151

152152
if(USE_THREADS)
153153
# Need to set compile definition as well
154+
set(PTHREAD_FLAG "-pthread")
154155
add_compile_definitions(USE_PTHREADS)
155156
endif()
156157

@@ -345,7 +346,6 @@ else(MSVC)
345346

346347
if(COMPILE_WASM)
347348
if(USE_THREADS)
348-
set(PTHREAD_FLAG "-pthread")
349349
set(DISABLE_PTHREAD_MEMGROWTH_WARNING -Wno-error=pthreads-mem-growth)
350350
endif(USE_THREADS)
351351
set(CMAKE_CXX_FLAGS "-std=c++11 ${PTHREAD_FLAG} ${CMAKE_GCC_FLAGS} -fPIC ${DISABLE_GLOBALLY} ${INTRINSICS}")
@@ -364,7 +364,7 @@ else(MSVC)
364364
--post-js ${CMAKE_SOURCE_DIR}/wasm/post-module.js \
365365
--shell-file ${CMAKE_SOURCE_DIR}/wasm/custom_shell.html")
366366
else(COMPILE_WASM)
367-
set(CMAKE_CXX_FLAGS "-std=c++11 -pthread ${CMAKE_GCC_FLAGS} -fPIC ${DISABLE_GLOBALLY} -march=${BUILD_ARCH} ${INTRINSICS} ${BUILD_WIDTH}")
367+
set(CMAKE_CXX_FLAGS "-std=c++11 ${PTHREAD_FLAG} ${CMAKE_GCC_FLAGS} -fPIC ${DISABLE_GLOBALLY} -march=${BUILD_ARCH} ${INTRINSICS} ${BUILD_WIDTH}")
368368
set(CMAKE_CXX_FLAGS_RELEASE "-O3 ${BUILD_WIDTH} -funroll-loops")
369369
set(CMAKE_CXX_FLAGS_DEBUG "-O0 -g ${CMAKE_RDYNAMIC_FLAG}")
370370
set(CMAKE_CXX_FLAGS_SLIM "-O3 ${BUILD_WIDTH} -funroll-loops -DNDEBUG")
@@ -374,7 +374,7 @@ else(MSVC)
374374
set(CMAKE_CXX_FLAGS_PROFUSE "${CMAKE_CXX_FLAGS_RELWITHDEBINFO} -fprofile-use -fprofile-correction")
375375

376376
# these need to be set separately
377-
set(CMAKE_C_FLAGS "-pthread ${CMAKE_GCC_FLAGS} -fPIC ${DISABLE_GLOBALLY} -march=${BUILD_ARCH} ${INTRINSICS}")
377+
set(CMAKE_C_FLAGS "${PTHREAD_FLAG} ${CMAKE_GCC_FLAGS} -fPIC ${DISABLE_GLOBALLY} -march=${BUILD_ARCH} ${INTRINSICS}")
378378
set(CMAKE_C_FLAGS_RELEASE "-O3 ${BUILD_WIDTH} -funroll-loops")
379379
set(CMAKE_C_FLAGS_DEBUG "-O0 -g ${CMAKE_RDYNAMIC_FLAG}")
380380
set(CMAKE_C_FLAGS_SLIM "-O3 ${BUILD_WIDTH} -funroll-loops -DNDEBUG")

0 commit comments

Comments
 (0)