address comments

Author: seanmcguire12

packages/server-v4/openapi.v4.yaml

@@ -2517,11 +2517,11 @@ components:
           type: object
           properties:
             x:
+              default: 0
               type: number
             y:
               type: number
           required:
-            - x
             - y
           additionalProperties: false
       required:
@@ -2535,13 +2535,14 @@ components:
         cursorPosition:
           $ref: "#/components/schemas/Selector"
         pages:
+          default: 1
           type: number
+          minimum: -100
+          maximum: 100
         delayBetweenMs:
           type: integer
           minimum: 0
           maximum: 9007199254740991
-      required:
-        - pages
       additionalProperties: false
     PageScrollToTargetParams:
       type: object
@@ -2550,6 +2551,13 @@ components:
           $ref: "#/components/schemas/PageId"
         target:
           $ref: "#/components/schemas/Selector"
+        position:
+          default: center
+          type: string
+          enum:
+            - center
+            - top
+            - bottom
       required:
         - target
       additionalProperties: false
@@ -4756,7 +4764,7 @@ components:
         error:
           type: "null"
         action:
-          $ref: "#/components/schemas/PageScrollAction"
+          $ref: "#/components/schemas/PageScrollActionOutput"
       required:
         - success
         - error
@@ -5625,6 +5633,70 @@ components:
             - y
           additionalProperties: false
       additionalProperties: false
+    PageScrollByOffsetParamsOutput:
+      type: object
+      properties:
+        pageId:
+          $ref: "#/components/schemas/PageId"
+        cursorPosition:
+          $ref: "#/components/schemas/Selector"
+        offset:
+          type: object
+          properties:
+            x:
+              default: 0
+              type: number
+            y:
+              type: number
+          required:
+            - x
+            - y
+          additionalProperties: false
+      required:
+        - offset
+      additionalProperties: false
+    PageScrollByPagesParamsOutput:
+      type: object
+      properties:
+        pageId:
+          $ref: "#/components/schemas/PageId"
+        cursorPosition:
+          $ref: "#/components/schemas/Selector"
+        pages:
+          default: 1
+          type: number
+          minimum: -100
+          maximum: 100
+        delayBetweenMs:
+          type: integer
+          minimum: 0
+          maximum: 9007199254740991
+      required:
+        - pages
+      additionalProperties: false
+    PageScrollToTargetParamsOutput:
+      type: object
+      properties:
+        pageId:
+          $ref: "#/components/schemas/PageId"
+        target:
+          $ref: "#/components/schemas/Selector"
+        position:
+          default: center
+          type: string
+          enum:
+            - center
+            - top
+            - bottom
+      required:
+        - target
+        - position
+      additionalProperties: false
+    PageScrollParamsOutput:
+      anyOf:
+        - $ref: "#/components/schemas/PageScrollByOffsetParamsOutput"
+        - $ref: "#/components/schemas/PageScrollByPagesParamsOutput"
+        - $ref: "#/components/schemas/PageScrollToTargetParamsOutput"
     PageClickActionOutput:
       type: object
       properties:
@@ -5707,6 +5779,47 @@ components:
         - params
         - result
       additionalProperties: false
+    PageScrollActionOutput:
+      type: object
+      properties:
+        id:
+          $ref: "#/components/schemas/ActionId"
+        method:
+          type: string
+          const: scroll
+        status:
+          $ref: "#/components/schemas/PageActionStatus"
+        sessionId:
+          $ref: "#/components/schemas/SessionId"
+        pageId:
+          $ref: "#/components/schemas/PageId"
+        createdAt:
+          $ref: "#/components/schemas/Timestamp"
+        updatedAt:
+          $ref: "#/components/schemas/Timestamp"
+        completedAt:
+          $ref: "#/components/schemas/Timestamp"
+        error:
+          anyOf:
+            - $ref: "#/components/schemas/PageError"
+            - type: "null"
+        params:
+          $ref: "#/components/schemas/PageScrollParamsOutput"
+        result:
+          anyOf:
+            - $ref: "#/components/schemas/PageScrollResult"
+            - type: "null"
+      required:
+        - id
+        - method
+        - status
+        - sessionId
+        - createdAt
+        - updatedAt
+        - error
+        - params
+        - result
+      additionalProperties: false
     PageDragAndDropActionOutput:
       type: object
       properties:
@@ -5752,7 +5865,7 @@ components:
       anyOf:
         - $ref: "#/components/schemas/PageClickActionOutput"
         - $ref: "#/components/schemas/PageHoverActionOutput"
-        - $ref: "#/components/schemas/PageScrollAction"
+        - $ref: "#/components/schemas/PageScrollActionOutput"
         - $ref: "#/components/schemas/PageDragAndDropActionOutput"
         - $ref: "#/components/schemas/PageTypeAction"
         - $ref: "#/components/schemas/PageKeyPressAction"

packages/server-v4/src/schemas/v4/page.ts

@@ -286,7 +286,7 @@ export const PageScrollByOffsetParamsSchema = PageWithPageIdSchema.extend({
   cursorPosition: SelectorSchema.optional(),
   offset: z
     .object({
-      x: z.number(),
+      x: z.number().default(0),
       y: z.number(),
     })
     .strict(),
@@ -296,14 +296,15 @@ export const PageScrollByOffsetParamsSchema = PageWithPageIdSchema.extend({
 
 export const PageScrollByPagesParamsSchema = PageWithPageIdSchema.extend({
   cursorPosition: SelectorSchema.optional(),
-  pages: z.number(),
+  pages: z.number().lte(100).gte(-100).default(1),
   delayBetweenMs: z.number().int().min(0).optional(),
 })
   .strict()
   .meta({ id: "PageScrollByPagesParams" });
 
 export const PageScrollToTargetParamsSchema = PageWithPageIdSchema.extend({
   target: SelectorSchema,
+  position: z.enum(["center", "top", "bottom"]).default("center"),
 })
   .strict()
   .meta({ id: "PageScrollToTargetParams" });