Round 2 of psalm-mutation annotations

Author: nederdirk

src/Clock.php

@@ -8,6 +8,8 @@ interface Clock
 {
     /**
      * Returns the current time.
+     *
+     * @psalm-mutation-free
      */
     public function getTime() : Instant;
 }

src/Clock/OffsetClock.php

@@ -37,6 +37,9 @@ public function __construct(Clock $referenceClock, Duration $offset)
         $this->offset         = $offset;
     }
 
+    /**
+     * @psalm-mutation-free
+     */
     public function getTime() : Instant
     {
         return $this->referenceClock->getTime()->plus($this->offset);

src/Clock/ScaleClock.php

@@ -50,6 +50,9 @@ public function __construct(Clock $referenceClock, int $timeScale)
         $this->timeScale      = $timeScale;
     }
 
+    /**
+     * @psalm-mutation-free
+     */
     public function getTime() : Instant
     {
         $duration = Duration::between($this->startTime, $this->referenceClock->getTime());

src/Clock/SystemClock.php

@@ -14,8 +14,14 @@
  */
 final class SystemClock implements Clock
 {
+    /**
+     * @psalm-mutation-free
+     */
     public function getTime() : Instant
     {
+        /**
+         * @psalm-suppress ImpureFunctionCall This is how time works
+         */
         [$fraction, $epochSecond] = \explode(' ', microtime());
 
         $epochSecond    = (int) $epochSecond;

src/DayOfWeek.php

@@ -47,7 +47,10 @@ private function __construct(int $value)
      */
     private static function get(int $value) : DayOfWeek
     {
-        /** @var array<int, DayOfWeek> $values */
+        /**
+         * @var array<int, DayOfWeek> $values
+         * @psalm-suppress ImpureStaticVariable only used to cache results
+         */
         static $values = [];
 
         if (! isset($values[$value])) {

src/DefaultClock.php

@@ -31,7 +31,8 @@ private function __construct()
     /**
      * Gets the default clock.
      *
-     * @psalm-external-mutation-free
+     * @psalm-mutation-free
+     * @psalm-suppress ImpureStaticProperty
      */
     public static function get() : Clock
     {

src/Field/TimeZoneOffsetHour.php

@@ -25,6 +25,8 @@ final class TimeZoneOffsetHour
      * @param int $offsetHour The offset-hour to check.
      *
      * @throws DateTimeException If the offset-hour is not valid.
+     *
+     * @psalm-pure
      */
     public static function check(int $offsetHour) : void
     {

src/Field/TimeZoneOffsetMinute.php

@@ -25,6 +25,8 @@ final class TimeZoneOffsetMinute
      * @param int $offsetMinute The offset-minute to check.
      *
      * @throws DateTimeException If the offset-minute is not valid.
+     *
+     * @psalm-pure
      */
     public static function check(int $offsetMinute) : void
     {

src/Field/TimeZoneOffsetSecond.php

@@ -25,6 +25,8 @@ final class TimeZoneOffsetSecond
      * @param int $offsetSecond The offset-second to check.
      *
      * @throws DateTimeException If the offset-second is not valid.
+     *
+     * @psalm-pure
      */
     public static function check(int $offsetSecond) : void
     {