Skip to content

Commit 662efe8

Browse files
committed
Fix CI: make classifications optional in OtherExperimentLogFields, unexport classifierName
1 parent 38066dd commit 662efe8

2 files changed

Lines changed: 2 additions & 2 deletions

File tree

js/src/framework.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -884,7 +884,7 @@ export function scorerName(
884884
return scorer.name || `scorer_${scorer_idx}`;
885885
}
886886

887-
export function classifierName(
887+
function classifierName(
888888
classifier: EvalClassifier<any, any, any, any>,
889889
classifier_idx: number,
890890
) {

js/util/object.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ export type OtherExperimentLogFields = {
2121
error: unknown;
2222
tags: string[];
2323
scores: Record<string, number | null>;
24-
classifications: Record<string, { id: string; label: string }[]>;
24+
classifications?: Record<string, { id: string; label: string }[]>;
2525
metadata: Record<string, unknown>;
2626
metrics: Record<string, unknown>;
2727
datasetRecordId: string;

0 commit comments

Comments
 (0)