From b6d57d9644bfbb74929e1e064138b4751d475ef5 Mon Sep 17 00:00:00 2001 From: Jackie Jou Date: Wed, 24 Jun 2026 16:49:32 -0700 Subject: [PATCH] fix(activity-feed-v2): anchor feed to sidebar to prevent page scroll The v2 wrapper relied on height: 100% propagating from ancestors. On shared-link pages the chain stops at a min-height ancestor, so the feed grew to its content height and the whole page scrolled instead of the feed. Switch the wrapper to position: absolute; inset: 0 and make the outer .bcs-NewActivityFeedContent the containing block, so the feed fills the sidebar regardless of ancestor height behavior. --- .../activity-feed-v2/ActivityFeedV2.scss | 22 +++++++------------ 1 file changed, 8 insertions(+), 14 deletions(-) diff --git a/src/elements/content-sidebar/activity-feed-v2/ActivityFeedV2.scss b/src/elements/content-sidebar/activity-feed-v2/ActivityFeedV2.scss index 7d9a62388d..25eb1674dd 100644 --- a/src/elements/content-sidebar/activity-feed-v2/ActivityFeedV2.scss +++ b/src/elements/content-sidebar/activity-feed-v2/ActivityFeedV2.scss @@ -1,22 +1,17 @@ -// CSS isolation layer for ActivityFeedV2. -// BUIE global styles (.bcs scope from base.scss) apply broad rules to native -// elements (inputs, contenteditable, buttons, links, textareas). These leak -// into Blueprint and @box/threaded-annotations components, breaking their -// styling. This file resets those rules within the v2 adapter boundary. +// Resets BUIE .bcs global styles that leak into Blueprint and +// @box/threaded-annotations components. .bcs-NewActivityFeed { + position: absolute; + inset: 0; display: flex; flex-direction: column; - height: 100%; overflow: hidden; - // `display: contents` keeps the wrapper transparent to the vendor's flex layout. &-list { display: contents; } - // Forms: BUIE sets width, padding, border, box-shadow, border-radius on - // contenteditable and inputs via _forms.scss inside .bcs scope. div[contenteditable='true'], div[contenteditable='true']:hover, div[contenteditable='true']:focus { @@ -31,8 +26,6 @@ transition: none; } - // Links: BUIE forces color and text-decoration on all elements - // via _links.scss. a { color: inherit; text-decoration: inherit; @@ -42,8 +35,6 @@ text-decoration: inherit; } - // BUIE sets pointer-events: none on inside and