From 4c6136ca1bcbe5f98dfa72989ed25e86180143f2 Mon Sep 17 00:00:00 2001 From: Omfalos Date: Mon, 15 Jun 2026 12:58:29 +0200 Subject: [PATCH 1/4] feat(content-uploader): add support for item share button and open preview button --- .../content-uploader/ContentUploader.tsx | 8 +++++++ .../__tests__/ContentUploader.test.js | 22 +++++++++++++++++++ 2 files changed, 30 insertions(+) diff --git a/src/elements/content-uploader/ContentUploader.tsx b/src/elements/content-uploader/ContentUploader.tsx index 9f733cdd1f..393571a15a 100644 --- a/src/elements/content-uploader/ContentUploader.tsx +++ b/src/elements/content-uploader/ContentUploader.tsx @@ -93,6 +93,8 @@ export interface ContentUploaderProps { onClickRetry: (item: UploadItem) => void; onClose: () => void; onComplete: (items: UploadItem[]) => void; + onItemShare?: (itemId: string) => void; + onItemOpen?: (itemId: string) => void; onError: Function; onMinimize?: () => void; onProgress: (item: UploadItem) => void; @@ -172,6 +174,8 @@ class ContentUploader extends Component { onProgress: noop, onResume: noop, onUpload: noop, + onItemShare: noop, + onItemOpen: noop, overwrite: true, rootFolderId: DEFAULT_ROOT, uploadHost: DEFAULT_HOSTNAME_UPLOAD, @@ -1451,6 +1455,8 @@ class ContentUploader extends Component { messages, onClose, onUpgradeCTAClick, + onItemShare, + onItemOpen, rootFolderId, theme, useUploadsManager, @@ -1480,6 +1486,8 @@ class ContentUploader extends Component { onItemCancel={this.handleUploadsManagerItemCancel} onItemRetry={this.handleUploadsManagerItemRetry} onItemRemove={this.handleUploadsManagerItemRemove} + onItemShare={onItemShare} + onItemOpen={onItemOpen} onCancelAll={this.handleCancelAllClick} onRetryAll={this.handleUploadsManagerRetryAll} /> diff --git a/src/elements/content-uploader/__tests__/ContentUploader.test.js b/src/elements/content-uploader/__tests__/ContentUploader.test.js index 931b53f4cc..d3f9b79918 100644 --- a/src/elements/content-uploader/__tests__/ContentUploader.test.js +++ b/src/elements/content-uploader/__tests__/ContentUploader.test.js @@ -1300,6 +1300,28 @@ describe('elements/content-uploader/ContentUploader', () => { expect(resetSpy).not.toHaveBeenCalled(); expect(uploadFileSpy).not.toHaveBeenCalled(); }); + + test('should pass onItemShare prop to UploadsManagerBP', () => { + const onItemShare = jest.fn(); + const wrapper = getWrapper({ enableModernizedUploads: true, onItemShare }); + expect(wrapper.find(UploadsManagerBP).prop('onItemShare')).toBe(onItemShare); + }); + + test('should pass onItemOpen prop to UploadsManagerBP', () => { + const onItemOpen = jest.fn(); + const wrapper = getWrapper({ enableModernizedUploads: true, onItemOpen }); + expect(wrapper.find(UploadsManagerBP).prop('onItemOpen')).toBe(onItemOpen); + }); + + test('should default onItemShare to noop when not provided', () => { + const wrapper = getWrapper({ enableModernizedUploads: true }); + expect(() => wrapper.find(UploadsManagerBP).prop('onItemShare')('item-id')).not.toThrow(); + }); + + test('should default onItemOpen to noop when not provided', () => { + const wrapper = getWrapper({ enableModernizedUploads: true }); + expect(() => wrapper.find(UploadsManagerBP).prop('onItemOpen')('item-id')).not.toThrow(); + }); }); }); }); From aff6382ed3dfe4a6556b1f6b93ee34d7882cddc6 Mon Sep 17 00:00:00 2001 From: Omfalos Date: Tue, 16 Jun 2026 10:59:12 +0200 Subject: [PATCH 2/4] feat(content-uploader): add support for item share button and open preview button --- src/elements/content-uploader/ContentUploader.tsx | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/elements/content-uploader/ContentUploader.tsx b/src/elements/content-uploader/ContentUploader.tsx index 393571a15a..9953982796 100644 --- a/src/elements/content-uploader/ContentUploader.tsx +++ b/src/elements/content-uploader/ContentUploader.tsx @@ -174,8 +174,8 @@ class ContentUploader extends Component { onProgress: noop, onResume: noop, onUpload: noop, - onItemShare: noop, - onItemOpen: noop, + onItemShare: undefined, + onItemOpen: undefined, overwrite: true, rootFolderId: DEFAULT_ROOT, uploadHost: DEFAULT_HOSTNAME_UPLOAD, From 8bc4f76f47fa9b6cc0a8dd30242cbcef7ca14d0b Mon Sep 17 00:00:00 2001 From: Omfalos Date: Tue, 16 Jun 2026 11:07:25 +0200 Subject: [PATCH 3/4] feat(content-uploader): fix test to check default param of undefined --- .../content-uploader/__tests__/ContentUploader.test.js | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/elements/content-uploader/__tests__/ContentUploader.test.js b/src/elements/content-uploader/__tests__/ContentUploader.test.js index d3f9b79918..0697862b00 100644 --- a/src/elements/content-uploader/__tests__/ContentUploader.test.js +++ b/src/elements/content-uploader/__tests__/ContentUploader.test.js @@ -1313,14 +1313,14 @@ describe('elements/content-uploader/ContentUploader', () => { expect(wrapper.find(UploadsManagerBP).prop('onItemOpen')).toBe(onItemOpen); }); - test('should default onItemShare to noop when not provided', () => { + test('should default onItemShare to undefined when not provided', () => { const wrapper = getWrapper({ enableModernizedUploads: true }); - expect(() => wrapper.find(UploadsManagerBP).prop('onItemShare')('item-id')).not.toThrow(); + expect(wrapper.find(UploadsManagerBP).prop('onItemShare')).toBeUndefined(); }); - test('should default onItemOpen to noop when not provided', () => { + test('should default onItemOpen to undefined when not provided', () => { const wrapper = getWrapper({ enableModernizedUploads: true }); - expect(() => wrapper.find(UploadsManagerBP).prop('onItemOpen')('item-id')).not.toThrow(); + expect(wrapper.find(UploadsManagerBP).prop('onItemOpen')).toBeUndefined(); }); }); }); From 13762c7cf73cfff4507ad99f8e8b61976f20411a Mon Sep 17 00:00:00 2001 From: Omfalos Date: Tue, 16 Jun 2026 11:27:03 +0200 Subject: [PATCH 4/4] feat(content-uploader): remove undefined value as it is by default undefined already --- src/elements/content-uploader/ContentUploader.tsx | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/elements/content-uploader/ContentUploader.tsx b/src/elements/content-uploader/ContentUploader.tsx index 9953982796..d9f3856da3 100644 --- a/src/elements/content-uploader/ContentUploader.tsx +++ b/src/elements/content-uploader/ContentUploader.tsx @@ -174,8 +174,6 @@ class ContentUploader extends Component { onProgress: noop, onResume: noop, onUpload: noop, - onItemShare: undefined, - onItemOpen: undefined, overwrite: true, rootFolderId: DEFAULT_ROOT, uploadHost: DEFAULT_HOSTNAME_UPLOAD,