Doc build script issues

[sdarwin]

Deletes subdirectory node_modules after Antora generation: this directory has slipped previously in release archives

1. Is this working? I just downloaded a snapshot of boost 1.91.0, the unordered/doc/node_modules folder exists.

2. There are two similar files doc/antora_docs.sh and doc/build_antora.sh. At minimum they should be kept in sync, they are going out of sync. But preferably delete one of them? (Keep build_antora.sh so it matches openmethod and url).

Edit:

Or, if both scripts ought to stay, add a comment (in both scripts) explaining the situation

[joaquintides]

Deletion of node_modules is implemented in the Jamfile, not in build_antora.sh. Which one does the release build script call?

As per the existence of two scripts, yes, I can remove antora_docs.sh.

[sdarwin]

"Which one"... It really looks like the Jamfile.
Checking doc previews and comparing those to the superproject build, it seems previews run "cleanup-node-modules" while the full build does not.

On CircleCI, the superproject runs b2 with /boostrelease since it's a release.

In the Jamfile:

alias boostrelease : html_ ;
explicit boostrelease ;

html_ leads to

make html_ : build_antora.sh : @run-script ;

Is it possible cleanup-node-modules is not part of alias boostrelease ?

[joaquintides]

Can you check #339? I've tested locally and node_modules is now removed when issuing b2 boostrelease.

[sdarwin]

Can you check 339

I am not 100% certain, but it looks ok; merge and see if CircleCI succeeds.

[joaquintides]

Reopened in wait for your confirmation.

[sdarwin]

Super. It seems to be fixed.