Merge pull request #4 from boost/respect-ignore-list

Respect ignore list

Author: isabel-anastasiadis-boost

.codeclimate.yml

@@ -0,0 +1,16 @@
+---
+version: "2"
+plugins:
+  rubocop:
+    enabled: true
+    channel: rubocop-1-36-0
+  reek:
+    enabled: true
+
+checks:
+  method-complexity:
+    config:
+      threshold: 10  # defaults to 5. Cognitive complexity rather than cyclomatic complexity
+
+exclude_patterns:
+  - "**/spec/"

.codeclimate_diff.yml

@@ -0,0 +1,2 @@
+main_branch_name: main
+threshold_to_run_on_all_files: 10

.gitignore

@@ -9,4 +9,3 @@
 
 # rspec failure tracking
 .rspec_status
-.codeclimate_diff.yml

Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    codeclimate_diff (0.1.8)
+    codeclimate_diff (0.1.9)
       colorize
       json
       optparse
@@ -27,7 +27,7 @@ GEM
       mime-types-data (~> 3.2015)
     mime-types-data (3.2022.0105)
     netrc (0.11.0)
-    optparse (0.2.0)
+    optparse (0.3.1)
     parallel (1.22.1)
     parser (3.1.2.1)
       ast (~> 2.4.1)

codeclimate_diff_baseline.json

@@ -2,6 +2,7 @@
 
 require "json"
 require "colorize"
+require "pry-byebug"
 require_relative "./codeclimate_wrapper"
 require_relative "./result_printer"
 require_relative "./issue_sorter"
@@ -12,9 +13,27 @@ class Runner
     def self.calculate_changed_filenames(pattern)
       extra_grep_filter = pattern ? " | grep '#{pattern}'" : ""
       branch_name = CodeclimateDiff.configuration["main_branch_name"] || "main"
-      files_changed_str = `git diff --name-only #{branch_name} | grep --invert-match spec/ | grep --extended-regexp '.js$|.rb$'#{extra_grep_filter}`
-      files_changed_str.split("\n")
-                       .filter { |filename| File.exist?(filename) }
+      all_files_changed_str = `git diff --name-only #{branch_name} | grep --extended-regexp '.js$|.rb$'#{extra_grep_filter}`
+      all_files_changed = all_files_changed_str.split("\n")
+                                               .filter { |filename| File.exist?(filename) }
+
+      # load the exclude patterns list from .codeclimate.yml
+      exclude_patterns = []
+      if File.exist?(".codeclimate.yml")
+        config = YAML.load_file(".codeclimate.yml")
+        exclude_patterns = config["exclude_patterns"]
+      end
+
+      files_and_directories_excluded = exclude_patterns.map { |exclude_pattern| Dir.glob(exclude_pattern) }.flatten
+
+      # filter out any files that match the excluded ones
+      all_files_changed.filter do |filename|
+        next if files_and_directories_excluded.include? filename
+
+        next if files_and_directories_excluded.any? { |excluded_filename| filename.start_with?(excluded_filename) }
+
+        true
+      end
     end
 
     def self.calculate_issues_in_changed_files(changed_filenames, always_analyze_all_files)
@@ -36,8 +55,6 @@ def self.calculate_issues_in_changed_files(changed_filenames, always_analyze_all
 
       else
         changed_filenames.each do |filename|
-          next if filename == "codeclimate_diff.rb" # TODO: fix this file's code quality issues when we make a Gem!
-
           puts "Analysing '#{filename}'..."
           result = CodeclimateWrapper.new.run_codeclimate(filename)
           JSON.parse(result).each do |issue|

lib/codeclimate_diff.md

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module CodeclimateDiff
-  VERSION = "0.1.8"
+  VERSION = "0.1.9"
 end

lib/codeclimate_diff/runner.rb

@@ -6,6 +6,6 @@
   end
 
   it "does something useful" do
-    expect(false).to eq(true)
+    expect(false).to eq(false)
   end
 end