Fixed function object constructable/callable (#409)

- Maded arrow functions non-constructable
 - Simplified Function object and removed FunctionKind
 - Rnamed create_ordinary -> ordinary, create_builtin -> builtin
 - Added name and length properties in global objects

Author: HalidOdat

boa/src/builtins/array/mod.rs

@@ -1031,7 +1031,7 @@ impl Array {
         make_builtin_fn(Self::slice, "slice", &prototype, 2);
         make_builtin_fn(Self::some, "some", &prototype, 2);
 
-        let array = make_constructor_fn(Self::make_array, global, prototype);
+        let array = make_constructor_fn("Array", 1, Self::make_array, global, prototype, true);
 
         // Static Methods
         make_builtin_fn(Self::is_array, "isArray", &array, 1);

boa/src/builtins/bigint/mod.rs

@@ -96,14 +96,14 @@ impl BigInt {
         ))
     }
 
-    // /// `BigInt.prototype.valueOf()`
-    // ///
-    // /// The `valueOf()` method returns the wrapped primitive value of a Number object.
-    // ///
-    // /// More information:
-    // ///  - [ECMAScript reference][spec]
-    // ///  - [MDN documentation][mdn]
-    // ///
+    /// `BigInt.prototype.valueOf()`
+    ///
+    /// The `valueOf()` method returns the wrapped primitive value of a Number object.
+    ///
+    /// More information:
+    ///  - [ECMAScript reference][spec]
+    ///  - [MDN documentation][mdn]
+    ///
     /// [spec]: https://tc39.es/ecma262/#sec-bigint.prototype.valueof
     /// [mdn]: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/BigInt/valueOf
     pub(crate) fn value_of(
@@ -124,7 +124,7 @@ impl BigInt {
         make_builtin_fn(Self::to_string, "toString", &prototype, 1);
         make_builtin_fn(Self::value_of, "valueOf", &prototype, 0);
 
-        make_constructor_fn(Self::make_bigint, global, prototype)
+        make_constructor_fn("BigInt", 1, Self::make_bigint, global, prototype, false)
     }
 
     /// Initialise the `BigInt` object on the global object.

boa/src/builtins/boolean/mod.rs

@@ -115,7 +115,14 @@ impl Boolean {
         make_builtin_fn(Self::to_string, "toString", &prototype, 0);
         make_builtin_fn(Self::value_of, "valueOf", &prototype, 0);
 
-        make_constructor_fn(Self::construct_boolean, global, prototype)
+        make_constructor_fn(
+            "Boolean",
+            1,
+            Self::construct_boolean,
+            global,
+            prototype,
+            true,
+        )
     }
 
     /// Initialise the `Boolean` object on the global object.

boa/src/builtins/error/mod.rs

@@ -72,9 +72,10 @@ impl Error {
     pub(crate) fn create(global: &Value) -> Value {
         let prototype = Value::new_object(Some(global));
         prototype.set_field("message", Value::from(""));
-        prototype.set_field("name", Value::from("Error"));
+
         make_builtin_fn(Self::to_string, "toString", &prototype, 0);
-        make_constructor_fn(Self::make_error, global, prototype)
+
+        make_constructor_fn("Error", 1, Self::make_error, global, prototype, true)
     }
 
     /// Initialise the global object with the `Error` object.

boa/src/builtins/error/range.rs

@@ -63,9 +63,10 @@ impl RangeError {
     pub(crate) fn create(global: &Value) -> Value {
         let prototype = Value::new_object(Some(global));
         prototype.set_field("message", Value::from(""));
-        prototype.set_field("name", Value::from("RangeError"));
+
         make_builtin_fn(Self::to_string, "toString", &prototype, 0);
-        make_constructor_fn(Self::make_error, global, prototype)
+
+        make_constructor_fn("RangeError", 1, Self::make_error, global, prototype, true)
     }
 
     /// Runs a `new RangeError(message)`.