Skip to content

Commit d349d5e

Browse files
loganjclaude
andcommitted
fix(penpal): address review feedback on release workflow
- Use macos-13 (Intel) runner for x86_64 builds instead of cross-compiling on arm64 — avoids Tauri native linking issues - Remove workflow_dispatch (no tag = broken version extraction) - Scope permissions per-job (build: read, release: write) - Add fail-fast: false so both arch builds complete independently - Remove duplicate pnpm install in frontend build step - Add comment explaining cross-repo GITHUB_TOKEN pattern Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
1 parent 51aa96f commit d349d5e

1 file changed

Lines changed: 14 additions & 14 deletions

File tree

.github/workflows/penpal-release.yml

Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -3,28 +3,28 @@ name: Penpal Release
33
on:
44
push:
55
tags: ['penpal/v*']
6-
workflow_dispatch:
7-
8-
permissions:
9-
contents: write
10-
actions: write
116

127
env:
138
CARGO_TERM_COLOR: always
149

1510
jobs:
1611
build:
1712
name: Build (${{ matrix.arch }})
18-
runs-on: macos-latest
13+
runs-on: ${{ matrix.runner }}
14+
permissions:
15+
contents: read
1916
strategy:
17+
fail-fast: false
2018
matrix:
2119
include:
2220
- arch: arm64
2321
target: aarch64-apple-darwin
2422
goarch: arm64
23+
runner: macos-latest
2524
- arch: x86_64
2625
target: x86_64-apple-darwin
2726
goarch: amd64
27+
runner: macos-13
2828
steps:
2929
- uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6
3030

@@ -37,15 +37,10 @@ jobs:
3737
workspaces: apps/penpal/frontend/src-tauri
3838
key: ${{ matrix.target }}
3939

40-
# Add cross-compilation target if needed
41-
- name: Add Rust target
42-
if: matrix.arch == 'x86_64'
43-
run: rustup target add ${{ matrix.target }}
44-
4540
# Enable pnpm via corepack
4641
- run: corepack enable pnpm
4742

48-
# Install frontend dependencies
43+
# Install dependencies
4944
- name: Install dependencies
5045
run: |
5146
pnpm install --frozen-lockfile
@@ -66,7 +61,7 @@ jobs:
6661
# Build frontend (architecture-independent)
6762
- name: Build frontend
6863
working-directory: apps/penpal/frontend
69-
run: pnpm install && VITE_BASE=/ VITE_API_URL=http://localhost:8080 pnpm run build
64+
run: VITE_BASE=/ VITE_API_URL=http://localhost:8080 pnpm run build
7065

7166
# Build Tauri app for the target architecture
7267
- name: Build Tauri app
@@ -88,6 +83,9 @@ jobs:
8883
name: Create Release
8984
needs: build
9085
runs-on: ubuntu-latest
86+
permissions:
87+
contents: write
88+
actions: write
9189
steps:
9290
- uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6
9391
with:
@@ -122,7 +120,9 @@ jobs:
122120
$NOTES_ARGS \
123121
artifacts/*.zip
124122
125-
# Trigger cask bump on block/homebrew-tap
123+
# Trigger cask bump on block/homebrew-tap.
124+
# Uses GITHUB_TOKEN with actions:write — block org allows cross-repo
125+
# workflow_dispatch (same pattern as block/qrgo → block/homebrew-tap).
126126
- name: Trigger Homebrew cask bump
127127
env:
128128
GH_TOKEN: ${{ github.token }}

0 commit comments

Comments
 (0)