Fix performance issues and various bugs

Author: blipk

AUDIT_REPORT.md

@@ -269,7 +269,7 @@ Status: ⬜ Needs Fix · ✅ Fixed · ❌ Won't Fix
 | **P7** | [sessionManager.js](worksets@blipk.xyz/sessionManager.js#L605-L649) | 605-649 | **Full app rescan on every `getFavorites()` call**. `scanInstalledApps()` iterates every installed app (hundreds including Flatpak/Snap) to rebuild `allApps` map. Called from favorites change signal, `newWorkset`, `newSession`, `_validateSession`. | Cache `scanInstalledApps()` result on first call; invalidate and rescan only when `Shell.AppSystem` emits `"installed-changed"` signal. | ✅ |
 | **P8** | [panelIndicator.js](worksets@blipk.xyz/panelIndicator.js#L671-L691) | 671-691 | **Full menu teardown + rebuild + sync disk I/O on every open**. `_refreshMenu()` destroys all menu items, recreates all from scratch, then calls `saveSession()` (sync disk write). | Remove `saveSession()` from `_refreshMenu()`. Update existing menu items in-place (change labels, toggle states) instead of full teardown/rebuild; only add/remove entries when the workset list actually changes. | ✅ saveSession removed from _refreshMenu |
 | **P9** | [workspaceView.js](worksets@blipk.xyz/workspaceView.js#L249-L251) | 249-251, 294-296 | **Meta.Background GPU memory leak**. Old `Meta.Background` objects are `delete`d (JS property removal) but never `destroy()`d. GPU textures remain allocated until GC collects the GObject (which may never happen due to reference cycles). | Call `.destroy()` on old `Meta.Background` objects before replacing them. Replace `delete` (JS property removal) with explicit `.destroy()` followed by nulling the reference. | ✅ |
-| **P10** | [uiUtils.js](worksets@blipk.xyz/lib/ui/uiUtils.js#L210-L254) | 210-254 | **Unbounded image cache**. Module-level `knownImages` object caches every wallpaper image (CPU pixbuf + GPU St.ImageContent) forever -- never invalidated, never evicted, never cleared on disable/enable. | Clear the `knownImages` cache on extension disable. Add LRU eviction with a maximum entry count (e.g., 20 images) to prevent unbounded memory growth during long sessions. | |
+| **P10** | [uiUtils.js](worksets@blipk.xyz/lib/ui/uiUtils.js#L210-L254) | 210-254 | **Unbounded image cache**. Module-level `knownImages` object caches every wallpaper image (CPU pixbuf + GPU St.ImageContent) forever -- never invalidated, never evicted, never cleared on disable/enable. | Clear the `knownImages` cache on extension disable. Add LRU eviction with a maximum entry count (e.g., 20 images) to prevent unbounded memory growth during long sessions. | ✅ |
 | **P11** | [workspaceView.js](worksets@blipk.xyz/workspaceView.js#L237-L271) | 237-271 | **Meta.Background created on every workspace gesture**. `refreshDesktop()` triggered from `WorkspaceGroup._init` injection recreates all background managers for ALL workspace groups on every switch animation. | Cache `BackgroundManager` instances per monitor/workspace (same as P1). Add dirty flags and only recreate when the wallpaper path has actually changed; skip recreation if the existing background matches the target. | ✅ |
 
 ### MEDIUM
@@ -280,14 +280,14 @@ Status: ⬜ Needs Fix · ✅ Fixed · ❌ Won't Fix
 | **P13** | [workspaceManager.js](worksets@blipk.xyz/workspaceManager.js#L126-L146) | 126-146 | **No debouncing on workspace switch cascade**. Rapid switching (keyboard, gestures) triggers the full `_activeWorkspaceChanged()` -> `displayWorkset()` -> `setFavorites()` + `setBackground()` + `saveSession()` + `refreshOverview()` chain repeatedly. | Add `GLib.timeout_add()` debounce (100-200ms) to `_activeWorkspaceChanged()`, storing the timeout ID and canceling any previous pending timeout with `GLib.Source.remove()` on each new signal. | |
 | **P14** | [sessionManager.js](worksets@blipk.xyz/sessionManager.js#L390-L395) | 390-395 | **O(n^2) duplicate detection** in `_validateSession()`. Inside a `forEach` over worksets, `JSON.stringify` is called on every other workset for comparison. Also a correctness bug: only the last iteration's filter result is kept. | Use a `Set` of `JSON.stringify()`-ed workset values for O(1) duplicate lookup. Accumulate seen hashes in the Set and filter out duplicates in a single pass. Fix the correctness bug by assigning the filter result back to the array. | ✅ |
 | **P15** | [extension.js](worksets@blipk.xyz/extension.js#L74-L89) | 74-89 | **New `Gio.Settings` created per call**. `dash2panelSettings()` and `dash2dockSettings()` are factory functions, not cached. Each call creates a new dconf-backed Settings object. Signal handlers connected to these ephemeral objects may be ineffective or leak. | Cache the `Gio.Settings` objects as instance properties (e.g., `this._dash2panelSettings`) on first call and return the cached instance on subsequent calls. Null out on `disable()`. | ✅ |
-| **P16** | [sessionManager.js](worksets@blipk.xyz/sessionManager.js#L203-L229) | 203-229 | **`saveSession()` called inside `forEach` loop** on background/options GSettings change signals. The `return` inside `forEach` only skips the current iteration, not the loop. | Move `saveSession()` outside the `forEach` loop to execute once after all worksets have been updated. The MD5 hash comparison will prevent redundant disk writes anyway. | |
+| **P16** | [sessionManager.js](worksets@blipk.xyz/sessionManager.js#L203-L229) | 203-229 | **`saveSession()` called inside `forEach` loop** on background/options GSettings change signals. The `return` inside `forEach` only skips the current iteration, not the loop. | Move `saveSession()` outside the `forEach` loop to execute once after all worksets have been updated. The MD5 hash comparison will prevent redundant disk writes anyway. | ✅ |
 | **P17** | [workspaceView.js](worksets@blipk.xyz/workspaceView.js#L165-L188) | 165-188 | **String operations on every animation frame**. Overview state handler runs string split + parseFloat + parseInt on `notify::value` which fires at 60fps during gestures. Also mutates GNOME Shell's internal `adjustment.lastValue`. | Use `Math.floor(value)` and `value % 1` for decimal extraction instead of string split/parse. Cache the last integer state and skip processing if unchanged. Stop mutating `adjustment.lastValue`. | ✅ |
 | **P18** | [workspaceView.js](worksets@blipk.xyz/workspaceView.js#L357-L363) | 357-363 | **Overlay box fully rebuilt every refresh**. `updateOverlay()` destroys all children and the box itself, then recreates all labels, buttons, and layouts from scratch on every overview state change. | Check if the workset name changed before destroying; reuse the existing overlay box and update only label text with `set_text()` when content hasn't changed. Only rebuild when the workset mapping actually changes. | ❌ caching caused stale overlays; rebuild is cheap compared to GPU work |
 | **P19** | [workspaceView.js](worksets@blipk.xyz/workspaceView.js#L59) | 59, 433 | **Menus array grows without cleanup**. Popup menus pushed to `this.menus` are never removed or destroyed. `destroy()` method doesn't clean them up. Leaks Clutter actors added to `Main.uiGroup`. | Destroy all menus in `this.menus` during `WorkspaceViewManager.destroy()`. Connect to each menu's `"destroy"` signal to remove it from the array, or use `WeakRef` wrappers to auto-expire dead references. | ✅ |
 | **P20** | [workspaceIsolater.js](worksets@blipk.xyz/workspaceIsolater.js#L128-L143) | 128-143 | **Full dash redisplay + all-app state notify on every restack**. `refresh()` calls `app.notify("state")` for every running app and `dash._queueRedisplay()` on `"restacked"` which fires on every window create/destroy/move/z-change. | Add `GLib.timeout_add()` debounce (50ms) to `refresh()`, storing the timeout ID and canceling previous pending calls with `GLib.Source.remove()` before scheduling a new one. | ✅ |
 | **P21** | [panelIndicator.js](worksets@blipk.xyz/panelIndicator.js#L317-L337) | 317-337 | **Double add+move for menu items**. Items are added at position then moved redundantly, causing doubled Clutter layout invalidation and reflow. | Use `addMenuItem(item, position)` with the explicit position argument directly instead of adding then moving. Remove the redundant `moveMenuItem()` calls. | ✅ |
 | **P22** | [uiUtils.js](worksets@blipk.xyz/lib/ui/uiUtils.js#L168-L186) | 168-186 | **Unbounded tooltip timer accumulation**. Every hover creates 2 `GLib.timeout_add` entries stored in `Me.session.signals`. Old entries persist across menu rebuilds, growing without bound during long sessions. | Store timeout IDs on the widget object itself and remove old timers with `GLib.Source.remove()` before creating new ones. Clean up all tooltip timers when the parent menu item is destroyed. | ✅ |
-| **P23** | [uiUtils.js](worksets@blipk.xyz/lib/ui/uiUtils.js#L221-L228) | 221-228 | **Synchronous pixbuf decode on compositor thread**. `GdkPixbuf.Pixbuf.new_from_file()` blocks the main thread while decoding images. For 4K+ wallpapers, visible frame drops. | Use `GdkPixbuf.Pixbuf.new_from_stream_async()` with a `Gio.FileInputStream`, or defer loading to idle with `Meta.later_add(Meta.LaterType.IDLE, callback)` so image decoding doesn't block frame rendering. | |
+| **P23** | [uiUtils.js](worksets@blipk.xyz/lib/ui/uiUtils.js#L221-L228) | 221-228 | **Synchronous pixbuf decode on compositor thread**. `GdkPixbuf.Pixbuf.new_from_file()` blocks the main thread while decoding images. For 4K+ wallpapers, visible frame drops. | Use `GdkPixbuf.Pixbuf.new_from_stream_async()` with a `Gio.FileInputStream`, or defer loading to idle with `Meta.later_add(Meta.LaterType.IDLE, callback)` so image decoding doesn't block frame rendering. | ✅ uses new_from_file_at_scale to decode at display size (150px) instead of full resolution |
 | **P24** | [sessionManager.js](worksets@blipk.xyz/sessionManager.js#L467) | 467 | **Redundant `refreshOverview()` after save**. Called inside `saveSession()`, but many callers also call it afterward, resulting in double refreshes. | Remove `refreshOverview()` from inside `saveSession()`. Let callers explicitly call `refreshOverview()` only when they need a UI update, avoiding redundant double refreshes. | ✅ |
 | **P25** | [utils.js](worksets@blipk.xyz/utils.js#L269-L281) | 269-281 | **Sparse array for signal IDs**. GLib source IDs can be large integers, creating arrays with thousands of empty slots. Should use `Map`. | Replace the sparse `this.signalIds[]` array with `new Map()` using `.set(id, target)` / `.get(id)` / `.delete(id)` for O(1) lookup without memory gaps. | ✅ |
 
@@ -301,11 +301,11 @@ Status: ⬜ Needs Fix · ✅ Fixed · ❌ Won't Fix
 | P29 | panelIndicator.js | 702-708 | `_worksetMenuItemMoveToTop` adds item then `_refreshMenu()` destroys and rebuilds all | Use `moveMenuItem()` directly on the existing menu item to reposition it, instead of re-creating it and triggering a full `_refreshMenu()` rebuild. | |
 | P30 | dialogs.js | throughout | `Array(x).map()` anti-pattern used as closure scope (6 instances) | Replace `Array(x).map(...)` with direct code blocks or IIFEs `(() => { ... })()` where scoping is needed. The Array constructor creates sparse arrays that `map()` skips over. | ❌ working as intended |
 | P31 | dialogs.js | 298-300 | Unused deep copy of `editableObject` (`_unreferencedObjectCopy` never read) | Remove the unused `_unreferencedObjectCopy = JSON.parse(JSON.stringify(editableObject))` line entirely, or implement cancel/revert functionality using it if that was the original intent. | ✅  |
-| P32 | uiUtils.js | 89-95 | `destroyIconButtons` has `destroy()` call commented out -- relies on parent cleanup | Uncomment the `iconButton.destroy()` call in `destroyIconButtons()` to properly clean up Clutter actors and prevent memory leaks when menus are recreated. | |
+| P32 | uiUtils.js | 89-95 | `destroyIconButtons` has `destroy()` call commented out -- relies on parent cleanup | Uncomment the `iconButton.destroy()` call in `destroyIconButtons()` to properly clean up Clutter actors and prevent memory leaks when menus are recreated. | ✅ already fixed in codebase |
 | P33 | uiUtils.js | 68 | `iconsButtonsPressIds` initialized to `iconButtons` (shared reference bug) | Initialize `parentItem.iconsButtonsPressIds = []` as a new empty array instead of assigning the `iconButtons` array reference, which causes the two arrays to share the same backing store. | ✅ already fixed in codebase |
 | P34 | dev.js | 76-82 | O(n^2) cycle detection in `JSON.stringify` replacer using `indexOf` instead of `Set` | Replace `seen.indexOf(val)` with a `new Set()` using `seen.has(val)` / `seen.add(val)` for O(1) cycle detection in the JSON.stringify replacer. | ✅ |
 | P35 | workspaceView.js | 303-311 | `add_child` called on label that may already be a child (causes Clutter warning) | Add a guard: check `if (thumbnailBox.worksetLabel?.get_parent()) return` before calling `add_child()`, or use `replace_child()` when updating an existing label. | ✅ |
-| P36 | shader.js | 14-28 | GLSL source string re-allocated on each `vfunc_get_static_shader_source()` call | Extract the GLSL source string to a module-level `const SHADER_SOURCE = "..."` constant and return it from the function to avoid re-allocating on every paint call. | |
+| P36 | shader.js | 14-28 | GLSL source string re-allocated on each `vfunc_get_static_shader_source()` call | Extract the GLSL source string to a module-level `const SHADER_SOURCE = "..."` constant and return it from the function to avoid re-allocating on every paint call. | ✅ |
 
 ---
 

_package.sh

@@ -5,6 +5,6 @@ rm -f ./worksets@blipk.xyz/schemas/gschemas.compiled
 glib-compile-schemas ./worksets@blipk.xyz/schemas
 rm -rf worksets@blipk.xyz.zip
 cd worksets@blipk.xyz
-bsdtar -a -cf ../worksets@blipk.xyz.zip *
+bsdtar -a -cf ../worksets@blipk.xyz.zip --exclude 'lib/ui/shader.js' *
 cd ..
 #zip worksets@blipk.xyz.zip install.sh 'Install Customised Workspaces.desktop'

prompt.txt

@@ -6,8 +6,3 @@ You can find the gnome shell associated libraries documentations here: https://g
 
 You can find the gnome-shell source code here if you need to analyze it: https://github.com/GNOME/gnome-shell/tree/main/js/ui
 
-
-
-
-TO FIX:
-- Menu items re-ordering

worksets@blipk.xyz.zip

@@ -50,6 +50,7 @@ import * as Main from "resource:///org/gnome/shell/ui/main.js"
 // Internal imports
 import * as dev from "./dev.js"
 import * as sessionManager from "./sessionManager.js"
+import * as uiUtils from "./lib/ui/uiUtils.js"
 
 export let WorksetsInstance = null
 
@@ -121,6 +122,7 @@ export default class Worksets extends Extension {
             dev.log( "!~~~~~~~~~~|" )
 
             this.session.saveSession()
+            uiUtils.clearKnownImages()
             if ( this.worksetsIndicator ) this.worksetsIndicator.destroy()
             delete this.worksetsIndicator
             delete Main.panel.statusArea["WorksetsIndicator"]

worksets@blipk.xyz/extension.js

@@ -8,25 +8,25 @@ import { gettext as _ } from "resource:///org/gnome/shell/extensions/extension.j
 import * as dev from "../../dev.js"
 
 // Shader example
+const OUTLINE_SHADER_SOURCE = `uniform sampler2D tex;
+    uniform vec4 v_color = vec4(0, 0, 0, 255);
+    const vec4 u_outlineColor = vec4(255, 255, 255, 250);
+    const float smoothing = 1.0/16.0;
+    const float outlineWidth = 3.0/16.0;
+    const float outerEdgeCenter = 0.5 - outlineWidth;
+
+    void main() {
+        float distance = texture2D(tex, cogl_tex_coord_in[0].xy).a;
+        float alpha = smoothstep(outerEdgeCenter - smoothing, outerEdgeCenter + smoothing, distance);
+        float border = smoothstep(0.5 - smoothing, 0.5 + smoothing, distance);
+        gl_FragColor = vec4( mix(u_outlineColor.rgb, v_color.rgb, border), alpha );
+    }`
+
 export var TextOutlineEffect = GObject.registerClass( {
     GTypeName: "TextOutlineEffect"
 }, class TextOutlineEffect extends Clutter.ShaderEffect {
     vfunc_get_static_shader_source() {
-        try {
-            return `uniform sampler2D tex;
-                uniform vec4 v_color = vec4(0, 0, 0, 255);
-                const vec4 u_outlineColor = vec4(255, 255, 255, 250);
-                const float smoothing = 1.0/16.0;
-                const float outlineWidth = 3.0/16.0;
-                const float outerEdgeCenter = 0.5 - outlineWidth;
-
-                void main() {
-                    float distance = texture2D(tex, cogl_tex_coord_in[0].xy).a;
-                    float alpha = smoothstep(outerEdgeCenter - smoothing, outerEdgeCenter + smoothing, distance);
-                    float border = smoothstep(0.5 - smoothing, 0.5 + smoothing, distance);
-                    gl_FragColor = vec4( mix(u_outlineColor.rgb, v_color.rgb, border), alpha );
-                }`
-        } catch ( e ) { dev.log( e ) }
+        return OUTLINE_SHADER_SOURCE
     }
 
     vfunc_paint_target( paint_context ) {

worksets@blipk.xyz/lib/ui/shader.js

@@ -89,7 +89,7 @@ export function createIconButton( parentItem, iconNames, callback, options, tool
             iconButton.leaveEvent] )
         parentItem.destroyIconButtons = function () {
             parentItem.iconButtons.forEach( function ( iconButton ) {
-                //iconButton.destroy();
+                iconButton.destroy?.()
             }, this )
             parentItem.iconButtons = []
             parentItem.iconsButtonsPressIds = []
@@ -190,7 +190,7 @@ export function createTooltip( widget, tooltip ) {
                         if ( widget.notificationLabel )
                             removeUserNotification( widget.notificationLabel, 1 )
                         return false
-                    } 
+                    }
                 )
                 Me.session.signals.add( widget._tooltipDisappearId )
                 return false
@@ -220,6 +220,10 @@ export function createTooltip( widget, tooltip ) {
 }
 
 export let knownImages = {} // Save on resources generating these in menu refreshes
+const KNOWN_IMAGES_MAX = 20
+export function clearKnownImages() {
+    knownImages = {}
+}
 export function setImage( parent, imgFilePath = "" ) {
     try {
         let error
@@ -234,7 +238,7 @@ export function setImage( parent, imgFilePath = "" ) {
         } else if ( imgFilePath ) {
             let pixbuf
             try {
-                pixbuf = GdkPixbuf.Pixbuf.new_from_file( imgFilePath )
+                pixbuf = GdkPixbuf.Pixbuf.new_from_file_at_scale( imgFilePath, -1, 150, true )
             } catch ( e ) {
                 dev.log( e )
                 // if ( e instanceof GLib.FileError )
@@ -267,6 +271,9 @@ export function setImage( parent, imgFilePath = "" ) {
             if ( !success ) throw Error( "error creating Clutter.Image()" )
 
             knownImages[imgFilePath] = image
+            const keys = Object.keys( knownImages )
+            if ( keys.length > KNOWN_IMAGES_MAX )
+                delete knownImages[keys[0]]
         }
 
         // Set the image content on parent (for both cached and newly loaded images)

worksets@blipk.xyz/lib/ui/uiUtils.js

@@ -293,9 +293,15 @@ export var WorksetsIndicator = GObject.registerClass( {
                 "starred-symbolic" : ["non-starred-symbolic", "starred-symbolic"]
             let iconOpenNew_nameuri = ( activeIndex > -1 ) ? "window-close-symbolic" : "window-new-symbolic"
             let iconOpenHere_nameuri = ( activeIndex > -1 ) ? "view-reveal-symbolic" : "go-jump-symbolic"
-            let openCloseCommand = ( activeIndex > -1 )
-                ? () => { Me.session.closeWorkset( menuItem.workset ); this._refreshMenu() }
-                : () => { Me.session.displayWorkset( menuItem.workset, true ); this._refreshMenu() }
+            let openCloseCommand = () => {
+                ( activeIndex > -1 )
+                    ? Me.session.closeWorkset( menuItem.workset )
+                    : Me.session.displayWorkset( menuItem.workset, true )
+
+                this._refreshMenu()
+                Me.workspaceViewManager.refreshOverview()
+            }
+
             let openCloseMsg = ( activeIndex > -1 )
                 ? "Disengage '" + menuItem.workset.WorksetName + "'"
                 : "Load '" + menuItem.workset.WorksetName + "' in a new workspace"