From edc8eab0f961d358a683f3cd566cf8affd26fe9a Mon Sep 17 00:00:00 2001 From: Ayush Singh Date: Fri, 21 Aug 2026 23:54:24 +0530 Subject: [PATCH] esplora: remove misleading TODO about maintaining a tx cache Fixes #2260 --- crates/esplora/src/async_ext.rs | 2 +- crates/esplora/src/blocking_ext.rs | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/crates/esplora/src/async_ext.rs b/crates/esplora/src/async_ext.rs index 2b38289526..eb1009943a 100644 --- a/crates/esplora/src/async_ext.rs +++ b/crates/esplora/src/async_ext.rs @@ -492,7 +492,7 @@ where let mut update = TxUpdate::::default(); // make sure txs exists in graph and tx statuses are updated - // TODO: We should maintain a tx cache (like we do with Electrum). + // Note: Esplora GET /scripthash/:hash/txs already returns full transactions, so a tx cache is not required. update.extend( fetch_txs_with_txids( client, diff --git a/crates/esplora/src/blocking_ext.rs b/crates/esplora/src/blocking_ext.rs index 225b574ea4..835dad9b3d 100644 --- a/crates/esplora/src/blocking_ext.rs +++ b/crates/esplora/src/blocking_ext.rs @@ -451,7 +451,7 @@ fn fetch_txs_with_outpoints>( let mut update = TxUpdate::::default(); // make sure txs exists in graph and tx statuses are updated - // TODO: We should maintain a tx cache (like we do with Electrum). + // Note: Esplora GET /scripthash/:hash/txs already returns full transactions, so a tx cache is not required. update.extend(fetch_txs_with_txids( client, start_time,