Exploration: bdk_tx + bdk_wallet#2
Closed
thunderbiscuit wants to merge 6 commits intobitcoindevkit:masterfrom
Closed
Exploration: bdk_tx + bdk_wallet#2thunderbiscuit wants to merge 6 commits intobitcoindevkit:masterfrom
thunderbiscuit wants to merge 6 commits intobitcoindevkit:masterfrom
Conversation
* Remove `PsbtUpdater` and `Builder`. * Introduce `PsbtParams` and `create_psbt` function.
thunderbiscuit
force-pushed
the
tests/build-tx-for-wallet
branch
from
3918196 to
eac7175
Compare
Member
Author
|
Oops I didn't realize changes had been pushed to #1. Will update later. |
thunderbiscuit
force-pushed
the
tests/build-tx-for-wallet
branch
2 times, most recently
from
8e63438 to
4ae1add
Compare
Member
Author
|
This cleaned it up nicely. |
Member
Author
|
The sister PR for this exploration is bitcoindevkit/bdk_wallet#15 |
thunderbiscuit
force-pushed
the
tests/build-tx-for-wallet
branch
from
4ae1add to
b1a505a
Compare
5 tasks
Member
Author
|
Closing this now as it's been useful but #1 has been merged and I don't need this directly anymore! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is really just to make public my hacking around the API exposed in #1. Not for merging.
I'm not super familiar with the test environment crate so ended up using my local regtest, but I'll see if I can switch it to the test environment for easy reproducibility.