Skip to content

Commit 826819a

Browse files
committed
Merge bitcoin/bitcoin#34939: fuzz: Use CAmount for storing best_waste
890a09b fuzz: Use CAmount for storing best_waste (Ava Chow) Pull request description: Waste is a CAmount, which is an int64_t. This will overflow an int, so `best_waste` should also be a `CAmount`. Fixes #34936 ACKs for top commit: murchandamus: ACK 890a09b furszy: ACK 890a09b Tree-SHA512: c6c4f530960f038675d4549c2285c6a4a828099a631486e317ec1215d89688ce109304654a95800978607c360c2ed34803523f5c56ebf7c2324ca095f87825b8
2 parents 2b6af62 + 890a09b commit 826819a

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

src/wallet/test/fuzz/coinselection.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -275,7 +275,7 @@ FUZZ_TARGET(bnb_finds_min_waste)
275275

276276
// Brute force optimal solution (lowest waste, but cannot be superset of another solution)
277277
std::vector<uint32_t> solutions;
278-
int best_waste{std::numeric_limits<int>::max()};
278+
CAmount best_waste{std::numeric_limits<int64_t>::max()};
279279
int best_weight{std::numeric_limits<int>::max()};
280280
for (uint32_t pattern = 1; (pattern >> num_groups) == 0; ++pattern) {
281281
// BnB does not permit adding more inputs to a solution, i.e. a superset of a solution cannot ever be a solution.

0 commit comments

Comments
 (0)