Skip to content

🐛 xtask executes rustfmt without edition config #7590

@turbocrime

Description

@turbocrime

in a freshly cloned repository after tools setup, any task that ultimately calls reformat_without_preamble (most codegen) will execute rustfmt directly, which ignores the edition config in Cargo.toml, causing rustfmt to fail.

this means just ready and other suggested workflow tasks cannot be executed, and provide confusing errors - "only allowed in Rust 2024" despite "style_edition=2024" clearly visible.

Image

it looks like there's an attempt to correct this by applying command-line flags equivalent to the rustfmt.toml config.

unfortunately the configured toolchain will refuse to handle let chains since rust-lang/rust#143214

Code of Conduct

  • I agree to follow Biome's Code of Conduct

Metadata

Metadata

Assignees

No one assigned

    Labels

    S-Needs triageStatus: this issue needs to be triaged

    Type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions